url
stringlengths 56
56
| repository_url
stringclasses 1
value | labels_url
stringlengths 70
70
| comments_url
stringlengths 65
65
| events_url
stringlengths 63
63
| html_url
stringlengths 44
46
| id
int64 570M
2.28B
| node_id
stringlengths 18
32
| number
int64 18.1k
29k
| title
stringlengths 1
570
| user
stringlengths 854
1.31k
| labels
stringclasses 293
values | state
stringclasses 2
values | locked
bool 2
classes | assignee
stringclasses 263
values | assignees
stringclasses 287
values | milestone
float64 | comments
sequencelengths 0
30
| created_at
stringlengths 19
19
| updated_at
stringlengths 19
19
| closed_at
stringlengths 19
19
⌀ | author_association
stringclasses 4
values | active_lock_reason
stringclasses 3
values | draft
bool 2
classes | pull_request
stringlengths 277
316
⌀ | body
stringlengths 1
43.2k
⌀ | reactions
stringlengths 189
198
| timeline_url
stringlengths 65
65
| performed_via_github_app
float64 | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/28606 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28606/labels{/name} | https://api.github.com/repos/facebook/react/issues/28606/comments | https://api.github.com/repos/facebook/react/issues/28606/events | https://github.com/facebook/react/pull/28606 | 2,200,497,468 | PR_kwDOAJy2Ks5qYZdI | 28,606 | [Fizz][Legacy] use static markup mode for renderToStaticNodeStream | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_url': 'https://api.github.com/users/gnoff/following{/other_user}', 'gists_url': 'https://api.github.com/users/gnoff/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gnoff/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gnoff/subscriptions', 'organizations_url': 'https://api.github.com/users/gnoff/orgs', 'repos_url': 'https://api.github.com/users/gnoff/repos', 'events_url': 'https://api.github.com/users/gnoff/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gnoff/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c75cd5e84c4c524f42e65027cfd3dce746d6916...ca63dc8706297829266def3ae1976f8f5cb0d54b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/ca63dc8706297829266def3ae1976f8f5cb0d54b/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.90 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/ca63dc8706297829266def3ae1976f8f5cb0d54b/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **=** | 173.26 kB | 173.26 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/ca63dc8706297829266def3ae1976f8f5cb0d54b/files/facebook-www/ReactDOM-prod.classic.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **=** | 594.27 kB | 594.27 kB | = | 104.44 kB | 104.44 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/ca63dc8706297829266def3ae1976f8f5cb0d54b/files/facebook-www/ReactDOM-prod.modern.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **=** | 577.53 kB | 577.53 kB | = | 101.47 kB | 101.47 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ca63dc8706297829266def3ae1976f8f5cb0d54b/files/__test_utils__/ReactAllWarnings.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ca63dc8706297829266def3ae1976f8f5cb0d54b/files/__test_utils__/ReactAllWarnings.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ca63dc8706297829266def3ae1976f8f5cb0d54b\n</p>\n"
] | 2024-03-21 15:28:02 | 2024-03-21 18:03:13 | 2024-03-21 18:03:10 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28606', 'html_url': 'https://github.com/facebook/react/pull/28606', 'diff_url': 'https://github.com/facebook/react/pull/28606.diff', 'patch_url': 'https://github.com/facebook/react/pull/28606.patch', 'merged_at': datetime.datetime(2024, 3, 21, 18, 3, 10)} | Since it was first implemented renderToStaticNodeStream never correctly set the renderer state to mark the output as static markup which means it was functionally the same as renderToNodeStream. This change fixes this oversight. While we are removing renderToNodeStream in a future version we never did deprecate the static version of this API because it has no immediate analog in the modern APIs.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28606/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28606/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28605 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28605/labels{/name} | https://api.github.com/repos/facebook/react/issues/28605/comments | https://api.github.com/repos/facebook/react/issues/28605/events | https://github.com/facebook/react/issues/28605 | 2,200,407,798 | I_kwDOAJy2Ks6DJ472 | 28,605 | Bug: Using the hook useDeferredValue - Suspense fallback didn't show the contents | {'login': 'lovizotto', 'id': 5727514, 'node_id': 'MDQ6VXNlcjU3Mjc1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5727514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lovizotto', 'html_url': 'https://github.com/lovizotto', 'followers_url': 'https://api.github.com/users/lovizotto/followers', 'following_url': 'https://api.github.com/users/lovizotto/following{/other_user}', 'gists_url': 'https://api.github.com/users/lovizotto/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lovizotto/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lovizotto/subscriptions', 'organizations_url': 'https://api.github.com/users/lovizotto/orgs', 'repos_url': 'https://api.github.com/users/lovizotto/repos', 'events_url': 'https://api.github.com/users/lovizotto/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lovizotto/received_events', 'type': 'User', 'site_admin': False} | [{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Needs%20More%20Information', 'name': 'Resolution: Needs More Information', 'color': 'fffde7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"@lovizotto Could you clarify the steps to reproduce? Ideally with a fork of the examples, concrete steps to reproduce, expected and actual behavior.",
"@lovizotto Yeah. The suspense fallback is not being displayed. @eps1lon I think the documentation itself as exposed by @lovizotto is a good example.",
"That is the intended behavior though. This is explained in the deep dive section:\r\n> In the background, React tries to re-render with both query and deferredQuery updated to \"ab\". If this re-render completes, React will show it on the screen. However, if it suspends (the results for \"ab\" have not loaded yet), React will abandon this rendering attempt, and retry this re-render again after the data has loaded. **The user will keep seeing the stale deferred value until the data is ready.**\r\n\r\n\r\nI emphasized the important bit that the user keeps seeing stale data instead of the Suspense fallback. \r\n\r\nThe [Suspense docs](https://react.dev/reference/react/Suspense) also say this:\r\n\r\n> If Suspense was displaying content for the tree, but then it suspended again, the fallback will be shown again unless the update causing it was caused by [startTransition](https://react.dev/reference/react/startTransition) or [useDeferredValue](https://react.dev/reference/react/useDeferredValue).\r\n\r\nSince the update was caused by `useDeferredValue`, we don't display the fallback again.\r\n\r\nDid you assume that a suspended component implies that a Suspense fallback is shown?",
"Yeah as @eps1lon said, this it expected, and one of the main features of `useDeferredValue`. If you wanted to force the fallback (not recommended) you wouldn't use `useDeferredValue`"
] | 2024-03-21 14:51:40 | 2024-03-23 15:15:53 | 2024-03-23 15:15:52 | NONE | null | null | null | React version: 18.2.0
## Steps To Reproduce
1. Go to [useDeferredValue](https://react.dev/reference/react/useDeferredValue)
2. See the second example of code in the documentation
| {'url': 'https://api.github.com/repos/facebook/react/issues/28605/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28605/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28604 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28604/labels{/name} | https://api.github.com/repos/facebook/react/issues/28604/comments | https://api.github.com/repos/facebook/react/issues/28604/events | https://github.com/facebook/react/pull/28604 | 2,199,495,302 | PR_kwDOAJy2Ks5qU8a0 | 28,604 | Sanity check for #28601 | {'login': 'unstubbable', 'id': 761683, 'node_id': 'MDQ6VXNlcjc2MTY4Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/761683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/unstubbable', 'html_url': 'https://github.com/unstubbable', 'followers_url': 'https://api.github.com/users/unstubbable/followers', 'following_url': 'https://api.github.com/users/unstubbable/following{/other_user}', 'gists_url': 'https://api.github.com/users/unstubbable/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/unstubbable/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/unstubbable/subscriptions', 'organizations_url': 'https://api.github.com/users/unstubbable/orgs', 'repos_url': 'https://api.github.com/users/unstubbable/repos', 'events_url': 'https://api.github.com/users/unstubbable/events{/privacy}', 'received_events_url': 'https://api.github.com/users/unstubbable/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4939017ffe2e04a94efca0f48b661bc778a6fa4...15fefa1ad927c1453113a8ef776d3081faf5f5f0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 176.84 kB | 176.84 kB | = | 54.92 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 173.27 kB | 173.27 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/facebook-www/ReactDOM-prod.classic.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 594.30 kB | 594.30 kB | = | 104.45 kB | 104.45 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/facebook-www/ReactDOM-prod.modern.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 577.56 kB | 577.56 kB | = | 101.48 kB | 101.48 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 141.99 kB | 141.61 kB | = | 32.22 kB | 32.04 kB\n| [oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 143.44 kB | 143.04 kB | = | 31.39 kB | 31.24 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 139.71 kB | 139.32 kB | = | 31.60 kB | 31.41 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 139.36 kB | 138.97 kB | = | 31.38 kB | 31.20 kB\n| [oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 140.87 kB | 140.47 kB | = | 30.70 kB | 30.54 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 137.11 kB | 136.73 kB | = | 31.27 kB | 31.10 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 137.07 kB | 136.68 kB | = | 30.79 kB | 30.60 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 136.06 kB | 135.68 kB | = | 30.95 kB | 30.63 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 135.18 kB | 134.80 kB | = | 30.76 kB | 30.58 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 133.62 kB | 133.23 kB | = | 30.26 kB | 29.91 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 130.91 kB | 130.52 kB | = | 29.72 kB | 29.54 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 120.31 kB | 119.92 kB | = | 27.92 kB | 27.81 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 120.31 kB | 119.92 kB | = | 27.92 kB | 27.81 kB\n| [oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 120.94 kB | 120.54 kB | = | 27.09 kB | 26.98 kB\n| [oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 120.94 kB | 120.54 kB | = | 27.09 kB | 26.98 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 118.02 kB | 117.64 kB | = | 27.30 kB | 27.19 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 118.02 kB | 117.64 kB | = | 27.30 kB | 27.19 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 117.67 kB | 117.29 kB | = | 27.04 kB | 26.94 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 117.67 kB | 117.29 kB | = | 27.04 kB | 26.94 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 116.96 kB | 116.58 kB | = | 27.22 kB | 27.11 kB\n| [oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 118.37 kB | 117.97 kB | = | 26.41 kB | 26.31 kB\n| [oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 118.37 kB | 117.97 kB | = | 26.41 kB | 26.31 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 115.38 kB | 115.00 kB | = | 26.47 kB | 26.36 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 115.38 kB | 115.00 kB | = | 26.47 kB | 26.36 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 114.95 kB | 114.57 kB | = | 26.82 kB | 26.72 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 114.95 kB | 114.57 kB | = | 26.82 kB | 26.72 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 114.89 kB | 114.51 kB | = | 26.66 kB | 26.55 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 114.58 kB | 114.19 kB | = | 26.76 kB | 26.65 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 114.58 kB | 114.19 kB | = | 26.76 kB | 26.65 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 114.30 kB | 113.92 kB | = | 26.32 kB | 26.21 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 113.02 kB | 112.64 kB | = | 26.31 kB | 26.21 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 113.02 kB | 112.64 kB | = | 26.31 kB | 26.21 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 112.23 kB | 111.84 kB | = | 25.83 kB | 25.72 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 112.13 kB | 111.75 kB | = | 26.08 kB | 25.97 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 112.13 kB | 111.75 kB | = | 26.08 kB | 25.97 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 111.78 kB | 111.39 kB | = | 26.26 kB | 26.16 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 111.46 kB | 111.07 kB | = | 26.19 kB | 26.08 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 110.05 kB | 109.67 kB | = | 25.82 kB | 25.72 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 109.22 kB | 108.83 kB | = | 25.50 kB | 25.40 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 109.22 kB | 108.83 kB | = | 25.50 kB | 25.40 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 109.21 kB | 108.82 kB | = | 25.58 kB | 25.47 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 106.80 kB | 106.42 kB | = | 25.02 kB | 24.92 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 106.80 kB | 106.42 kB | = | 25.02 kB | 24.92 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 106.08 kB | 105.69 kB | = | 24.82 kB | 24.71 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 104.73 kB | 104.35 kB | = | 24.47 kB | 24.38 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 104.73 kB | 104.35 kB | = | 24.47 kB | 24.38 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 104.15 kB | 103.76 kB | = | 24.13 kB | 24.03 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 104.15 kB | 103.76 kB | = | 24.13 kB | 24.03 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 102.07 kB | 101.68 kB | = | 23.64 kB | 23.54 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 102.07 kB | 101.68 kB | = | 23.64 kB | 23.54 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 101.17 kB | 100.78 kB | = | 23.90 kB | 23.81 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 101.17 kB | 100.78 kB | = | 23.90 kB | 23.81 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 100.85 kB | 100.46 kB | = | 23.84 kB | 23.74 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 100.85 kB | 100.46 kB | = | 23.84 kB | 23.74 kB\n| [facebook-www/ReactFlightDOMServer-dev.modern.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/facebook-www/ReactFlightDOMServer-dev.modern.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 101.90 kB | 101.50 kB | = | 21.16 kB | 21.04 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 99.44 kB | 99.06 kB | = | 23.46 kB | 23.37 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 99.44 kB | 99.06 kB | = | 23.46 kB | 23.37 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 98.60 kB | 98.21 kB | = | 23.24 kB | 23.13 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 98.60 kB | 98.21 kB | = | 23.24 kB | 23.13 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 95.92 kB | 95.53 kB | = | 22.65 kB | 22.55 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 95.92 kB | 95.53 kB | = | 22.65 kB | 22.55 kB\n| [oss-experimental/react-server/cjs/react-server-flight.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server/cjs/react-server-flight.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 93.16 kB | 92.78 kB | = | 21.15 kB | 20.82 kB\n| [oss-stable-semver/react-server/cjs/react-server-flight.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server/cjs/react-server-flight.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 72.35 kB | 71.97 kB | = | 17.23 kB | 17.11 kB\n| [oss-stable/react-server/cjs/react-server-flight.development.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server/cjs/react-server-flight.development.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 72.35 kB | 71.97 kB | = | 17.23 kB | 17.11 kB\n| [oss-experimental/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-experimental/react-server/cjs/react-server-flight.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 69.23 kB | 68.85 kB | = | 16.55 kB | 16.43 kB\n| [oss-stable-semver/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable-semver/react-server/cjs/react-server-flight.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 59.30 kB | 58.91 kB | = | 14.46 kB | 14.34 kB\n| [oss-stable/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/oss-stable/react-server/cjs/react-server-flight.production.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 59.30 kB | 58.91 kB | = | 14.46 kB | 14.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/15fefa1ad927c1453113a8ef776d3081faf5f5f0/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 15fefa1ad927c1453113a8ef776d3081faf5f5f0\n</p>\n",
"Sanity confirmed, closing."
] | 2024-03-21 08:18:56 | 2024-03-21 08:28:53 | 2024-03-21 08:28:39 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28604', 'html_url': 'https://github.com/facebook/react/pull/28604', 'diff_url': 'https://github.com/facebook/react/pull/28604.diff', 'patch_url': 'https://github.com/facebook/react/pull/28604.patch', 'merged_at': None} | This is to verify that the test that was added in #28601 does succeed in the CI, when temporarily reverting #28283.
After the CI run, I will close the PR again. | {'url': 'https://api.github.com/repos/facebook/react/issues/28604/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28604/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28603 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28603/labels{/name} | https://api.github.com/repos/facebook/react/issues/28603/comments | https://api.github.com/repos/facebook/react/issues/28603/events | https://github.com/facebook/react/issues/28603 | 2,199,466,329 | I_kwDOAJy2Ks6DGTFZ | 28,603 | Bug: React Dev tools extension showing wrong source file path on inspection | {'login': 'gittyvarshney', 'id': 47815255, 'node_id': 'MDQ6VXNlcjQ3ODE1MjU1', 'avatar_url': 'https://avatars.githubusercontent.com/u/47815255?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gittyvarshney', 'html_url': 'https://github.com/gittyvarshney', 'followers_url': 'https://api.github.com/users/gittyvarshney/followers', 'following_url': 'https://api.github.com/users/gittyvarshney/following{/other_user}', 'gists_url': 'https://api.github.com/users/gittyvarshney/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gittyvarshney/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gittyvarshney/subscriptions', 'organizations_url': 'https://api.github.com/users/gittyvarshney/orgs', 'repos_url': 'https://api.github.com/users/gittyvarshney/repos', 'events_url': 'https://api.github.com/users/gittyvarshney/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gittyvarshney/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hey @gittyvarshney, could you check out #28558 and see if this is the same issue?\r\n\r\nThanks! ❤️",
"> Hey @gittyvarshney, could you check out #28558 and see if this is the same issue?\r\n> \r\n> Thanks! ❤️\r\n\r\nyes, I think it's the same issue\r\nthanks",
"OK, thanks for checking! I think you can close this issue in favor of that one then.",
"Closing the issue, similar issues is being raised in another PR please track it on: https://github.com/facebook/react/issues/28558."
] | 2024-03-21 08:04:27 | 2024-03-23 07:17:48 | 2024-03-23 07:17:47 | NONE | null | null | null | When we try to inspect the component using react-dev-tools to find the file's path and line number, it is now showing path to file from some build folder (like *.mjs, *.js) rather than from the actual source file, I think something happened recently which somehow break down this very useful functionality.
React version:
## Steps To Reproduce
1. Run any react application in development mode
2. try to inspect the component from react-dev-tools and check its source
you can also clone this respository: https://github.com/gittyvarshney/phoneBook
`git clone https://github.com/gittyvarshney/phoneBook.git`
`npm install `
`npm run dev` | {'url': 'https://api.github.com/repos/facebook/react/issues/28603/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28603/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28602 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28602/labels{/name} | https://api.github.com/repos/facebook/react/issues/28602/comments | https://api.github.com/repos/facebook/react/issues/28602/events | https://github.com/facebook/react/pull/28602 | 2,198,639,864 | PR_kwDOAJy2Ks5qSAWU | 28,602 | Class components should consume the ref prop | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4939017ffe2e04a94efca0f48b661bc778a6fa4...5ae75aa8f629ed0e6f2ba6eb20f1a2f3dfc92733\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/5ae75aa8f629ed0e6f2ba6eb20f1a2f3dfc92733/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 176.84 kB | 176.84 kB | = | 54.92 kB | 54.92 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/5ae75aa8f629ed0e6f2ba6eb20f1a2f3dfc92733/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **+0.05%** | 173.27 kB | 173.34 kB | +0.05% | 54.04 kB | 54.07 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/5ae75aa8f629ed0e6f2ba6eb20f1a2f3dfc92733/files/facebook-www/ReactDOM-prod.classic.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **+0.06%** | 594.30 kB | 594.64 kB | +0.04% | 104.45 kB | 104.49 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/5ae75aa8f629ed0e6f2ba6eb20f1a2f3dfc92733/files/facebook-www/ReactDOM-prod.modern.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **+0.16%** | 577.56 kB | 578.51 kB | +0.06% | 101.48 kB | 101.55 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/5ae75aa8f629ed0e6f2ba6eb20f1a2f3dfc92733/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [facebook-www/ReactART-prod.modern.js](https://react-builds.vercel.app/commits/5ae75aa8f629ed0e6f2ba6eb20f1a2f3dfc92733/files/facebook-www/ReactART-prod.modern.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **+0.27%** | 353.24 kB | 354.19 kB | +0.13% | 59.82 kB | 59.90 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/5ae75aa8f629ed0e6f2ba6eb20f1a2f3dfc92733/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 5ae75aa8f629ed0e6f2ba6eb20f1a2f3dfc92733\n</p>\n",
"Replaced by #28719"
] | 2024-03-20 21:52:39 | 2024-04-02 22:25:32 | 2024-04-02 22:25:28 | MEMBER | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28602', 'html_url': 'https://github.com/facebook/react/pull/28602', 'diff_url': 'https://github.com/facebook/react/pull/28602.diff', 'patch_url': 'https://github.com/facebook/react/pull/28602.patch', 'merged_at': None} | Class components should consume the ref prop
With the `enableRefAsProp` flag enabled, refs are normal props and no longer filtered in the JSX runtime. Still, some APIs exist that conceptionally "consume" the ref since they bind the ref to a value. This includes `forwardRef` that already implemented filtering the `ref` prop out to the props passed to the inner component. We also need to do the same for class components. A `ref` passed a class component is bound to that class instance, if we keep the ref unfiltered and the component spreads all the props to a child component the `ref` would see 2 or more values set to it.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28602/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28602/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28601 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28601/labels{/name} | https://api.github.com/repos/facebook/react/issues/28601/comments | https://api.github.com/repos/facebook/react/issues/28601/events | https://github.com/facebook/react/pull/28601 | 2,198,593,225 | PR_kwDOAJy2Ks5qR1-X | 28,601 | Add a test for issue #28595 | {'login': 'unstubbable', 'id': 761683, 'node_id': 'MDQ6VXNlcjc2MTY4Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/761683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/unstubbable', 'html_url': 'https://github.com/unstubbable', 'followers_url': 'https://api.github.com/users/unstubbable/followers', 'following_url': 'https://api.github.com/users/unstubbable/following{/other_user}', 'gists_url': 'https://api.github.com/users/unstubbable/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/unstubbable/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/unstubbable/subscriptions', 'organizations_url': 'https://api.github.com/users/unstubbable/orgs', 'repos_url': 'https://api.github.com/users/unstubbable/repos', 'events_url': 'https://api.github.com/users/unstubbable/events{/privacy}', 'received_events_url': 'https://api.github.com/users/unstubbable/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4939017ffe2e04a94efca0f48b661bc778a6fa4...d5cbcd669581224a1da6e666614aaef9f2da7b5e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d5cbcd669581224a1da6e666614aaef9f2da7b5e/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 176.84 kB | 176.84 kB | = | 54.92 kB | 54.92 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d5cbcd669581224a1da6e666614aaef9f2da7b5e/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 173.27 kB | 173.27 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/d5cbcd669581224a1da6e666614aaef9f2da7b5e/files/facebook-www/ReactDOM-prod.classic.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 594.30 kB | 594.30 kB | = | 104.45 kB | 104.45 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/d5cbcd669581224a1da6e666614aaef9f2da7b5e/files/facebook-www/ReactDOM-prod.modern.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 577.56 kB | 577.56 kB | = | 101.48 kB | 101.48 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d5cbcd669581224a1da6e666614aaef9f2da7b5e/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d5cbcd669581224a1da6e666614aaef9f2da7b5e/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against d5cbcd669581224a1da6e666614aaef9f2da7b5e\n</p>\n",
"Oh cool, the test is indeed failing in the CI. ~Not sure why it succeeds on my machine though. 🤔~ (see comment below)",
"Duh, I need to run the tests with `-r=stable`, because only those failed.",
"superseded by #28620"
] | 2024-03-20 21:22:44 | 2024-03-23 16:52:04 | 2024-03-23 16:52:00 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28601', 'html_url': 'https://github.com/facebook/react/pull/28601', 'diff_url': 'https://github.com/facebook/react/pull/28601.diff', 'patch_url': 'https://github.com/facebook/react/pull/28601.patch', 'merged_at': None} | The added test, intended to fail and reproduce the [reported issue](https://github.com/facebook/react/issues/28595), unexpectedly passes in its current state. I see three possible reasons:
1. The bug report could be invalid.
2. How I've structured the test might be insufficient to replicate what `ai/rsc` is doing.
3. Something in the test setup could be masking the actual error. (Maybe related to fake timers?)
If the problem lies in reason 2 or 3, this test could possibly serve as a foundation for further investigation. | {'url': 'https://api.github.com/repos/facebook/react/issues/28601/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28601/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28600 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28600/labels{/name} | https://api.github.com/repos/facebook/react/issues/28600/comments | https://api.github.com/repos/facebook/react/issues/28600/events | https://github.com/facebook/react/pull/28600 | 2,198,568,794 | PR_kwDOAJy2Ks5qRwnJ | 28,600 | Ndivhu | {'login': 'CEEANPROJEC', 'id': 160164045, 'node_id': 'U_kgDOCYvozQ', 'avatar_url': 'https://avatars.githubusercontent.com/u/160164045?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/CEEANPROJEC', 'html_url': 'https://github.com/CEEANPROJEC', 'followers_url': 'https://api.github.com/users/CEEANPROJEC/followers', 'following_url': 'https://api.github.com/users/CEEANPROJEC/following{/other_user}', 'gists_url': 'https://api.github.com/users/CEEANPROJEC/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/CEEANPROJEC/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/CEEANPROJEC/subscriptions', 'organizations_url': 'https://api.github.com/users/CEEANPROJEC/orgs', 'repos_url': 'https://api.github.com/users/CEEANPROJEC/repos', 'events_url': 'https://api.github.com/users/CEEANPROJEC/events{/privacy}', 'received_events_url': 'https://api.github.com/users/CEEANPROJEC/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4939017ffe2e04a94efca0f48b661bc778a6fa4...a4939017ffe2e04a94efca0f48b661bc778a6fa4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/a4939017ffe2e04a94efca0f48b661bc778a6fa4/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 176.84 kB | 176.84 kB | = | 54.92 kB | 54.92 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/a4939017ffe2e04a94efca0f48b661bc778a6fa4/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 173.27 kB | 173.27 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/a4939017ffe2e04a94efca0f48b661bc778a6fa4/files/facebook-www/ReactDOM-prod.classic.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 594.30 kB | 594.30 kB | = | 104.45 kB | 104.45 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/a4939017ffe2e04a94efca0f48b661bc778a6fa4/files/facebook-www/ReactDOM-prod.modern.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 577.56 kB | 577.56 kB | = | 101.48 kB | 101.48 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/a4939017ffe2e04a94efca0f48b661bc778a6fa4/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/a4939017ffe2e04a94efca0f48b661bc778a6fa4/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against a4939017ffe2e04a94efca0f48b661bc778a6fa4\n</p>\n"
] | 2024-03-20 21:05:53 | 2024-03-20 21:13:54 | 2024-03-20 21:13:54 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28600', 'html_url': 'https://github.com/facebook/react/pull/28600', 'diff_url': 'https://github.com/facebook/react/pull/28600.diff', 'patch_url': 'https://github.com/facebook/react/pull/28600.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## bug fixing, space creation
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
[Application-bundle-main.zip](https://github.com/facebook/react/files/14672470/Application-bundle-main.zip)
| {'url': 'https://api.github.com/repos/facebook/react/issues/28600/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28600/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28599 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28599/labels{/name} | https://api.github.com/repos/facebook/react/issues/28599/comments | https://api.github.com/repos/facebook/react/issues/28599/events | https://github.com/facebook/react/pull/28599 | 2,198,490,602 | PR_kwDOAJy2Ks5qRfak | 28,599 | Use `declare const` instead of `declare var` | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4939017ffe2e04a94efca0f48b661bc778a6fa4...f7441a91ffaed141b4f0389313a3bad980616744\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/f7441a91ffaed141b4f0389313a3bad980616744/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 176.84 kB | 176.84 kB | = | 54.92 kB | 54.92 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/f7441a91ffaed141b4f0389313a3bad980616744/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 173.27 kB | 173.27 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/f7441a91ffaed141b4f0389313a3bad980616744/files/facebook-www/ReactDOM-prod.classic.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 594.30 kB | 594.30 kB | = | 104.45 kB | 104.45 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/f7441a91ffaed141b4f0389313a3bad980616744/files/facebook-www/ReactDOM-prod.modern.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 577.56 kB | 577.56 kB | = | 101.48 kB | 101.48 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f7441a91ffaed141b4f0389313a3bad980616744/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f7441a91ffaed141b4f0389313a3bad980616744/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against f7441a91ffaed141b4f0389313a3bad980616744\n</p>\n"
] | 2024-03-20 20:23:07 | 2024-03-25 17:56:22 | 2024-03-22 15:20:19 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28599', 'html_url': 'https://github.com/facebook/react/pull/28599', 'diff_url': 'https://github.com/facebook/react/pull/28599.diff', 'patch_url': 'https://github.com/facebook/react/pull/28599.patch', 'merged_at': datetime.datetime(2024, 3, 22, 15, 20, 19)} | Use `declare const` instead of `declare var`
| {'url': 'https://api.github.com/repos/facebook/react/issues/28599/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28599/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28598 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28598/labels{/name} | https://api.github.com/repos/facebook/react/issues/28598/comments | https://api.github.com/repos/facebook/react/issues/28598/events | https://github.com/facebook/react/pull/28598 | 2,198,444,526 | PR_kwDOAJy2Ks5qRVRv | 28,598 | Update RTR usage in ReactLazy-test | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', 'following_url': 'https://api.github.com/users/jackpope/following{/other_user}', 'gists_url': 'https://api.github.com/users/jackpope/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jackpope/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jackpope/subscriptions', 'organizations_url': 'https://api.github.com/users/jackpope/orgs', 'repos_url': 'https://api.github.com/users/jackpope/repos', 'events_url': 'https://api.github.com/users/jackpope/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jackpope/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4939017ffe2e04a94efca0f48b661bc778a6fa4...d5d4adeb10ac8886d2163608d54cd3b57e15fd9c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d5d4adeb10ac8886d2163608d54cd3b57e15fd9c/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 176.84 kB | 176.84 kB | = | 54.92 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d5d4adeb10ac8886d2163608d54cd3b57e15fd9c/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 173.27 kB | 173.27 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/d5d4adeb10ac8886d2163608d54cd3b57e15fd9c/files/facebook-www/ReactDOM-prod.classic.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 594.30 kB | 594.30 kB | = | 104.45 kB | 104.45 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/d5d4adeb10ac8886d2163608d54cd3b57e15fd9c/files/facebook-www/ReactDOM-prod.modern.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 577.56 kB | 577.56 kB | = | 101.48 kB | 101.48 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d5d4adeb10ac8886d2163608d54cd3b57e15fd9c/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d5d4adeb10ac8886d2163608d54cd3b57e15fd9c/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against d5d4adeb10ac8886d2163608d54cd3b57e15fd9c\n</p>\n"
] | 2024-03-20 19:57:48 | 2024-03-21 17:28:23 | 2024-03-21 17:28:20 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28598', 'html_url': 'https://github.com/facebook/react/pull/28598', 'diff_url': 'https://github.com/facebook/react/pull/28598.diff', 'patch_url': 'https://github.com/facebook/react/pull/28598.patch', 'merged_at': datetime.datetime(2024, 3, 21, 17, 28, 20)} | - Make all test cases in ReactLazy use RTR with concurrent root
- Except, two cases with "legacy mode" specified in description. These are moved to a separate description block where the disableLegacyMode flag is turned off to allow RTR to use legacy root after https://github.com/facebook/react/pull/28498
| {'url': 'https://api.github.com/repos/facebook/react/issues/28598/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28598/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28597 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28597/labels{/name} | https://api.github.com/repos/facebook/react/issues/28597/comments | https://api.github.com/repos/facebook/react/issues/28597/events | https://github.com/facebook/react/pull/28597 | 2,198,243,843 | PR_kwDOAJy2Ks5qQp0P | 28,597 | Deprecate `act` from `react-dom/test-utils` in favor of act from `react` | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7...d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **=** | 176.92 kB | 176.92 kB | = | 54.99 kB | 54.99 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **=** | 173.10 kB | 173.10 kB | = | 53.94 kB | 53.94 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/facebook-www/ReactDOM-prod.classic.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **=** | 592.31 kB | 592.31 kB | = | 103.83 kB | 103.83 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/facebook-www/ReactDOM-prod.modern.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **=** | 573.20 kB | 573.20 kB | = | 100.71 kB | 100.71 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-experimental/react-dom/cjs/react-dom-test-utils.development.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+5.99%** | 26.38 kB | 27.96 kB | +8.76% | 7.19 kB | 7.82 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-experimental/react-dom/umd/react-dom-test-utils.development.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+5.88%** | 28.06 kB | 29.71 kB | +8.51% | 7.34 kB | 7.97 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.87%** | 8.59 kB | 8.84 kB | +3.22% | 2.67 kB | 2.76 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.83%** | 8.73 kB | 8.98 kB | +2.70% | 2.75 kB | 2.82 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.07%** | 11.94 kB | 12.19 kB | +2.58% | 4.66 kB | 4.78 kB\n| [oss-stable/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable/react-dom/cjs/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.07%** | 11.94 kB | 12.19 kB | +2.58% | 4.66 kB | 4.78 kB\n| [oss-stable-semver/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable-semver/react-dom/umd/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.04%** | 12.03 kB | 12.28 kB | +2.77% | 4.70 kB | 4.83 kB\n| [oss-stable/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable/react-dom/umd/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.04%** | 12.03 kB | 12.28 kB | +2.77% | 4.70 kB | 4.83 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/__test_utils__/ReactAllWarnings.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **Deleted** | 65.07 kB | 0.00 kB | Deleted | 16.27 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-experimental/react-dom/cjs/react-dom-test-utils.development.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+5.99%** | 26.38 kB | 27.96 kB | +8.76% | 7.19 kB | 7.82 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-experimental/react-dom/umd/react-dom-test-utils.development.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+5.88%** | 28.06 kB | 29.71 kB | +8.51% | 7.34 kB | 7.97 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.87%** | 8.59 kB | 8.84 kB | +3.22% | 2.67 kB | 2.76 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.83%** | 8.73 kB | 8.98 kB | +2.70% | 2.75 kB | 2.82 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.07%** | 11.94 kB | 12.19 kB | +2.58% | 4.66 kB | 4.78 kB\n| [oss-stable/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable/react-dom/cjs/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.07%** | 11.94 kB | 12.19 kB | +2.58% | 4.66 kB | 4.78 kB\n| [oss-stable-semver/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable-semver/react-dom/umd/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.04%** | 12.03 kB | 12.28 kB | +2.77% | 4.70 kB | 4.83 kB\n| [oss-stable/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable/react-dom/umd/react-dom-test-utils.production.min.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+2.04%** | 12.03 kB | 12.28 kB | +2.77% | 4.70 kB | 4.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+1.20%** | 26.34 kB | 26.65 kB | +0.95% | 7.16 kB | 7.23 kB\n| [facebook-www/ReactTestUtils-dev.classic.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/facebook-www/ReactTestUtils-dev.classic.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+0.60%** | 51.14 kB | 51.45 kB | +0.38% | 13.07 kB | 13.12 kB\n| [facebook-www/ReactTestUtils-dev.modern.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/facebook-www/ReactTestUtils-dev.modern.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+0.60%** | 51.14 kB | 51.45 kB | +0.38% | 13.07 kB | 13.12 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+0.57%** | 42.65 kB | 42.90 kB | +0.50% | 12.11 kB | 12.17 kB\n| [oss-stable/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable/react-dom/cjs/react-dom-test-utils.production.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+0.57%** | 42.65 kB | 42.90 kB | +0.50% | 12.11 kB | 12.17 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable-semver/react-dom/cjs/react-dom-test-utils.development.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+0.53%** | 44.65 kB | 44.89 kB | +0.35% | 12.88 kB | 12.92 kB\n| [oss-stable/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable/react-dom/cjs/react-dom-test-utils.development.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+0.53%** | 44.65 kB | 44.89 kB | +0.35% | 12.88 kB | 12.92 kB\n| [oss-stable-semver/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable-semver/react-dom/umd/react-dom-test-utils.development.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+0.53%** | 47.42 kB | 47.67 kB | +0.36% | 13.10 kB | 13.15 kB\n| [oss-stable/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/oss-stable/react-dom/umd/react-dom-test-utils.development.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **+0.53%** | 47.42 kB | 47.67 kB | +0.36% | 13.10 kB | 13.15 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7/files/__test_utils__/ReactAllWarnings.js?compare=ec4d26ceb8bbb622188c858b6b3d1a5f1e86f2f7) | **Deleted** | 65.07 kB | 0.00 kB | Deleted | 16.27 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against d8733fa2a7c9b9b140b5b6d1f66aa05423d5cda7\n</p>\n"
] | 2024-03-20 18:18:25 | 2024-03-27 15:28:03 | 2024-03-27 15:28:01 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28597', 'html_url': 'https://github.com/facebook/react/pull/28597', 'diff_url': 'https://github.com/facebook/react/pull/28597.diff', 'patch_url': 'https://github.com/facebook/react/pull/28597.patch', 'merged_at': datetime.datetime(2024, 3, 27, 15, 28, 1)} | Stacked on https://github.com/facebook/react/pull/28541/
## Summary
Use `React.act` instead:
```diff
-import {act} from 'react-dom/test-utils'
+import {act} from 'react'
```
## How did you test this change?
- using `React.act` now instead of `ReactDOMTestUtils` when testing the public `act`
- added test for the new warning
| {'url': 'https://api.github.com/repos/facebook/react/issues/28597/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28597/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28596 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28596/labels{/name} | https://api.github.com/repos/facebook/react/issues/28596/comments | https://api.github.com/repos/facebook/react/issues/28596/events | https://github.com/facebook/react/pull/28596 | 2,197,943,014 | PR_kwDOAJy2Ks5qPmSX | 28,596 | Guard against legacy context not being supported in DevTools fixture | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [] | 2024-03-20 16:12:21 | 2024-03-25 13:30:10 | 2024-03-25 13:30:08 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28596', 'html_url': 'https://github.com/facebook/react/pull/28596', 'diff_url': 'https://github.com/facebook/react/pull/28596.diff', 'patch_url': 'https://github.com/facebook/react/pull/28596.patch', 'merged_at': datetime.datetime(2024, 3, 25, 13, 30, 8)} | Legacy context was removed from experimental builds so the default setup would hide important fixtures.
Now it just assumes that any crash within the tree rendering legacy context is due to legacy context not being supported.
I didn't remove the components entirely since this fixture can be used with older versions of React where we would want to check if legacy context still works.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28596/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28596/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28595 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28595/labels{/name} | https://api.github.com/repos/facebook/react/issues/28595/comments | https://api.github.com/repos/facebook/react/issues/28595/events | https://github.com/facebook/react/issues/28595 | 2,197,877,618 | I_kwDOAJy2Ks6DAPNy | 28,595 | Bug: [Flight] Async server components in `ai/rsc` not rendered correctly | {'login': 'unstubbable', 'id': 761683, 'node_id': 'MDQ6VXNlcjc2MTY4Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/761683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/unstubbable', 'html_url': 'https://github.com/unstubbable', 'followers_url': 'https://api.github.com/users/unstubbable/followers', 'following_url': 'https://api.github.com/users/unstubbable/following{/other_user}', 'gists_url': 'https://api.github.com/users/unstubbable/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/unstubbable/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/unstubbable/subscriptions', 'organizations_url': 'https://api.github.com/users/unstubbable/orgs', 'repos_url': 'https://api.github.com/users/unstubbable/repos', 'events_url': 'https://api.github.com/users/unstubbable/events{/privacy}', 'received_events_url': 'https://api.github.com/users/unstubbable/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"A potential fix is mentioned in the code comments of https://github.com/facebook/react/pull/28283:\r\n>We should really detect whether this already was emitted and synchronously available. In that case we can refer to it synchronously and only make it lazy otherwise. We currently don't have a data structure that lets us see that though."
] | 2024-03-20 15:45:57 | 2024-04-01 16:37:28 | 2024-04-01 16:37:28 | CONTRIBUTOR | null | null | null | When returning an async server component from an `ai/rsc` tool's `render` function, a reference to it is not serialized as a lazy node, even though it might not have been emitted as a row yet. Currently the React Flight Client is not resilient to this. This leads to the reference not being resolved correctly, and then `null` is rendered instead of the element.
The bug was introduced with #28283.
React version: 18.3.0-canary-6c3b8dbfe-20240226 (via Next.js v14.2.0-canary.30)
## Steps To Reproduce
1. Build `ai/rsc` example according to https://sdk.vercel.ai/docs/concepts/ai-rsc#build-your-app
2. Move data fetching from `render` function to an async server component
(It's probably also reproducible by writing a unit test that replicates what's being done in https://github.com/vercel/ai/blob/main/packages/core/rsc/utils.tsx#L17-L50. I might try this later... [done](https://github.com/facebook/react/pull/28601))
Link to code example: https://github.com/unstubbable/ai-rsc-test/pull/1
This contains the code of step 2 from above, has more details about the expected and actual RSC responses, and also shows in the comments how I arrived at my conclusion. | {'url': 'https://api.github.com/repos/facebook/react/issues/28595/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28595/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28594 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28594/labels{/name} | https://api.github.com/repos/facebook/react/issues/28594/comments | https://api.github.com/repos/facebook/react/issues/28594/events | https://github.com/facebook/react/issues/28594 | 2,197,685,317 | I_kwDOAJy2Ks6C_gRF | 28,594 | useMemo reruns when the dependencies not changed when memoised value is a fn | {'login': 'PradeepNedun', 'id': 11734654, 'node_id': 'MDQ6VXNlcjExNzM0NjU0', 'avatar_url': 'https://avatars.githubusercontent.com/u/11734654?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/PradeepNedun', 'html_url': 'https://github.com/PradeepNedun', 'followers_url': 'https://api.github.com/users/PradeepNedun/followers', 'following_url': 'https://api.github.com/users/PradeepNedun/following{/other_user}', 'gists_url': 'https://api.github.com/users/PradeepNedun/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/PradeepNedun/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/PradeepNedun/subscriptions', 'organizations_url': 'https://api.github.com/users/PradeepNedun/orgs', 'repos_url': 'https://api.github.com/users/PradeepNedun/repos', 'events_url': 'https://api.github.com/users/PradeepNedun/events{/privacy}', 'received_events_url': 'https://api.github.com/users/PradeepNedun/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hey there @PradeepNedun! 👋\r\n\r\nI can't access the sandbox you linked to. Did you forget to set it to be publicly viewable?\r\n\r\n<!-- hidden for brevity  -->\r\n\r\nThanks! ❤️",
"I am sorry for that, try now \r\nhttps://codesandbox.io/p/sandbox/react-dev-forked-8whdhd?file=%2Fsrc%2FTodoList.js&layout=%257B%2522sidebarPanel%2522%253A%2522EXPLORER%2522%252C%2522rootPanelGroup%2522%253A%257B%2522direction%2522%253A%2522horizontal%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522id%2522%253A%2522ROOT_LAYOUT%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522cltzulzzm00073b6hrbfulewd%2522%252C%2522sizes%2522%253A%255B100%252C0%255D%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522EDITOR%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522id%2522%253A%2522cltzulzzm00033b6hhfkxfr0h%2522%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522SHELLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522id%2522%253A%2522cltzulzzm00043b6h9n965srz%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522DEVTOOLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522id%2522%253A%2522cltzulzzm00063b6hs3v0n4os%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%252C%2522sizes%2522%253A%255B43.170419378935016%252C56.829580621064984%255D%257D%252C%2522tabbedPanels%2522%253A%257B%2522cltzulzzm00033b6hhfkxfr0h%2522%253A%257B%2522id%2522%253A%2522cltzulzzm00033b6hhfkxfr0h%2522%252C%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522cltzus0z1006i3b6h8fpbgr8j%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252Fsrc%252FTodoList.js%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%255D%252C%2522activeTabId%2522%253A%2522cltzus0z1006i3b6h8fpbgr8j%2522%257D%252C%2522cltzulzzm00063b6hs3v0n4os%2522%253A%257B%2522id%2522%253A%2522cltzulzzm00063b6hs3v0n4os%2522%252C%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522cltzulzzm00053b6hdn6554xj%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522UNASSIGNED_PORT%2522%252C%2522port%2522%253A0%252C%2522path%2522%253A%2522%252F%2522%257D%255D%252C%2522activeTabId%2522%253A%2522cltzulzzm00053b6hdn6554xj%2522%257D%252C%2522cltzulzzm00043b6h9n965srz%2522%253A%257B%2522tabs%2522%253A%255B%255D%252C%2522id%2522%253A%2522cltzulzzm00043b6h9n965srz%2522%257D%257D%252C%2522showDevtools%2522%253Atrue%252C%2522showShells%2522%253Afalse%252C%2522showSidebar%2522%253Atrue%252C%2522sidebarPanelSize%2522%253A15%257D",
"@PradeepNedun I don't see anything wrong here. the `memo re-render` log only fires when the dependencies of the useMemo changes (specifically only when the `tab` changes, since `todos` is created once in the module scope and never updated.\r\n\r\nThe `memo value` log fires any time the `TodoList` component renders (including when changing the theme) but that's because you're calling that function in render. So of course, if you call a function in render, then that function is called whenever the component renders.\r\n\r\nTo fix, you filter the todos and return them from `useMemo`directly, instead of returning a function:\r\n\r\n```js\r\nconst filteredTodos = useMemo(() => {\r\n console.log('memo')\r\n return filterTodos(todos, tab);\r\n}, [todos, tab]);\r\n \r\n// ...\r\nfilteredTodos.map((todo) => <div> ...</div>);\r\n```\r\nWith this, the expensive filterTodos function will only run when either the `todos` or `tab` values change."
] | 2024-03-20 14:29:55 | 2024-03-23 20:22:07 | 2024-03-23 20:22:06 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18
Please refer the codesandbox link
https://codesandbox.io/p/sandbox/react-dev-forked-8whdhd?file=%2Fsrc%2FTodoList.js%3A25%2C11
## Steps To Reproduce
useMemo reruns when the dependencies not changed when returned value is anonymous function.
Link to code example:
https://codesandbox.io/p/sandbox/react-dev-forked-8whdhd?file=%2Fsrc%2FTodoList.js%3A25%2C11
## The current behavior
memoised fn re renders.
## The expected behavior
memoised fn not to re render. | {'url': 'https://api.github.com/repos/facebook/react/issues/28594/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28594/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28593 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28593/labels{/name} | https://api.github.com/repos/facebook/react/issues/28593/comments | https://api.github.com/repos/facebook/react/issues/28593/events | https://github.com/facebook/react/pull/28593 | 2,197,370,027 | PR_kwDOAJy2Ks5qNoco | 28,593 | DevTools: Rely on sourcemaps to compute hook name of built-in hooks in newer versions | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cb6dc7a6a03ea10a38b84e9e5737739e0d468435...9688f14958cf0fd3673fa56ae48948a6bcacf77b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **=** | 169.31 kB | 169.31 kB | = | 52.76 kB | 52.76 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **=** | 171.13 kB | 171.13 kB | = | 53.33 kB | 53.33 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/facebook-www/ReactDOM-prod.classic.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **=** | 589.36 kB | 589.36 kB | = | 103.73 kB | 103.73 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/facebook-www/ReactDOM-prod.modern.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **=** | 566.39 kB | 566.39 kB | = | 99.64 kB | 99.64 kB\n| [oss-experimental/react-debug-tools/cjs/react-debug-tools.production.min.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-experimental/react-debug-tools/cjs/react-debug-tools.production.min.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+6.70%** | 11.24 kB | 12.00 kB | +3.69% | 3.63 kB | 3.76 kB\n| [oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.min.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.min.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+6.70%** | 11.24 kB | 12.00 kB | +3.69% | 3.63 kB | 3.76 kB\n| [oss-stable/react-debug-tools/cjs/react-debug-tools.production.min.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-stable/react-debug-tools/cjs/react-debug-tools.production.min.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+6.70%** | 11.24 kB | 12.00 kB | +3.69% | 3.63 kB | 3.76 kB\n| [oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+4.04%** | 34.29 kB | 35.68 kB | +3.24% | 8.25 kB | 8.52 kB\n| [oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+4.04%** | 34.29 kB | 35.68 kB | +3.24% | 8.25 kB | 8.52 kB\n| [oss-stable/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-stable/react-debug-tools/cjs/react-debug-tools.development.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+4.04%** | 34.29 kB | 35.68 kB | +3.24% | 8.25 kB | 8.52 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/__test_utils__/ReactAllWarnings.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **Deleted** | 64.58 kB | 0.00 kB | Deleted | 16.14 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-debug-tools/cjs/react-debug-tools.production.min.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-experimental/react-debug-tools/cjs/react-debug-tools.production.min.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+6.70%** | 11.24 kB | 12.00 kB | +3.69% | 3.63 kB | 3.76 kB\n| [oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.min.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.min.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+6.70%** | 11.24 kB | 12.00 kB | +3.69% | 3.63 kB | 3.76 kB\n| [oss-stable/react-debug-tools/cjs/react-debug-tools.production.min.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-stable/react-debug-tools/cjs/react-debug-tools.production.min.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+6.70%** | 11.24 kB | 12.00 kB | +3.69% | 3.63 kB | 3.76 kB\n| [oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+4.04%** | 34.29 kB | 35.68 kB | +3.24% | 8.25 kB | 8.52 kB\n| [oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+4.04%** | 34.29 kB | 35.68 kB | +3.24% | 8.25 kB | 8.52 kB\n| [oss-stable/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/oss-stable/react-debug-tools/cjs/react-debug-tools.development.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **+4.04%** | 34.29 kB | 35.68 kB | +3.24% | 8.25 kB | 8.52 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9688f14958cf0fd3673fa56ae48948a6bcacf77b/files/__test_utils__/ReactAllWarnings.js?compare=cb6dc7a6a03ea10a38b84e9e5737739e0d468435) | **Deleted** | 64.58 kB | 0.00 kB | Deleted | 16.14 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 9688f14958cf0fd3673fa56ae48948a6bcacf77b\n</p>\n",
"Nice to see the sourcemaps work I did coming in handy! :)"
] | 2024-03-20 12:05:59 | 2024-04-11 20:01:57 | 2024-04-11 20:00:54 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28593', 'html_url': 'https://github.com/facebook/react/pull/28593', 'diff_url': 'https://github.com/facebook/react/pull/28593.diff', 'patch_url': 'https://github.com/facebook/react/pull/28593.patch', 'merged_at': datetime.datetime(2024, 4, 11, 20, 0, 54)} | Stack:
1. https://github.com/facebook/react/pull/28593 <--- You're here
1. https://github.com/facebook/react/pull/28413
1. https://github.com/facebook/react/pull/28728
## Summary
As a fallback, we assume the dispatcher method name is the hook name. This holds for currently released React versions.
As a follow-up, we introduce a separate field that holds the list of possible wrappers we try to match against e.g. for `useFormStatus` -> `dispatcher.useHostTransitionStatus` (see https://github.com/facebook/react/pull/28413)
One downside is that sourcemaps are bugged in Jest tests and browsers (but not Node.js). See https://github.com/facebook/react/pull/28413#discussion_r1513318378. I'm trying to find out what's up with that.
## How did you test this change?
- [x] react-debug-tools tests
- [x] inspected components with hooks (e.g. `FunctionWithHooks`) in the shell (requires https://github.com/facebook/react/pull/28596)
- [x] Backwards compat with 16.8: https://8qq2sv.csb.app/
- [x] Backwards compat with 17.0: https://g67r45.csb.app/
- [x] Backwards compat with 18.0: https://ydjfsq.csb.app/
- [x] Compat with Experimental: https://react-devtools-hook-inspection-experimental.vercel.app/
| {'url': 'https://api.github.com/repos/facebook/react/issues/28593/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28593/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28591 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28591/labels{/name} | https://api.github.com/repos/facebook/react/issues/28591/comments | https://api.github.com/repos/facebook/react/issues/28591/events | https://github.com/facebook/react/pull/28591 | 2,196,259,710 | PR_kwDOAJy2Ks5qKLND | 28,591 | Update gate pragma to detect global error events | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 82c6595e758679adf518e69794ba8d11b97a6bd1...ad6b1c16975a5418afc5880d7c9da61928ca5cb4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/ad6b1c16975a5418afc5880d7c9da61928ca5cb4/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=82c6595e758679adf518e69794ba8d11b97a6bd1) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.90 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/ad6b1c16975a5418afc5880d7c9da61928ca5cb4/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=82c6595e758679adf518e69794ba8d11b97a6bd1) | **=** | 173.26 kB | 173.26 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/ad6b1c16975a5418afc5880d7c9da61928ca5cb4/files/facebook-www/ReactDOM-prod.classic.js?compare=82c6595e758679adf518e69794ba8d11b97a6bd1) | **=** | 594.27 kB | 594.27 kB | = | 104.44 kB | 104.44 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/ad6b1c16975a5418afc5880d7c9da61928ca5cb4/files/facebook-www/ReactDOM-prod.modern.js?compare=82c6595e758679adf518e69794ba8d11b97a6bd1) | **=** | 577.53 kB | 577.53 kB | = | 101.47 kB | 101.47 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ad6b1c16975a5418afc5880d7c9da61928ca5cb4/files/__test_utils__/ReactAllWarnings.js?compare=82c6595e758679adf518e69794ba8d11b97a6bd1) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ad6b1c16975a5418afc5880d7c9da61928ca5cb4/files/__test_utils__/ReactAllWarnings.js?compare=82c6595e758679adf518e69794ba8d11b97a6bd1) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ad6b1c16975a5418afc5880d7c9da61928ca5cb4\n</p>\n"
] | 2024-03-19 23:45:02 | 2024-03-20 01:08:37 | 2024-03-20 01:08:37 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28591', 'html_url': 'https://github.com/facebook/react/pull/28591', 'diff_url': 'https://github.com/facebook/react/pull/28591.diff', 'patch_url': 'https://github.com/facebook/react/pull/28591.patch', 'merged_at': datetime.datetime(2024, 3, 20, 1, 8, 37)} | If a global error event is dispatched during a test, Jest reports that test as a failure.
Our `@gate` pragma feature should account for this — if the gate condition is false, and the global error event is dispatched, then the test should be reported as a success.
The solution is to install an error event handler right before invoking the test function. Because we install our own handler, Jest will not report the test as a failure if a global error event is dispatched; it's conceptually as if we wrapped the whole test event in a try-catch. | {'url': 'https://api.github.com/repos/facebook/react/issues/28591/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28591/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28590 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28590/labels{/name} | https://api.github.com/repos/facebook/react/issues/28590/comments | https://api.github.com/repos/facebook/react/issues/28590/events | https://github.com/facebook/react/pull/28590 | 2,196,050,779 | PR_kwDOAJy2Ks5qJcUv | 28,590 | Also apply content hash for experimental files | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cb076b593cec3a92338958f58468cce19cb8f0d9...f98f06327fa8b7e04c1de6a6e55528feb9277710\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/f98f06327fa8b7e04c1de6a6e55528feb9277710/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=cb076b593cec3a92338958f58468cce19cb8f0d9) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/f98f06327fa8b7e04c1de6a6e55528feb9277710/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=cb076b593cec3a92338958f58468cce19cb8f0d9) | **=** | 173.26 kB | 173.26 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/f98f06327fa8b7e04c1de6a6e55528feb9277710/files/facebook-www/ReactDOM-prod.classic.js?compare=cb076b593cec3a92338958f58468cce19cb8f0d9) | **=** | 594.27 kB | 594.27 kB | = | 104.44 kB | 104.44 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/f98f06327fa8b7e04c1de6a6e55528feb9277710/files/facebook-www/ReactDOM-prod.modern.js?compare=cb076b593cec3a92338958f58468cce19cb8f0d9) | **=** | 577.53 kB | 577.53 kB | = | 101.47 kB | 101.47 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f98f06327fa8b7e04c1de6a6e55528feb9277710/files/__test_utils__/ReactAllWarnings.js?compare=cb076b593cec3a92338958f58468cce19cb8f0d9) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f98f06327fa8b7e04c1de6a6e55528feb9277710/files/__test_utils__/ReactAllWarnings.js?compare=cb076b593cec3a92338958f58468cce19cb8f0d9) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against f98f06327fa8b7e04c1de6a6e55528feb9277710\n</p>\n"
] | 2024-03-19 21:23:02 | 2024-03-19 21:54:14 | 2024-03-19 21:50:25 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28590', 'html_url': 'https://github.com/facebook/react/pull/28590', 'diff_url': 'https://github.com/facebook/react/pull/28590.diff', 'patch_url': 'https://github.com/facebook/react/pull/28590.patch', 'merged_at': datetime.datetime(2024, 3, 19, 21, 50, 24)} | Also apply content hash for experimental files
In #28582 I missed that experimental files have a copy of this build function setting the version strings.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28590/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28590/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28589 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28589/labels{/name} | https://api.github.com/repos/facebook/react/issues/28589/comments | https://api.github.com/repos/facebook/react/issues/28589/events | https://github.com/facebook/react/issues/28589 | 2,195,194,597 | I_kwDOAJy2Ks6C2ALl | 28,589 | Bug: Flight (RSC) examples are not accessible | {'login': 'kettanaito', 'id': 14984911, 'node_id': 'MDQ6VXNlcjE0OTg0OTEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/14984911?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kettanaito', 'html_url': 'https://github.com/kettanaito', 'followers_url': 'https://api.github.com/users/kettanaito/followers', 'following_url': 'https://api.github.com/users/kettanaito/following{/other_user}', 'gists_url': 'https://api.github.com/users/kettanaito/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kettanaito/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kettanaito/subscriptions', 'organizations_url': 'https://api.github.com/users/kettanaito/orgs', 'repos_url': 'https://api.github.com/users/kettanaito/repos', 'events_url': 'https://api.github.com/users/kettanaito/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kettanaito/received_events', 'type': 'User', 'site_admin': False} | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}] | open | false | null | [] | null | [
"From the examples, I can deduce that different DOM bindings behave differently. I suppose it's tied to their nature, such as compiler-based bindings somehow utilize the compiler to help out. \r\n\r\nIt's interesting, however, that the ESM flight example doesn't need the `react-server` condition. Does it not mean broken RSC? 🤔 How will it handle `\"use client\"`/`\"user server\"` in the components? Is that condition simply an environment guard? \r\n\r\nIf you want to understand the context around my questions, I'd like to build the simplest RSC rendering pipeline possible for testing. This:\r\n\r\n```jsx\r\nconst renderer = new Renderer({\r\n component() {\r\n return <button>Hello</button>\r\n }\r\n})\r\nawait renderer.serve()\r\n```\r\n\r\nI want it to:\r\n\r\n1. Render my component.\r\n2. Spawn the actual HTTP server.\r\n3. Stream its HTML as the initial page HTML from the server.\r\n4. Embed the right `bootstrapModule` that hydrates my component so it becomes interactive.\r\n5. Gives the user control over how to resolve Server Actions as a part of the `Renderer` API (just having the way to know when the actions happen may be enough). "
] | 2024-03-19 14:53:01 | 2024-03-19 18:27:06 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
Thank you for featuring a few `flight` examples on the barebones of RSC! They have been tremendously helpful to me in understanding the model.
That being said, I find myself lost in them. I know it's not an issue per se but I'd be thankful if you consider this feedback and maybe even improve on the examples as the result of it.
## Feedback
My feedback comes down to a few random questions and a few fundamental questions to the RSC model and how to get the right image of it in my head. Please note I'm mainly focusing on understanding the _internals_ of RSC (ala I want to build an RSC rendering/serving pipeline from scratch).
### Random questions
#### 1. **Why do this request forwarding?**
https://github.com/facebook/react/blob/9c75cd5e84c4c524f42e65027cfd3dce746d6916/fixtures/flight-esm/server/global.js#L52-L61
Why not split endpoints and have them clear:
- This returns the initial HTML;
- This returns whichever Server Action data is passed to the server component.
Putting it all in a single request handler makes the example significantly harder to grasp. I get it, these are not educational materials but a bit of documentation and structuring would go a long way.
#### 2. **Why are "global" and "region" server implementations so dramatically different?**
I thought those represented the target of your deployment but they straight changed the approach to rendering completely.
They also run in different contexts:
- "global" runs with the "--condition react-server" condition.
- "region" does not.
I get it, they rely on different packages but I fail to see how those implementations co-exist (_do_ they co-exist? Is it like "deploy region.js when building APP_1, and deploy global.js when building APP_2?). Are those two different ways to implement RSC or one inseparable whole split into two parts?
They have to because some actually render the HTML while others just return serialized components from the endpoints. How am I supposed to combine the two? Run two servers...?
#### 3. How does this code compile?
https://github.com/facebook/react/blob/9c75cd5e84c4c524f42e65027cfd3dce746d6916/fixtures/flight-esm/src/index.js#L4
That package has no source on NPM. There's an issue open about it (#27197). An oversight? Would pretty much like to have an ESM version of the binding because others imply I'm using a compiler (webpack/turbopack), which I'm not.
I think the ESM example is actually the one I'm the most interested in because it doesn't need a compiler.
#### 4. Why does only the "region" server of the ESM example import the action?
https://github.com/facebook/react/blob/9c75cd5e84c4c524f42e65027cfd3dce746d6916/fixtures/flight-esm/server/region.js#L57
Is this logic not applicable to other examples, like when using webpack or turobpack? Do the compilers extract and save the actions in the manifest json? A little bit of documentation on this would be fantastic (I will touch on it at the end).
#### 5. How does this even run?
https://github.com/facebook/react/blob/9c75cd5e84c4c524f42e65027cfd3dce746d6916/fixtures/flight-browser/index.html#L23
The bundle it points to contains `__webpack_require__` expressions, which will fail in the browser:
https://www.unpkg.com/react-server-dom-webpack@18.3.0-canary-a870b2d54-20240314/umd/react-server-dom-webpack-client.browser.development.js
I feel like this index.html is missing some setup around and does not illustrate the example in isolation (relies on webpack anyway?).
#### 6. Why do examples use babel?
I suspect it's to transform JSX to `React.createElement()` calls but I'd love to read a bit more about _when_ that transformation happens. I see some examples use a custom `--loader` for Node.js. Is that related? Do you use that loader to pass imported things through Babel?
This may be the answer to the question I have regarding custom components as those will not render using `react-dom` or any other packages:
```js
import { renderToPipeableStream } from 'react-dom/server'
function Button() {
return <button>Hi</button>
}
renderToPipeableStream(React.createElement(Button.type, Button.props, Button.props.children))
// Error!
```
#### 7. Is there a place for a more developer-friendly API?
Imagine I want to build a tool on top of the RSC protocol. Do you really have to implement those server endpoints by myself? Analyze `text/x-component`, decode the Server Actions? What happens if React changes how those behave? This looks like it would benefit greatly from a higher-level public API.
### Fundamental questions
1. Can we please collaborate and come up with a series of diagrams that explain the underlying implementation of RSC _incrementally_? Things like: okay, there are 2/3/4 parts to an RSC:
- Server part, where you have a `GET /` endpoint that takes a component and pipes its render stream to the response to return the initial, non-interactive HTML from the server.
- Server part, were you also have a `GET /` for some reason but now it uses a different DOM binding that doesn't return an HTML but instead some serialized representation of the component tree (i.e. `0:[$, "<button>", ...]`).
- Server part, where you have a `POST /` endpoint that resolves any Server Actions.
- Some other part, that takes the serialized representation of the component tree, feeds it _another_ DOM binding to then hydrate the Root.
This would be gold. I'm convinced this will be useful to anybody getting to use RSC. Please, let's do this and not be shy on technical details (that's why I mentioned "incrementally" so anyone can drop off at the level they feel comfortable).
I know @kentcdodds is working on the RSC workshop on EpicWeb.dev and I think he'd be over the moon to have a set of such diagrams to show to his students. I know they'd be tremendously helpful to me as I'm trying to wrap my head around testing all this.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28589/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28589/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28588 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28588/labels{/name} | https://api.github.com/repos/facebook/react/issues/28588/comments | https://api.github.com/repos/facebook/react/issues/28588/events | https://github.com/facebook/react/issues/28588 | 2,195,184,350 | I_kwDOAJy2Ks6C19re | 28,588 | Bug: use() hook | {'login': 'w7en', 'id': 8582378, 'node_id': 'MDQ6VXNlcjg1ODIzNzg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8582378?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/w7en', 'html_url': 'https://github.com/w7en', 'followers_url': 'https://api.github.com/users/w7en/followers', 'following_url': 'https://api.github.com/users/w7en/following{/other_user}', 'gists_url': 'https://api.github.com/users/w7en/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/w7en/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/w7en/subscriptions', 'organizations_url': 'https://api.github.com/users/w7en/orgs', 'repos_url': 'https://api.github.com/users/w7en/repos', 'events_url': 'https://api.github.com/users/w7en/events{/privacy}', 'received_events_url': 'https://api.github.com/users/w7en/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"It's not because of Suspense or a bug, but the use() hook isn't cached by default, so you will see a lot of api calls when using it. \r\n\r\nI would prefer you to go with a library like react-query to handle data fetching in React rather than using 'use' for that.",
"See here: [https://react.dev/reference/react/use](https://react.dev/reference/react/use)",
"As @albeniskerqeli10 said, the promise needs to be cached. The docs don't mention that unfortunately yet which we need to fix.",
"Thank so much. I got it"
] | 2024-03-19 14:48:48 | 2024-05-01 20:18:45 | 2024-05-01 20:18:45 | NONE | null | null | null | React version:
"react": "0.0.0-experimental-4b84f1161-20240318",
"react-dom": "0.0.0-experimental-4b84f1161-20240318",
1. How I can use the use() hook without Suspense component?
2. When I use the use() hook with Suspense and call API, I see it still calls the API many times (this version: 3 times, version: 0.0.0-experimental-a870b2d54-20240314 => 4 times).
Link code example: https://github.com/bradtraversy/react-19-playground/blob/main/src/components/useExample1/Joke.jsx | {'url': 'https://api.github.com/repos/facebook/react/issues/28588/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28588/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28587 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28587/labels{/name} | https://api.github.com/repos/facebook/react/issues/28587/comments | https://api.github.com/repos/facebook/react/issues/28587/events | https://github.com/facebook/react/pull/28587 | 2,194,745,336 | PR_kwDOAJy2Ks5qE8-O | 28,587 | Repro for mismatch of changed hook and used hook | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [] | 2024-03-19 11:45:52 | 2024-03-19 11:49:29 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28587', 'html_url': 'https://github.com/facebook/react/pull/28587', 'diff_url': 'https://github.com/facebook/react/pull/28587.diff', 'patch_url': 'https://github.com/facebook/react/pull/28587.patch', 'merged_at': None} | Test reproducing https://github.com/facebook/react/issues/28584. This is not minimal since I haven't started removing wrappers until it no longer reproduces. But this should be a good starting point if somebody wants to pick this up.
## Test plan
- `yarn test --build --project=devtools -r=experimental profilingCache-test --testNamePattern "should properly detect changed hooks #2"` | {'url': 'https://api.github.com/repos/facebook/react/issues/28587/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28587/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28586 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28586/labels{/name} | https://api.github.com/repos/facebook/react/issues/28586/comments | https://api.github.com/repos/facebook/react/issues/28586/events | https://github.com/facebook/react/issues/28586 | 2,194,598,552 | I_kwDOAJy2Ks6CzuqY | 28,586 | about the react performance (how to improve it) | {'login': 'ahmedmbarektorjmen', 'id': 100807174, 'node_id': 'U_kgDOBgIyBg', 'avatar_url': 'https://avatars.githubusercontent.com/u/100807174?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ahmedmbarektorjmen', 'html_url': 'https://github.com/ahmedmbarektorjmen', 'followers_url': 'https://api.github.com/users/ahmedmbarektorjmen/followers', 'following_url': 'https://api.github.com/users/ahmedmbarektorjmen/following{/other_user}', 'gists_url': 'https://api.github.com/users/ahmedmbarektorjmen/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ahmedmbarektorjmen/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ahmedmbarektorjmen/subscriptions', 'organizations_url': 'https://api.github.com/users/ahmedmbarektorjmen/orgs', 'repos_url': 'https://api.github.com/users/ahmedmbarektorjmen/repos', 'events_url': 'https://api.github.com/users/ahmedmbarektorjmen/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ahmedmbarektorjmen/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"@ahmedmbarektorjmen you already opened this issue in #28481.",
"Closing as dupe https://github.com/facebook/react/issues/28481.",
"> @ahmedmbarektorjmen you already opened this issue in #28481.\r\n\r\nbecause no one answered me i reposted it"
] | 2024-03-19 10:36:26 | 2024-04-03 22:18:24 | 2024-03-24 00:53:25 | NONE | null | null | null | As a React developer, an idea struck me while I was walking: why not introduce a `useSignal` hook? Additionally, addressing the performance concerns, could we eliminate the need for rerendering the entire DOM and address React's perceived slowness, which is often attributed to JavaScript hydration and the size of `react-dom`?
To optimize React further, consider adding the `useSignal` hook to facilitate more efficient state management. Furthermore, revisiting the structure of `react-dom`, which currently includes substantial JavaScript, could lead to performance enhancements.
with `react-dom` in the app.js when bundled its about 72 kb !!
Another suggestion is the introduction of `useStore`, offering a lightweight alternative to using context, Redux, or Jotai for state management.
Enhancing HTML generation through the new React compiler like Qwik does could streamline the development process.
Removing hydration in favor of quick resumability and server-side rendering, similar to Qwik's approach, could improve React's performance and reduce the reliance on client-side components.
By transitioning to server components with server-side rendering (on load) and interactive elements could execute on the client side sith the need for a client componnent.
and if you wonder how to execute a client code so let me introduce you to the new `useClient()` hook.
This approach would minimize initial JavaScript downloads, fetching only the necessary chunks upon user interaction, similar to Qwik's methodology.
Considering these advancements could position React as the leading framework due to its intuitive syntax, leveraging its existing popularity and reputation. Your feedback on these proposals is crucial for shaping the future of React within the development community. | {'url': 'https://api.github.com/repos/facebook/react/issues/28586/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 2, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28586/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28585 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28585/labels{/name} | https://api.github.com/repos/facebook/react/issues/28585/comments | https://api.github.com/repos/facebook/react/issues/28585/events | https://github.com/facebook/react/pull/28585 | 2,193,791,270 | PR_kwDOAJy2Ks5qBwR0 | 28,585 | (cherrypick b09e102f) [Fizz] Prevent uncloned large precomputed chunks without relying on render-time assertions #28580 | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_url': 'https://api.github.com/users/gnoff/following{/other_user}', 'gists_url': 'https://api.github.com/users/gnoff/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gnoff/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gnoff/subscriptions', 'organizations_url': 'https://api.github.com/users/gnoff/orgs', 'repos_url': 'https://api.github.com/users/gnoff/repos', 'events_url': 'https://api.github.com/users/gnoff/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gnoff/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 60a927d04ad3888facebcdf7da620aa1cfc9528f...0a8846d12215c0da24801691f353d12dd3d6c38f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 176.19 kB | 176.19 kB | = | 54.88 kB | 54.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 178.29 kB | 178.29 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/facebook-www/ReactDOM-prod.classic.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 571.89 kB | 571.89 kB | = | 100.56 kB | 100.56 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/facebook-www/ReactDOM-prod.modern.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 555.65 kB | 555.65 kB | = | 97.63 kB | 97.63 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.23 kB | 2.18 kB | = | 0.89 kB | 0.88 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.23 kB | 2.18 kB | = | 0.89 kB | 0.88 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.23 kB | 2.18 kB | = | 0.89 kB | 0.88 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.47 kB | 2.40 kB | = | 0.94 kB | 0.93 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.47 kB | 2.40 kB | = | 0.94 kB | 0.93 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.47 kB | 2.40 kB | = | 0.94 kB | 0.93 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 1.36 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 1.36 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 1.36 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/__test_utils__/ReactAllWarnings.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **Deleted** | 67.55 kB | 0.00 kB | Deleted | 16.54 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 124.67 kB | 124.19 kB | = | 28.48 kB | 28.35 kB\n| [oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 121.95 kB | 121.47 kB | = | 27.75 kB | 27.62 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 118.88 kB | 118.41 kB | = | 28.38 kB | 28.26 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 118.02 kB | 117.56 kB | = | 28.07 kB | 27.94 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 123.84 kB | 123.35 kB | = | 29.29 kB | 29.15 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 116.82 kB | 116.35 kB | = | 27.81 kB | 27.68 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 121.42 kB | 120.93 kB | = | 28.61 kB | 28.47 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 115.44 kB | 114.97 kB | = | 27.34 kB | 27.22 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 121.20 kB | 120.71 kB | = | 28.40 kB | 28.26 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 118.78 kB | 118.29 kB | = | 27.76 kB | 27.62 kB\n| [oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 110.57 kB | 110.09 kB | = | 25.52 kB | 25.38 kB\n| [oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 110.57 kB | 110.09 kB | = | 25.52 kB | 25.38 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 113.37 kB | 112.87 kB | = | 26.55 kB | 26.40 kB\n| [oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 107.85 kB | 107.37 kB | = | 24.78 kB | 24.64 kB\n| [oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 107.85 kB | 107.37 kB | = | 24.78 kB | 24.64 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 110.23 kB | 109.74 kB | = | 26.32 kB | 26.18 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 110.23 kB | 109.74 kB | = | 26.32 kB | 26.18 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 104.80 kB | 104.34 kB | = | 25.20 kB | 25.07 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 104.80 kB | 104.34 kB | = | 25.20 kB | 25.07 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 104.62 kB | 104.15 kB | = | 25.17 kB | 25.03 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 104.62 kB | 104.15 kB | = | 25.17 kB | 25.03 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 102.74 kB | 102.27 kB | = | 24.65 kB | 24.51 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 102.74 kB | 102.27 kB | = | 24.65 kB | 24.51 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 107.82 kB | 107.32 kB | = | 25.66 kB | 25.51 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 107.82 kB | 107.32 kB | = | 25.66 kB | 25.51 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 107.60 kB | 107.11 kB | = | 25.44 kB | 25.30 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 107.60 kB | 107.11 kB | = | 25.44 kB | 25.30 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 102.04 kB | 101.57 kB | = | 24.44 kB | 24.31 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 102.04 kB | 101.57 kB | = | 24.44 kB | 24.31 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 105.17 kB | 104.68 kB | = | 24.81 kB | 24.67 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 105.17 kB | 104.68 kB | = | 24.81 kB | 24.67 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 99.76 kB | 99.27 kB | = | 23.60 kB | 23.46 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 99.76 kB | 99.27 kB | = | 23.60 kB | 23.46 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.23 kB | 2.18 kB | = | 0.89 kB | 0.88 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.23 kB | 2.18 kB | = | 0.89 kB | 0.88 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.23 kB | 2.18 kB | = | 0.89 kB | 0.88 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.47 kB | 2.40 kB | = | 0.94 kB | 0.93 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.47 kB | 2.40 kB | = | 0.94 kB | 0.93 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 2.47 kB | 2.40 kB | = | 0.94 kB | 0.93 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 1.36 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 1.36 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **=** | 1.36 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/0a8846d12215c0da24801691f353d12dd3d6c38f/files/__test_utils__/ReactAllWarnings.js?compare=60a927d04ad3888facebcdf7da620aa1cfc9528f) | **Deleted** | 67.55 kB | 0.00 kB | Deleted | 16.54 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0a8846d12215c0da24801691f353d12dd3d6c38f\n</p>\n"
] | 2024-03-19 01:00:59 | 2024-03-19 01:05:07 | 2024-03-19 01:01:27 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28585', 'html_url': 'https://github.com/facebook/react/pull/28585', 'diff_url': 'https://github.com/facebook/react/pull/28585.diff', 'patch_url': 'https://github.com/facebook/react/pull/28585.patch', 'merged_at': datetime.datetime(2024, 3, 19, 1, 1, 27)} | (cherrypick b09e102f on 60a927d04)
[Fizz] Prevent uncloned large precomputed chunks without relying on render-time assertions (#28568)
A while back we implemented a heuristic that if a chunk was large it was assumed to be produced by the render and thus was safe to stream which results in transferring the underlying object memory. Later we ran into an issue where a precomputed chunk grew large enough to trigger this hueristic and it started causing renders to fail because once a second render had occurred the precomputed chunk would not have an underlying buffer of bytes to send and these bytes would be omitted from the stream. We implemented a technique to detect large precomputed chunks and we enforced that these always be cloned before writing. Unfortunately our test coverage was not perfect and there has been for a very long time now a usage pattern where if you complete a boundary in one flush and then complete a boundary that has stylehsheet dependencies in another flush you can get a large precomputed chunk that was not being cloned to be sent twice causing streaming errors.
I've thought about why we even went with this solution in the first place and I think it was a mistake. It relies on a dev only check to catch paired with potentially version specific order of operations on the streaming side. This is too unreliable. Additionally the low limit of view size for Edge is not used in Node.js but there is not real justification for this.
In this change I updated the view size for edge streaming to match Node at 2048 bytes which is still relatively small and we have no data one way or another to preference 512 over this. Then I updated the assertion logic to error anytime a precomputed chunk exceeds the size. This eliminates the need to clone these chunks by just making sure our view size is always larger than the largest precomputed chunk we can possibly write. I'm generally in favor of this for a few reasons.
First, we'll always know during testing whether we've violated the limit as long as we exercise each stream config because the precomputed chunks are created in module scope. Second, we can always split up large chunks so making sure the precomptued chunk is smaller than whatever view size we actually desire is relatively trivial. | {'url': 'https://api.github.com/repos/facebook/react/issues/28585/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28585/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28584 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28584/labels{/name} | https://api.github.com/repos/facebook/react/issues/28584/comments | https://api.github.com/repos/facebook/react/issues/28584/events | https://github.com/facebook/react/issues/28584 | 2,193,765,750 | I_kwDOAJy2Ks6CwjV2 | 28,584 | [DevTools Bug]: React Profiler reports higher hook numbers than shown in Components | {'login': 'iamakulov', 'id': 2953267, 'node_id': 'MDQ6VXNlcjI5NTMyNjc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2953267?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/iamakulov', 'html_url': 'https://github.com/iamakulov', 'followers_url': 'https://api.github.com/users/iamakulov/followers', 'following_url': 'https://api.github.com/users/iamakulov/following{/other_user}', 'gists_url': 'https://api.github.com/users/iamakulov/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/iamakulov/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/iamakulov/subscriptions', 'organizations_url': 'https://api.github.com/users/iamakulov/orgs', 'repos_url': 'https://api.github.com/users/iamakulov/repos', 'events_url': 'https://api.github.com/users/iamakulov/events{/privacy}', 'received_events_url': 'https://api.github.com/users/iamakulov/received_events', 'type': 'User', 'site_admin': False} | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | open | false | null | [] | null | [
"Thank you for the detailed repro instructions. I can also reproduce this as instructed.\r\n\r\nI have a test reproducing the issue in https://github.com/facebook/react/pull/28587 that basically just inline all 3rd party dependencies. I haven't started further reducing the repro until it no longer reproduces but this should be a good starting point if somebody wants to dig into this.",
"Same issue. Any thoughts on this?"
] | 2024-03-19 00:40:07 | 2024-03-27 10:32:08 | null | NONE | null | null | null | ### Website or app
https://github.com/3perf/react-workshop-fwdays-mar24
### Repro steps
- Clone the https://github.com/3perf/react-workshop-fwdays-mar24 repository
- Switch to the branch called `day5`
- `cd widgets-editor && yarn && yarn start`
- An app will open. Reproduce the following interaction & record a Profiler trace:
https://github.com/facebook/react/assets/2953267/fe0eb272-d136-44a6-bfe0-4f1b20ff27de
- Find the first render of the `ResizableComponent` component in the trace
- Observe React Profiler reporting “hook 32 changed” whereas the Components pane reporting only 30 hooks in the component (as in the video)
Sorry for not having a minimal repro! I was only able to reproduce this in big apps like the one attached. However, it reproduces reliably.
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_
### Error message (automated)
_No response_
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_ | {'url': 'https://api.github.com/repos/facebook/react/issues/28584/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28584/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28583 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28583/labels{/name} | https://api.github.com/repos/facebook/react/issues/28583/comments | https://api.github.com/repos/facebook/react/issues/28583/events | https://github.com/facebook/react/pull/28583 | 2,193,753,769 | PR_kwDOAJy2Ks5qBn70 | 28,583 | Better NEXT_MAJOR support for RN flags | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlonii/followers', 'following_url': 'https://api.github.com/users/rickhanlonii/following{/other_user}', 'gists_url': 'https://api.github.com/users/rickhanlonii/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rickhanlonii/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rickhanlonii/subscriptions', 'organizations_url': 'https://api.github.com/users/rickhanlonii/orgs', 'repos_url': 'https://api.github.com/users/rickhanlonii/repos', 'events_url': 'https://api.github.com/users/rickhanlonii/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rickhanlonii/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fa0efa1ae3b83e573e21dfd6d0620039fa7fedd3...7813b3252481631c6061d5d46ea70dc1eeb8aa93\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/7813b3252481631c6061d5d46ea70dc1eeb8aa93/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=fa0efa1ae3b83e573e21dfd6d0620039fa7fedd3) | **=** | 176.84 kB | 176.84 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/7813b3252481631c6061d5d46ea70dc1eeb8aa93/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=fa0efa1ae3b83e573e21dfd6d0620039fa7fedd3) | **=** | 173.27 kB | 173.27 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/7813b3252481631c6061d5d46ea70dc1eeb8aa93/files/facebook-www/ReactDOM-prod.classic.js?compare=fa0efa1ae3b83e573e21dfd6d0620039fa7fedd3) | **=** | 594.30 kB | 594.30 kB | = | 104.45 kB | 104.45 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/7813b3252481631c6061d5d46ea70dc1eeb8aa93/files/facebook-www/ReactDOM-prod.modern.js?compare=fa0efa1ae3b83e573e21dfd6d0620039fa7fedd3) | **=** | 577.56 kB | 577.56 kB | = | 101.48 kB | 101.48 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/7813b3252481631c6061d5d46ea70dc1eeb8aa93/files/__test_utils__/ReactAllWarnings.js?compare=fa0efa1ae3b83e573e21dfd6d0620039fa7fedd3) | **Deleted** | 65.49 kB | 0.00 kB | Deleted | 16.16 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/7813b3252481631c6061d5d46ea70dc1eeb8aa93/files/__test_utils__/ReactAllWarnings.js?compare=fa0efa1ae3b83e573e21dfd6d0620039fa7fedd3) | **Deleted** | 65.49 kB | 0.00 kB | Deleted | 16.16 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 7813b3252481631c6061d5d46ea70dc1eeb8aa93\n</p>\n"
] | 2024-03-19 00:31:06 | 2024-03-25 11:36:07 | 2024-03-22 17:02:04 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28583', 'html_url': 'https://github.com/facebook/react/pull/28583', 'diff_url': 'https://github.com/facebook/react/pull/28583.diff', 'patch_url': 'https://github.com/facebook/react/pull/28583.patch', 'merged_at': datetime.datetime(2024, 3, 22, 17, 2, 4)} | The `__NEXT_MAJOR__` value in the RN flags doesn't make sense because:
a) The flags are for the next RN major, since it only impacts the renderers
b) The flags are off, so they're not currently in the next major, they need enabled
c) the flag script didn't support it
This PR adds two aliases to the RN file:
- `__TODO_NEXT_RN_MAJOR__`: flags that need enabled before the next RN major.
- `__NEXT_RN_MAJOR__`: flags that have been enabled since the last RN major.
These values will need to be manually kept up to date when we cut a RN version, but once RN switches to the canary build and aligns all the flags, this entire file can be deleted.
## Script screen
Notably, I added a TODO value and a legend that prints at the end of the script:
<img width="1078" alt="Screenshot 2024-03-18 at 8 11 27 PM" src="https://github.com/facebook/react/assets/2440089/14da9066-f77d-437f-8188-830a31a843c5">
| {'url': 'https://api.github.com/repos/facebook/react/issues/28583/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28583/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28582 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28582/labels{/name} | https://api.github.com/repos/facebook/react/issues/28582/comments | https://api.github.com/repos/facebook/react/issues/28582/events | https://github.com/facebook/react/pull/28582 | 2,193,686,002 | PR_kwDOAJy2Ks5qBYvc | 28,582 | Change to content hash for RN canary VERSION strings | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c75cd5e84c4c524f42e65027cfd3dce746d6916...175a0790ee98eb3b99c3ece03625631c61e02f25\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/175a0790ee98eb3b99c3ece03625631c61e02f25/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/175a0790ee98eb3b99c3ece03625631c61e02f25/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **=** | 173.26 kB | 173.26 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/175a0790ee98eb3b99c3ece03625631c61e02f25/files/facebook-www/ReactDOM-prod.classic.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **=** | 594.27 kB | 594.27 kB | = | 104.44 kB | 104.44 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/175a0790ee98eb3b99c3ece03625631c61e02f25/files/facebook-www/ReactDOM-prod.modern.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **=** | 577.53 kB | 577.53 kB | = | 101.47 kB | 101.47 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/175a0790ee98eb3b99c3ece03625631c61e02f25/files/__test_utils__/ReactAllWarnings.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/175a0790ee98eb3b99c3ece03625631c61e02f25/files/__test_utils__/ReactAllWarnings.js?compare=9c75cd5e84c4c524f42e65027cfd3dce746d6916) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 175a0790ee98eb3b99c3ece03625631c61e02f25\n</p>\n",
"This seems fine if it's only updating files that are synced to Meta, rather than files used in OSS. Hard to tell from the code if that's strictly the case.",
"LGTM, let's just follow up to confirm it doesn't impact the OSS files\r\n"
] | 2024-03-18 23:45:46 | 2024-03-19 20:16:54 | 2024-03-19 20:16:34 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28582', 'html_url': 'https://github.com/facebook/react/pull/28582', 'diff_url': 'https://github.com/facebook/react/pull/28582.diff', 'patch_url': 'https://github.com/facebook/react/pull/28582.patch', 'merged_at': datetime.datetime(2024, 3, 19, 20, 16, 34)} | With this change, the different files in RN will have *different* hashes. This replaces the git hash and means that the file content (including version) is only updated when the rest of the file content actually changes. This should remove "noop" changes that need to be synced that only update the version string.
A difference to the www implementation here is (and I'd be looking at updating www as well if this lands well) that each file has an individual hash instead of a combined content hash. This further reduces the number of updated files and I couldn't find a reason we need to have these in sync. The best I can gather is that this hash is used so folks don't directly compare version string and make future updates harder. | {'url': 'https://api.github.com/repos/facebook/react/issues/28582/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28582/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28581 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28581/labels{/name} | https://api.github.com/repos/facebook/react/issues/28581/comments | https://api.github.com/repos/facebook/react/issues/28581/events | https://github.com/facebook/react/pull/28581 | 2,193,405,341 | PR_kwDOAJy2Ks5qAYFM | 28,581 | Set disableModulePatternComponents flag to __NEXT_MAJOR__ for RN OSS | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a4939017ffe2e04a94efca0f48b661bc778a6fa4...d3bf58a9d7f284b11635cb95a8f8b49cb8833916\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d3bf58a9d7f284b11635cb95a8f8b49cb8833916/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 176.84 kB | 176.84 kB | = | 54.92 kB | 54.92 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d3bf58a9d7f284b11635cb95a8f8b49cb8833916/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 173.27 kB | 173.27 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/d3bf58a9d7f284b11635cb95a8f8b49cb8833916/files/facebook-www/ReactDOM-prod.classic.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 594.30 kB | 594.30 kB | = | 104.45 kB | 104.45 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/d3bf58a9d7f284b11635cb95a8f8b49cb8833916/files/facebook-www/ReactDOM-prod.modern.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **=** | 577.56 kB | 577.56 kB | = | 101.48 kB | 101.48 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d3bf58a9d7f284b11635cb95a8f8b49cb8833916/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d3bf58a9d7f284b11635cb95a8f8b49cb8833916/files/__test_utils__/ReactAllWarnings.js?compare=a4939017ffe2e04a94efca0f48b661bc778a6fa4) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against d3bf58a9d7f284b11635cb95a8f8b49cb8833916\n</p>\n",
"Already fixed in fabd6d3a64aa20aca940142a29a14a82d1cefd31"
] | 2024-03-18 21:44:20 | 2024-03-25 17:57:10 | 2024-03-25 17:29:19 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28581', 'html_url': 'https://github.com/facebook/react/pull/28581', 'diff_url': 'https://github.com/facebook/react/pull/28581.diff', 'patch_url': 'https://github.com/facebook/react/pull/28581.patch', 'merged_at': None} | Set disableModulePatternComponents flag to __NEXT_MAJOR__ for RN OSS
I missed this in #28579, for the next major of RN OSS we should also
enable this flag.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28581/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28581/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28580 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28580/labels{/name} | https://api.github.com/repos/facebook/react/issues/28580/comments | https://api.github.com/repos/facebook/react/issues/28580/events | https://github.com/facebook/react/pull/28580 | 2,193,367,325 | PR_kwDOAJy2Ks5qAPZn | 28,580 | (cherrypick b09e102f) [Fizz] Prevent uncloned large precomputed chunks without relying on render-time assertions | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_url': 'https://api.github.com/users/gnoff/following{/other_user}', 'gists_url': 'https://api.github.com/users/gnoff/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gnoff/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gnoff/subscriptions', 'organizations_url': 'https://api.github.com/users/gnoff/orgs', 'repos_url': 'https://api.github.com/users/gnoff/repos', 'events_url': 'https://api.github.com/users/gnoff/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gnoff/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6c3b8dbfed6f879440f484bd0bf801fac67ec684...72e7c9059afc220257ed2363fcfa5dfd8029406d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 176.86 kB | 176.86 kB | = | 55.13 kB | 55.13 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 179.01 kB | 179.01 kB | = | 55.77 kB | 55.77 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/facebook-www/ReactDOM-prod.classic.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 592.52 kB | 592.52 kB | = | 104.72 kB | 104.72 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/facebook-www/ReactDOM-prod.modern.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 576.30 kB | 576.30 kB | = | 101.80 kB | 101.80 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.28 kB | 2.23 kB | = | 0.90 kB | 0.89 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.28 kB | 2.23 kB | = | 0.90 kB | 0.89 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.28 kB | 2.23 kB | = | 0.90 kB | 0.89 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.52 kB | 2.45 kB | = | 0.95 kB | 0.94 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.52 kB | 2.45 kB | = | 0.95 kB | 0.94 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.52 kB | 2.45 kB | = | 0.95 kB | 0.94 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 1.39 kB | 1.34 kB | = | 0.64 kB | 0.64 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 1.39 kB | 1.34 kB | = | 0.64 kB | 0.64 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 1.39 kB | 1.34 kB | = | 0.64 kB | 0.64 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/__test_utils__/ReactAllWarnings.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **Deleted** | 66.35 kB | 0.00 kB | Deleted | 16.24 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 140.08 kB | 139.60 kB | = | 31.18 kB | 31.04 kB\n| [oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 137.51 kB | 137.03 kB | = | 30.48 kB | 30.34 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 133.92 kB | 133.46 kB | = | 31.07 kB | 30.93 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 132.87 kB | 132.41 kB | = | 30.72 kB | 30.58 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 138.83 kB | 138.34 kB | = | 32.02 kB | 31.87 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 131.99 kB | 131.53 kB | = | 30.56 kB | 30.42 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 130.43 kB | 129.96 kB | = | 30.01 kB | 29.87 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 136.54 kB | 136.05 kB | = | 31.39 kB | 31.24 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 136.19 kB | 135.70 kB | = | 31.17 kB | 31.02 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 133.90 kB | 133.41 kB | = | 30.59 kB | 30.43 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 127.75 kB | 127.25 kB | = | 29.14 kB | 28.98 kB\n| [oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 117.69 kB | 117.21 kB | = | 26.91 kB | 26.76 kB\n| [oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 117.69 kB | 117.21 kB | = | 26.91 kB | 26.76 kB\n| [oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 115.12 kB | 114.64 kB | = | 26.23 kB | 26.08 kB\n| [oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 115.12 kB | 114.64 kB | = | 26.23 kB | 26.08 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 111.87 kB | 111.40 kB | = | 26.66 kB | 26.51 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 111.87 kB | 111.40 kB | = | 26.66 kB | 26.51 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 117.24 kB | 116.75 kB | = | 27.76 kB | 27.61 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 117.24 kB | 116.75 kB | = | 27.76 kB | 27.61 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 111.49 kB | 111.03 kB | = | 26.59 kB | 26.44 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 111.49 kB | 111.03 kB | = | 26.59 kB | 26.44 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 109.94 kB | 109.47 kB | = | 26.15 kB | 26.01 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 109.94 kB | 109.47 kB | = | 26.15 kB | 26.01 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 114.96 kB | 114.47 kB | = | 27.15 kB | 26.99 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 114.96 kB | 114.47 kB | = | 27.15 kB | 26.99 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 109.05 kB | 108.58 kB | = | 25.92 kB | 25.77 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 109.05 kB | 108.58 kB | = | 25.92 kB | 25.77 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 114.61 kB | 114.12 kB | = | 26.87 kB | 26.72 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 114.61 kB | 114.12 kB | = | 26.87 kB | 26.72 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 112.32 kB | 111.83 kB | = | 26.31 kB | 26.16 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 112.32 kB | 111.83 kB | = | 26.31 kB | 26.16 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 106.16 kB | 105.67 kB | = | 24.94 kB | 24.77 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 106.16 kB | 105.67 kB | = | 24.94 kB | 24.77 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.28 kB | 2.23 kB | = | 0.90 kB | 0.89 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.28 kB | 2.23 kB | = | 0.90 kB | 0.89 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.28 kB | 2.23 kB | = | 0.90 kB | 0.89 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.52 kB | 2.45 kB | = | 0.95 kB | 0.94 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.52 kB | 2.45 kB | = | 0.95 kB | 0.94 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 2.52 kB | 2.45 kB | = | 0.95 kB | 0.94 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 1.39 kB | 1.34 kB | = | 0.64 kB | 0.64 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 1.39 kB | 1.34 kB | = | 0.64 kB | 0.64 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **=** | 1.39 kB | 1.34 kB | = | 0.64 kB | 0.64 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/72e7c9059afc220257ed2363fcfa5dfd8029406d/files/__test_utils__/ReactAllWarnings.js?compare=6c3b8dbfed6f879440f484bd0bf801fac67ec684) | **Deleted** | 66.35 kB | 0.00 kB | Deleted | 16.24 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 72e7c9059afc220257ed2363fcfa5dfd8029406d\n</p>\n"
] | 2024-03-18 21:29:22 | 2024-03-18 21:34:09 | 2024-03-18 21:30:31 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28580', 'html_url': 'https://github.com/facebook/react/pull/28580', 'diff_url': 'https://github.com/facebook/react/pull/28580.diff', 'patch_url': 'https://github.com/facebook/react/pull/28580.patch', 'merged_at': datetime.datetime(2024, 3, 18, 21, 30, 31)} | (cherrypick b09e102f #28568)
[Fizz] Prevent uncloned large precomputed chunks without relying on render-time assertions (#28568)
A while back we implemented a heuristic that if a chunk was large it was assumed to be produced by the render and thus was safe to stream which results in transferring the underlying object memory. Later we ran into an issue where a precomputed chunk grew large enough to trigger this hueristic and it started causing renders to fail because once a second render had occurred the precomputed chunk would not have an underlying buffer of bytes to send and these bytes would be omitted from the stream. We implemented a technique to detect large precomputed chunks and we enforced that these always be cloned before writing. Unfortunately our test coverage was not perfect and there has been for a very long time now a usage pattern where if you complete a boundary in one flush and then complete a boundary that has stylehsheet dependencies in another flush you can get a large precomputed chunk that was not being cloned to be sent twice causing streaming errors.
I've thought about why we even went with this solution in the first place and I think it was a mistake. It relies on a dev only check to catch paired with potentially version specific order of operations on the streaming side. This is too unreliable. Additionally the low limit of view size for Edge is not used in Node.js but there is not real justification for this.
In this change I updated the view size for edge streaming to match Node at 2048 bytes which is still relatively small and we have no data one way or another to preference 512 over this. Then I updated the assertion logic to error anytime a precomputed chunk exceeds the size. This eliminates the need to clone these chunks by just making sure our view size is always larger than the largest precomputed chunk we can possibly write. I'm generally in favor of this for a few reasons.
First, we'll always know during testing whether we've violated the limit as long as we exercise each stream config because the precomputed chunks are created in module scope. Second, we can always split up large chunks so making sure the precomptued chunk is smaller than whatever view size we actually desire is relatively trivial.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28580/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28580/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28579 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28579/labels{/name} | https://api.github.com/repos/facebook/react/issues/28579/comments | https://api.github.com/repos/facebook/react/issues/28579/events | https://github.com/facebook/react/pull/28579 | 2,193,010,845 | PR_kwDOAJy2Ks5p-_o4 | 28,579 | Set disableModulePatternComponents flag to __NEXT_MAJOR__ | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0aab065eb3250a9714a62dc05587cbb571da7f71...38977314a168902999a2cdf7c410c2a12e1e7b43\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.90 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 173.55 kB | 173.26 kB | = | 54.11 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/facebook-www/ReactDOM-prod.classic.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 594.27 kB | 594.27 kB | = | 104.44 kB | 104.44 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/facebook-www/ReactDOM-prod.modern.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 577.53 kB | 577.53 kB | = | 101.47 kB | 101.47 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/__test_utils__/ReactAllWarnings.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-reconciler/cjs/react-reconciler.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-reconciler/cjs/react-reconciler.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 928.75 kB | 926.86 kB | = | 197.75 kB | 197.50 kB\n| [oss-experimental/react-art/umd/react-art.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-art/umd/react-art.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 941.13 kB | 939.18 kB | = | 197.32 kB | 197.09 kB\n| [oss-experimental/react-art/umd/react-art.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-art/umd/react-art.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 135.33 kB | 135.04 kB | = | 42.24 kB | 42.16 kB\n| [oss-experimental/react-server/cjs/react-server.production.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-server/cjs/react-server.production.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 166.53 kB | 166.16 kB | = | 38.51 kB | 38.41 kB\n| [oss-experimental/react-dom/cjs/react-dom-server.edge.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server.edge.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 93.22 kB | 93.01 kB | = | 28.53 kB | 28.46 kB\n| [oss-experimental/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-art/cjs/react-art.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 825.28 kB | 823.39 kB | = | 178.04 kB | 177.80 kB\n| [oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 123.28 kB | 122.99 kB | = | 37.75 kB | 37.66 kB\n| [oss-experimental/react-dom/cjs/react-dom-server.node.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server.node.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 91.44 kB | 91.23 kB | = | 27.70 kB | 27.64 kB\n| [oss-experimental/react-test-renderer/umd/react-test-renderer.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-test-renderer/umd/react-test-renderer.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 840.12 kB | 838.17 kB | = | 176.32 kB | 176.10 kB\n| [oss-experimental/react-dom/umd/react-dom-server.browser.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/umd/react-dom-server.browser.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 467.39 kB | 466.31 kB | = | 99.89 kB | 99.77 kB\n| [oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 802.16 kB | 800.27 kB | = | 174.32 kB | 174.03 kB\n| [oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 458.58 kB | 457.50 kB | = | 98.82 kB | 98.72 kB\n| [oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 89.31 kB | 89.10 kB | = | 27.20 kB | 27.18 kB\n| [oss-experimental/react-dom/cjs/react-dom-server.edge.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server.edge.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 447.12 kB | 446.06 kB | = | 99.05 kB | 98.93 kB\n| [oss-experimental/react-dom/cjs/react-dom-server.browser.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server.browser.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 446.54 kB | 445.48 kB | = | 98.92 kB | 98.80 kB\n| [oss-experimental/react-dom/cjs/react-dom-server.node.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server.node.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 444.91 kB | 443.85 kB | = | 98.11 kB | 98.00 kB\n| [oss-experimental/react-dom/cjs/react-dom-server.browser.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server.browser.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 87.85 kB | 87.64 kB | = | 26.81 kB | 26.76 kB\n| [oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 439.97 kB | 438.91 kB | = | 98.32 kB | 98.19 kB\n| [oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 438.12 kB | 437.06 kB | = | 97.85 kB | 97.73 kB\n| [oss-experimental/react-dom/cjs/react-dom-server.bun.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server.bun.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 86.30 kB | 86.09 kB | = | 26.09 kB | 26.04 kB\n| [oss-experimental/react-dom/cjs/react-dom-server.bun.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server.bun.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 431.81 kB | 430.76 kB | = | 95.96 kB | 95.83 kB\n| [oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 114.24 kB | 113.95 kB | = | 35.40 kB | 35.33 kB\n| [oss-experimental/react-dom/umd/react-dom-server.browser.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/umd/react-dom-server.browser.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 87.92 kB | 87.70 kB | = | 27.18 kB | 27.13 kB\n| [oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 83.41 kB | 83.20 kB | = | 25.29 kB | 25.23 kB\n| [oss-experimental/react-dom/umd/react-dom-server-legacy.browser.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-dom/umd/react-dom-server-legacy.browser.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 83.49 kB | 83.28 kB | = | 25.69 kB | 25.64 kB\n| [oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 105.15 kB | 104.86 kB | = | 32.56 kB | 32.50 kB\n| [oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 104.86 kB | 104.57 kB | = | 32.21 kB | 32.15 kB\n| [oss-experimental/react-art/cjs/react-art.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-art/cjs/react-art.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 98.12 kB | 97.84 kB | = | 30.18 kB | 30.12 kB\n| [oss-experimental/react-server/cjs/react-server.development.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-server/cjs/react-server.development.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 210.98 kB | 209.92 kB | = | 48.90 kB | 48.78 kB\n| [oss-experimental/react-server/cjs/react-server.production.min.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/oss-experimental/react-server/cjs/react-server.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 40.94 kB | 40.73 kB | = | 12.86 kB | 12.83 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/38977314a168902999a2cdf7c410c2a12e1e7b43/files/__test_utils__/ReactAllWarnings.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 38977314a168902999a2cdf7c410c2a12e1e7b43\n</p>\n"
] | 2024-03-18 18:51:24 | 2024-03-25 17:57:20 | 2024-03-18 21:25:29 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28579', 'html_url': 'https://github.com/facebook/react/pull/28579', 'diff_url': 'https://github.com/facebook/react/pull/28579.diff', 'patch_url': 'https://github.com/facebook/react/pull/28579.patch', 'merged_at': datetime.datetime(2024, 3, 18, 21, 25, 29)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/28579/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28579/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28578 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28578/labels{/name} | https://api.github.com/repos/facebook/react/issues/28578/comments | https://api.github.com/repos/facebook/react/issues/28578/events | https://github.com/facebook/react/pull/28578 | 2,192,636,077 | PR_kwDOAJy2Ks5p9s1z | 28,578 | Use RTR with concurrent root in ReactHooks-test.internal | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', 'following_url': 'https://api.github.com/users/jackpope/following{/other_user}', 'gists_url': 'https://api.github.com/users/jackpope/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jackpope/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jackpope/subscriptions', 'organizations_url': 'https://api.github.com/users/jackpope/orgs', 'repos_url': 'https://api.github.com/users/jackpope/repos', 'events_url': 'https://api.github.com/users/jackpope/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jackpope/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e...7af3cd4968c6f481c0f2e36d585269dd988057aa\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/7af3cd4968c6f481c0f2e36d585269dd988057aa/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **=** | 176.83 kB | 176.83 kB | = | 54.90 kB | 54.90 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/7af3cd4968c6f481c0f2e36d585269dd988057aa/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/7af3cd4968c6f481c0f2e36d585269dd988057aa/files/facebook-www/ReactDOM-prod.classic.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **=** | 594.16 kB | 594.16 kB | = | 104.41 kB | 104.41 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/7af3cd4968c6f481c0f2e36d585269dd988057aa/files/facebook-www/ReactDOM-prod.modern.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **=** | 577.42 kB | 577.42 kB | = | 101.45 kB | 101.45 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/7af3cd4968c6f481c0f2e36d585269dd988057aa/files/__test_utils__/ReactAllWarnings.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/7af3cd4968c6f481c0f2e36d585269dd988057aa/files/__test_utils__/ReactAllWarnings.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 7af3cd4968c6f481c0f2e36d585269dd988057aa\n</p>\n"
] | 2024-03-18 16:06:53 | 2024-03-18 19:49:34 | 2024-03-18 19:49:31 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28578', 'html_url': 'https://github.com/facebook/react/pull/28578', 'diff_url': 'https://github.com/facebook/react/pull/28578.diff', 'patch_url': 'https://github.com/facebook/react/pull/28578.patch', 'merged_at': datetime.datetime(2024, 3, 18, 19, 49, 31)} | Continued cleanup of legacy root usage from RTR | {'url': 'https://api.github.com/repos/facebook/react/issues/28578/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28578/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28577 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28577/labels{/name} | https://api.github.com/repos/facebook/react/issues/28577/comments | https://api.github.com/repos/facebook/react/issues/28577/events | https://github.com/facebook/react/pull/28577 | 2,192,631,637 | PR_kwDOAJy2Ks5p9r4G | 28,577 | Fix ReactHooksInspectionIntegration-test | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', 'following_url': 'https://api.github.com/users/jackpope/following{/other_user}', 'gists_url': 'https://api.github.com/users/jackpope/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jackpope/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jackpope/subscriptions', 'organizations_url': 'https://api.github.com/users/jackpope/orgs', 'repos_url': 'https://api.github.com/users/jackpope/repos', 'events_url': 'https://api.github.com/users/jackpope/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jackpope/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [] | 2024-03-18 16:05:08 | 2024-03-18 17:15:26 | 2024-03-18 17:15:23 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28577', 'html_url': 'https://github.com/facebook/react/pull/28577', 'diff_url': 'https://github.com/facebook/react/pull/28577.diff', 'patch_url': 'https://github.com/facebook/react/pull/28577.patch', 'merged_at': datetime.datetime(2024, 3, 18, 17, 15, 23)} | Resolve conflict between #28508 and #28546
| {'url': 'https://api.github.com/repos/facebook/react/issues/28577/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28577/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28576 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28576/labels{/name} | https://api.github.com/repos/facebook/react/issues/28576/comments | https://api.github.com/repos/facebook/react/issues/28576/events | https://github.com/facebook/react/pull/28576 | 2,192,496,565 | PR_kwDOAJy2Ks5p9Oiw | 28,576 | Upgrade flow to 0.231.0 | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6a01aca75b77da01b0e6513fe61a4842637c7dfd...c1b6eeed27252c1db0c2b249ebf3f6640eba88e7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/c1b6eeed27252c1db0c2b249ebf3f6640eba88e7/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=6a01aca75b77da01b0e6513fe61a4842637c7dfd) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.90 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/c1b6eeed27252c1db0c2b249ebf3f6640eba88e7/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=6a01aca75b77da01b0e6513fe61a4842637c7dfd) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/c1b6eeed27252c1db0c2b249ebf3f6640eba88e7/files/facebook-www/ReactDOM-prod.classic.js?compare=6a01aca75b77da01b0e6513fe61a4842637c7dfd) | **=** | 594.16 kB | 594.16 kB | = | 104.41 kB | 104.41 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/c1b6eeed27252c1db0c2b249ebf3f6640eba88e7/files/facebook-www/ReactDOM-prod.modern.js?compare=6a01aca75b77da01b0e6513fe61a4842637c7dfd) | **=** | 577.42 kB | 577.42 kB | = | 101.45 kB | 101.45 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/c1b6eeed27252c1db0c2b249ebf3f6640eba88e7/files/__test_utils__/ReactAllWarnings.js?compare=6a01aca75b77da01b0e6513fe61a4842637c7dfd) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/c1b6eeed27252c1db0c2b249ebf3f6640eba88e7/files/__test_utils__/ReactAllWarnings.js?compare=6a01aca75b77da01b0e6513fe61a4842637c7dfd) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against c1b6eeed27252c1db0c2b249ebf3f6640eba88e7\n</p>\n"
] | 2024-03-18 15:14:21 | 2024-03-18 17:23:11 | 2024-03-18 17:23:07 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28576', 'html_url': 'https://github.com/facebook/react/pull/28576', 'diff_url': 'https://github.com/facebook/react/pull/28576.diff', 'patch_url': 'https://github.com/facebook/react/pull/28576.patch', 'merged_at': datetime.datetime(2024, 3, 18, 17, 23, 7)} | Upgrade flow to 0.231.0
| {'url': 'https://api.github.com/repos/facebook/react/issues/28576/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28576/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28575 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28575/labels{/name} | https://api.github.com/repos/facebook/react/issues/28575/comments | https://api.github.com/repos/facebook/react/issues/28575/events | https://github.com/facebook/react/pull/28575 | 2,191,926,935 | PR_kwDOAJy2Ks5p7SFD | 28,575 | Test for overlapping optimistic updates | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9ffe9102ffd08ca7a56c60aa6952208890d213ce...080f45b8f8f0cb208f7458a4470bad56f2fe83f9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/080f45b8f8f0cb208f7458a4470bad56f2fe83f9/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/080f45b8f8f0cb208f7458a4470bad56f2fe83f9/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/080f45b8f8f0cb208f7458a4470bad56f2fe83f9/files/facebook-www/ReactDOM-prod.classic.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 594.04 kB | 594.04 kB | = | 104.37 kB | 104.37 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/080f45b8f8f0cb208f7458a4470bad56f2fe83f9/files/facebook-www/ReactDOM-prod.modern.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 577.30 kB | 577.30 kB | = | 101.42 kB | 101.42 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/080f45b8f8f0cb208f7458a4470bad56f2fe83f9/files/__test_utils__/ReactAllWarnings.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/080f45b8f8f0cb208f7458a4470bad56f2fe83f9/files/__test_utils__/ReactAllWarnings.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 080f45b8f8f0cb208f7458a4470bad56f2fe83f9\n</p>\n"
] | 2024-03-18 11:19:23 | 2024-03-18 12:52:28 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28575', 'html_url': 'https://github.com/facebook/react/pull/28575', 'diff_url': 'https://github.com/facebook/react/pull/28575.diff', 'patch_url': 'https://github.com/facebook/react/pull/28575.patch', 'merged_at': None} | Test for the code authored in https://github.com/facebook/react/issues/28574 | {'url': 'https://api.github.com/repos/facebook/react/issues/28575/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28575/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28574 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28574/labels{/name} | https://api.github.com/repos/facebook/react/issues/28574/comments | https://api.github.com/repos/facebook/react/issues/28574/events | https://github.com/facebook/react/issues/28574 | 2,190,825,303 | I_kwDOAJy2Ks6ClVdX | 28,574 | Bug: optimistic state (useOptimistic) shows both optimistic and returned from server data when running several async actions | {'login': 'acherkashin', 'id': 9947582, 'node_id': 'MDQ6VXNlcjk5NDc1ODI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9947582?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acherkashin', 'html_url': 'https://github.com/acherkashin', 'followers_url': 'https://api.github.com/users/acherkashin/followers', 'following_url': 'https://api.github.com/users/acherkashin/following{/other_user}', 'gists_url': 'https://api.github.com/users/acherkashin/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acherkashin/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acherkashin/subscriptions', 'organizations_url': 'https://api.github.com/users/acherkashin/orgs', 'repos_url': 'https://api.github.com/users/acherkashin/repos', 'events_url': 'https://api.github.com/users/acherkashin/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acherkashin/received_events', 'type': 'User', 'site_admin': False} | [{'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Needs%20Investigation', 'name': 'Type: Needs Investigation', 'color': '65AA9C', 'default': False, 'description': ''}
{'id': 739761016, 'node_id': 'MDU6TGFiZWw3Mzk3NjEwMTY=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Reconciler', 'name': 'Component: Reconciler', 'color': 'f9a798', 'default': False, 'description': None}] | open | false | null | [] | null | [
"Thank you for the comprehensive repro. \r\n\r\nI reduced it a bit more and also added two potential workarounds that I highlighted in comments as \"Alternate A\" and \"Alternate B\" as well as one with (in my opinion) degraded UX in \"Alternate C\": https://stackblitz.com/edit/react-9vvm42?file=src%2FApp.js\r\n\r\nFirst two clicks create just one pending update. Everything works fine.\r\n\r\nLast click happens while the action from the prior click is still pending, creating this intermediate state where an item is both in the optimistic and non-optimistic slice.\r\n\r\n[Screencast from 18.03.2024 11:01:08.webm](https://github.com/facebook/react/assets/12292047/31147f30-a773-4125-8f40-f5d0f2f75d94)\r\n\r\nI also added a test that repros the original issue: https://github.com/facebook/react/pull/28575\r\n\r\n\r\nHowever, I'll double check with the team if this shouldn't have \"just worked\" as you authored it. If either of the workarounds are required, we should definitely document it. Especially since it's not quite clear to me how this would work with primitives e.g. incrementing an optimistic click counter.",
"FYI, This could be reproed in the [official demo](https://react.dev/reference/react/useOptimistic#optimistically-updating-with-forms)\r\n\r\nhttps://github.com/facebook/react/assets/69352453/b596a882-302e-45bc-be3f-d64e85188571\r\n\r\n",
"@eps1lon Your \"Alternate A\" solution is pretty clear and works great.\r\n\r\nHowever, I have a questions about \"Alternate B\" solution. \r\nWhy optimistic update function is called 3 times every time optimistic state is updated? \r\n\r\n<img width=\"1101\" alt=\"image\" src=\"https://github.com/facebook/react/assets/9947582/3da16c1f-4d08-41bd-be52-f4f153bfb7b1\">\r\n\r\nAnd how this solution work at all, I mean, how item can be inside non-optimistic state earlier optimistic version if we append it to optimistic version first? 🤔 \r\n",
"> Why optimistic update function is called 3 times every time optimistic state is updated?\r\n\r\nWhen an action completes, we rebase the optimistic updates (i.e. replay) on top of the passthrough value (the non-optimistic state). That's why you see multile calls.",
"@eps1lon thank you for the explanation. \r\n\r\n> And how this solution work at all, I mean, how item can be inside non-optimistic state earlier optimistic version if we append it to optimistic version first? 🤔\r\n\r\nCould you throw the light on the question above?",
"Because we added it to the non-optimistic slice but it's still in the optimistic slice because one action is still pending. "
] | 2024-03-17 19:24:35 | 2024-03-22 18:44:28 | null | NONE | null | null | null | I have a form with submit button. When I click on the button, I call update optimistic state and update real state as soon as action is finished. When I click on the button 3 times, I will see 6 items in the list for a while.
https://github.com/facebook/react/assets/9947582/234d8e6c-a69b-429a-bc89-92dc4818f8db
React version:
- "react": "18.3.0-canary-bb0944fe5-20240313",
- "react-dom": "18.3.0-canary-bb0944fe5-20240313"
## Steps To Reproduce
1. Click 3 times on the button
Link to repository:
https://github.com/acherkashin/react19-useOptimistic
Link to sandbox
https://stackblitz.com/~/github.com/acherkashin/react19-useOptimistic
```
const AddToCartForm = ({ title, addToCart, optimisticAddToCart }: AddToCartFormProps) => {
const formAction = async (formData: FormData) => {
const itemId = String(formData.get('itemID'));
optimisticAddToCart({ id: itemId, title, pending: true });
try {
await addToCart(itemId, title);
} catch (e) {
console.log(e);
// show error notification
}
};
return (
<form action={formAction}>
<h2>{title}</h2>
<input type="hidden" name="itemID" value={crypto.randomUUID()} />
<button type="submit">Add to Cart</button>
</form>
);
};
```
## The current behavior
I see every added item 2 times.
## The expected behavior
If I add 3 elements, I should see 3 items in the list, not 6. | {'url': 'https://api.github.com/repos/facebook/react/issues/28574/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28574/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28573 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28573/labels{/name} | https://api.github.com/repos/facebook/react/issues/28573/comments | https://api.github.com/repos/facebook/react/issues/28573/events | https://github.com/facebook/react/pull/28573 | 2,190,295,244 | PR_kwDOAJy2Ks5p13G3 | 28,573 | Bump follow-redirects from 1.15.4 to 1.15.6 | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/users/dependabot%5Bbot%5D/followers', 'following_url': 'https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}', 'gists_url': 'https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dependabot%5Bbot%5D/subscriptions', 'organizations_url': 'https://api.github.com/users/dependabot%5Bbot%5D/orgs', 'repos_url': 'https://api.github.com/users/dependabot%5Bbot%5D/repos', 'events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/received_events', 'type': 'Bot', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/react/labels/dependencies', 'name': 'dependencies', 'color': '0366d6', 'default': False, 'description': 'Pull requests that update a dependency file'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8...9570fb2c092541882e4948a6bcdcf2cde4fbfc7a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/9570fb2c092541882e4948a6bcdcf2cde4fbfc7a/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/9570fb2c092541882e4948a6bcdcf2cde4fbfc7a/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/9570fb2c092541882e4948a6bcdcf2cde4fbfc7a/files/facebook-www/ReactDOM-prod.classic.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 594.16 kB | 594.16 kB | = | 104.42 kB | 104.42 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/9570fb2c092541882e4948a6bcdcf2cde4fbfc7a/files/facebook-www/ReactDOM-prod.modern.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 577.42 kB | 577.42 kB | = | 101.45 kB | 101.45 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9570fb2c092541882e4948a6bcdcf2cde4fbfc7a/files/__test_utils__/ReactAllWarnings.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9570fb2c092541882e4948a6bcdcf2cde4fbfc7a/files/__test_utils__/ReactAllWarnings.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 9570fb2c092541882e4948a6bcdcf2cde4fbfc7a\n</p>\n"
] | 2024-03-16 22:41:01 | 2024-03-18 15:50:01 | 2024-03-18 15:49:54 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28573', 'html_url': 'https://github.com/facebook/react/pull/28573', 'diff_url': 'https://github.com/facebook/react/pull/28573.diff', 'patch_url': 'https://github.com/facebook/react/pull/28573.patch', 'merged_at': datetime.datetime(2024, 3, 18, 15, 49, 54)} | Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/35a517c5861d79dc8bff7db8626013d20b711b06"><code>35a517c</code></a> Release version 1.15.6 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/c4f847f85176991f95ab9c88af63b1294de8649b"><code>c4f847f</code></a> Drop Proxy-Authorization across hosts.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/8526b4a1b2ab3a2e4044299377df623a661caa76"><code>8526b4a</code></a> Use GitHub for disclosure.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/b1677ce00110ee50dc5da576751d39b281fc4944"><code>b1677ce</code></a> Release version 1.15.5 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/d8914f7982403ea096b39bd594a00ee9d3b7e224"><code>d8914f7</code></a> Preserve fragment in responseUrl.</li>
<li>See full diff in <a href="https://github.com/follow-redirects/follow-redirects/compare/v1.15.4...v1.15.6">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts).
</details> | {'url': 'https://api.github.com/repos/facebook/react/issues/28573/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28573/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28572 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28572/labels{/name} | https://api.github.com/repos/facebook/react/issues/28572/comments | https://api.github.com/repos/facebook/react/issues/28572/events | https://github.com/facebook/react/pull/28572 | 2,190,294,635 | PR_kwDOAJy2Ks5p1299 | 28,572 | Bump follow-redirects from 1.15.4 to 1.15.6 in /fixtures/concurrent/time-slicing | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/users/dependabot%5Bbot%5D/followers', 'following_url': 'https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}', 'gists_url': 'https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dependabot%5Bbot%5D/subscriptions', 'organizations_url': 'https://api.github.com/users/dependabot%5Bbot%5D/orgs', 'repos_url': 'https://api.github.com/users/dependabot%5Bbot%5D/repos', 'events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/received_events', 'type': 'Bot', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/react/labels/dependencies', 'name': 'dependencies', 'color': '0366d6', 'default': False, 'description': 'Pull requests that update a dependency file'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8...dcbba0aaed59da32d5d5f05f97fb4c57dee6486a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/dcbba0aaed59da32d5d5f05f97fb4c57dee6486a/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/dcbba0aaed59da32d5d5f05f97fb4c57dee6486a/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/dcbba0aaed59da32d5d5f05f97fb4c57dee6486a/files/facebook-www/ReactDOM-prod.classic.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 594.16 kB | 594.16 kB | = | 104.42 kB | 104.42 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/dcbba0aaed59da32d5d5f05f97fb4c57dee6486a/files/facebook-www/ReactDOM-prod.modern.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 577.42 kB | 577.42 kB | = | 101.45 kB | 101.45 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/dcbba0aaed59da32d5d5f05f97fb4c57dee6486a/files/__test_utils__/ReactAllWarnings.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/dcbba0aaed59da32d5d5f05f97fb4c57dee6486a/files/__test_utils__/ReactAllWarnings.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against dcbba0aaed59da32d5d5f05f97fb4c57dee6486a\n</p>\n"
] | 2024-03-16 22:40:21 | 2024-03-18 15:56:12 | 2024-03-18 15:56:04 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28572', 'html_url': 'https://github.com/facebook/react/pull/28572', 'diff_url': 'https://github.com/facebook/react/pull/28572.diff', 'patch_url': 'https://github.com/facebook/react/pull/28572.patch', 'merged_at': datetime.datetime(2024, 3, 18, 15, 56, 4)} | Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/35a517c5861d79dc8bff7db8626013d20b711b06"><code>35a517c</code></a> Release version 1.15.6 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/c4f847f85176991f95ab9c88af63b1294de8649b"><code>c4f847f</code></a> Drop Proxy-Authorization across hosts.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/8526b4a1b2ab3a2e4044299377df623a661caa76"><code>8526b4a</code></a> Use GitHub for disclosure.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/b1677ce00110ee50dc5da576751d39b281fc4944"><code>b1677ce</code></a> Release version 1.15.5 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/d8914f7982403ea096b39bd594a00ee9d3b7e224"><code>d8914f7</code></a> Preserve fragment in responseUrl.</li>
<li>See full diff in <a href="https://github.com/follow-redirects/follow-redirects/compare/v1.15.4...v1.15.6">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts).
</details> | {'url': 'https://api.github.com/repos/facebook/react/issues/28572/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28572/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28571 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28571/labels{/name} | https://api.github.com/repos/facebook/react/issues/28571/comments | https://api.github.com/repos/facebook/react/issues/28571/events | https://github.com/facebook/react/pull/28571 | 2,190,294,310 | PR_kwDOAJy2Ks5p125T | 28,571 | Bump follow-redirects from 1.15.4 to 1.15.6 in /fixtures/ssr | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/users/dependabot%5Bbot%5D/followers', 'following_url': 'https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}', 'gists_url': 'https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dependabot%5Bbot%5D/subscriptions', 'organizations_url': 'https://api.github.com/users/dependabot%5Bbot%5D/orgs', 'repos_url': 'https://api.github.com/users/dependabot%5Bbot%5D/repos', 'events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/received_events', 'type': 'Bot', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/react/labels/dependencies', 'name': 'dependencies', 'color': '0366d6', 'default': False, 'description': 'Pull requests that update a dependency file'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8...640a51ac2417be3f698f828098f1ae52726829d5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/640a51ac2417be3f698f828098f1ae52726829d5/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/640a51ac2417be3f698f828098f1ae52726829d5/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/640a51ac2417be3f698f828098f1ae52726829d5/files/facebook-www/ReactDOM-prod.classic.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 594.16 kB | 594.16 kB | = | 104.42 kB | 104.42 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/640a51ac2417be3f698f828098f1ae52726829d5/files/facebook-www/ReactDOM-prod.modern.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **=** | 577.42 kB | 577.42 kB | = | 101.45 kB | 101.45 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/640a51ac2417be3f698f828098f1ae52726829d5/files/__test_utils__/ReactAllWarnings.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/640a51ac2417be3f698f828098f1ae52726829d5/files/__test_utils__/ReactAllWarnings.js?compare=b09e102ff1e2aaaf5eb6585b04609ac7ff54a5c8) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 640a51ac2417be3f698f828098f1ae52726829d5\n</p>\n"
] | 2024-03-16 22:40:01 | 2024-03-18 16:00:00 | 2024-03-18 15:59:57 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28571', 'html_url': 'https://github.com/facebook/react/pull/28571', 'diff_url': 'https://github.com/facebook/react/pull/28571.diff', 'patch_url': 'https://github.com/facebook/react/pull/28571.patch', 'merged_at': datetime.datetime(2024, 3, 18, 15, 59, 57)} | Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/35a517c5861d79dc8bff7db8626013d20b711b06"><code>35a517c</code></a> Release version 1.15.6 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/c4f847f85176991f95ab9c88af63b1294de8649b"><code>c4f847f</code></a> Drop Proxy-Authorization across hosts.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/8526b4a1b2ab3a2e4044299377df623a661caa76"><code>8526b4a</code></a> Use GitHub for disclosure.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/b1677ce00110ee50dc5da576751d39b281fc4944"><code>b1677ce</code></a> Release version 1.15.5 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/d8914f7982403ea096b39bd594a00ee9d3b7e224"><code>d8914f7</code></a> Preserve fragment in responseUrl.</li>
<li>See full diff in <a href="https://github.com/follow-redirects/follow-redirects/compare/v1.15.4...v1.15.6">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts).
</details> | {'url': 'https://api.github.com/repos/facebook/react/issues/28571/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28571/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28570 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28570/labels{/name} | https://api.github.com/repos/facebook/react/issues/28570/comments | https://api.github.com/repos/facebook/react/issues/28570/events | https://github.com/facebook/react/issues/28570 | 2,190,116,059 | I_kwDOAJy2Ks6CioTb | 28,570 | Bug: Uncaught DOMException: Failed to set the 'value' property on 'HTMLInputElement': This input element accepts a filename, which may only be programmatically set to the empty string. | {'login': 'Redskinsjo', 'id': 51161811, 'node_id': 'MDQ6VXNlcjUxMTYxODEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/51161811?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Redskinsjo', 'html_url': 'https://github.com/Redskinsjo', 'followers_url': 'https://api.github.com/users/Redskinsjo/followers', 'following_url': 'https://api.github.com/users/Redskinsjo/following{/other_user}', 'gists_url': 'https://api.github.com/users/Redskinsjo/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Redskinsjo/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Redskinsjo/subscriptions', 'organizations_url': 'https://api.github.com/users/Redskinsjo/orgs', 'repos_url': 'https://api.github.com/users/Redskinsjo/repos', 'events_url': 'https://api.github.com/users/Redskinsjo/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Redskinsjo/received_events', 'type': 'User', 'site_admin': False} | [{'id': 1168115654, 'node_id': 'MDU6TGFiZWwxMTY4MTE1NjU0', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Support%20Redirect', 'name': 'Resolution: Support Redirect', 'color': '106099', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"Hey @Redskinsjo,\r\nTo avoid errors, don't use `as` when you don't have to. Here's an example:\r\nhttps://stackblitz.com/edit/stackblitz-starters-rvhudz?file=app%2FhomeChild.tsx",
"This seems like a usage question for the DOM APIs not React itself.\r\n\r\nSupport requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\nCoding Questions\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to browse through frequent questions about using React, as well as ask for help with specific questions.\r\n\r\nhttps://stackoverflow.com/questions/tagged/react\r\n\r\nTalk to other React developers\r\nThere are many online forums which are a great place for discussion about best practices and application architecture as well as the future of React.\r\n\r\nhttps://react.dev/community",
"to anyone searching for this issue, setting the value of an file input is forbidden for security reasons. If you mean to set that value to get it in the FormData of a result of a form, it is useless. Simply keep that input with a type=file (not type=hidden), you can instead set css display:none, and the file uploaded will render in the formData.\r\n\r\nThank you @eps1lon ",
"@Redskinsjo Thank you for following up on this! This will help future readers."
] | 2024-03-16 16:08:27 | 2024-03-18 09:11:32 | 2024-03-17 14:12:54 | NONE | null | null | null | uploading a file that I read with readAsDataUrl creates this error
React version:
"react": "18.2.0",
"react-dom": "18.2.0",
## Steps To Reproduce
1. Create an input type=file
2. Upload a file and read it with readAsDataUrl
3. Store the result in a state
4. Use this state to display the result
Link to code example: https://stackblitz.com/edit/stackblitz-starters-u1i4q1?file=app%2FhomeChild.tsx
## The current behavior
creates an error
## The expected behavior
not creating an error, being able to upload a file | {'url': 'https://api.github.com/repos/facebook/react/issues/28570/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28570/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28569 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28569/labels{/name} | https://api.github.com/repos/facebook/react/issues/28569/comments | https://api.github.com/repos/facebook/react/issues/28569/events | https://github.com/facebook/react/pull/28569 | 2,189,833,312 | PR_kwDOAJy2Ks5p0V0n | 28,569 | Performance: avoid triggering map deopt in V8 | {'login': 'romgrk', 'id': 1423607, 'node_id': 'MDQ6VXNlcjE0MjM2MDc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1423607?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/romgrk', 'html_url': 'https://github.com/romgrk', 'followers_url': 'https://api.github.com/users/romgrk/followers', 'following_url': 'https://api.github.com/users/romgrk/following{/other_user}', 'gists_url': 'https://api.github.com/users/romgrk/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/romgrk/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/romgrk/subscriptions', 'organizations_url': 'https://api.github.com/users/romgrk/orgs', 'repos_url': 'https://api.github.com/users/romgrk/repos', 'events_url': 'https://api.github.com/users/romgrk/events{/privacy}', 'received_events_url': 'https://api.github.com/users/romgrk/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1293047d6063f3508af15e68cca916660ded791e...a27ad7a6c65712fbb4db5611f75d4cd1a5cfd494\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/a27ad7a6c65712fbb4db5611f75d4cd1a5cfd494/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.90 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/a27ad7a6c65712fbb4db5611f75d4cd1a5cfd494/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/a27ad7a6c65712fbb4db5611f75d4cd1a5cfd494/files/facebook-www/ReactDOM-prod.classic.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **=** | 594.16 kB | 594.16 kB | = | 104.42 kB | 104.41 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/a27ad7a6c65712fbb4db5611f75d4cd1a5cfd494/files/facebook-www/ReactDOM-prod.modern.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **=** | 577.42 kB | 577.42 kB | = | 101.45 kB | 101.45 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/a27ad7a6c65712fbb4db5611f75d4cd1a5cfd494/files/__test_utils__/ReactAllWarnings.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/a27ad7a6c65712fbb4db5611f75d4cd1a5cfd494/files/__test_utils__/ReactAllWarnings.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against a27ad7a6c65712fbb4db5611f75d4cd1a5cfd494\n</p>\n",
"Thank you, we should probably install a \"sort properties in object literals\" lint rule to catch these generally."
] | 2024-03-16 07:16:04 | 2024-03-19 02:55:54 | 2024-03-18 15:54:34 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28569', 'html_url': 'https://github.com/facebook/react/pull/28569', 'diff_url': 'https://github.com/facebook/react/pull/28569.diff', 'patch_url': 'https://github.com/facebook/react/pull/28569.patch', 'merged_at': datetime.datetime(2024, 3, 18, 15, 54, 34)} | The shape of the objects changed by this PR are both created in 2 locations with 2 different shapes, which most JS engines won't like. I've noticed this in particular in V8 while benchmarking production code.
https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberCacheComponent.js#L66-L77
https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHostContext.js#L47-L54
https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHooks.js#L3530-L3531
https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHooks.js#L3492-L3493 | {'url': 'https://api.github.com/repos/facebook/react/issues/28569/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28569/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28568 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28568/labels{/name} | https://api.github.com/repos/facebook/react/issues/28568/comments | https://api.github.com/repos/facebook/react/issues/28568/events | https://github.com/facebook/react/pull/28568 | 2,189,587,583 | PR_kwDOAJy2Ks5pzh1y | 28,568 | [Fizz] Prevent uncloned large precomputed chunks without relying on render-time assertions | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_url': 'https://api.github.com/users/gnoff/following{/other_user}', 'gists_url': 'https://api.github.com/users/gnoff/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gnoff/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gnoff/subscriptions', 'organizations_url': 'https://api.github.com/users/gnoff/orgs', 'repos_url': 'https://api.github.com/users/gnoff/repos', 'events_url': 'https://api.github.com/users/gnoff/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gnoff/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 966d17483c2a628fda36794bc193c7ad2c3124eb...76f7f70c4da63269953354524ac651be64d407a3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 177.19 kB | 177.19 kB | = | 55.23 kB | 55.23 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 177.72 kB | 177.72 kB | = | 55.55 kB | 55.55 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/facebook-www/ReactDOM-prod.classic.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 594.67 kB | 594.67 kB | = | 105.04 kB | 105.04 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/facebook-www/ReactDOM-prod.modern.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 577.93 kB | 577.93 kB | = | 102.10 kB | 102.10 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.25 kB | 2.20 kB | = | 0.88 kB | 0.87 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.25 kB | 2.20 kB | = | 0.88 kB | 0.87 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.25 kB | 2.20 kB | = | 0.88 kB | 0.87 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.48 kB | 2.41 kB | = | 0.94 kB | 0.92 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.48 kB | 2.41 kB | = | 0.94 kB | 0.92 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.48 kB | 2.41 kB | = | 0.94 kB | 0.92 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 1.35 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 1.35 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 1.35 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/__test_utils__/ReactAllWarnings.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 140.54 kB | 140.06 kB | = | 31.23 kB | 31.09 kB\n| [oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 137.97 kB | 137.49 kB | = | 30.53 kB | 30.39 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 134.36 kB | 133.89 kB | = | 31.11 kB | 30.98 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 133.31 kB | 132.84 kB | = | 30.78 kB | 30.64 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 139.26 kB | 138.77 kB | = | 32.08 kB | 31.93 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 132.43 kB | 131.96 kB | = | 30.60 kB | 30.46 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 130.86 kB | 130.39 kB | = | 30.07 kB | 29.93 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 136.98 kB | 136.49 kB | = | 31.45 kB | 31.29 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 136.63 kB | 136.14 kB | = | 31.23 kB | 31.08 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 134.34 kB | 133.85 kB | = | 30.64 kB | 30.48 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 128.18 kB | 127.69 kB | = | 29.19 kB | 29.03 kB\n| [oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 118.15 kB | 117.67 kB | = | 26.96 kB | 26.82 kB\n| [oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 118.15 kB | 117.67 kB | = | 26.96 kB | 26.82 kB\n| [oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 115.58 kB | 115.10 kB | = | 26.28 kB | 26.13 kB\n| [oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 115.58 kB | 115.10 kB | = | 26.28 kB | 26.13 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 112.30 kB | 111.84 kB | = | 26.71 kB | 26.57 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 112.30 kB | 111.84 kB | = | 26.71 kB | 26.57 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 117.68 kB | 117.19 kB | = | 27.81 kB | 27.66 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 117.68 kB | 117.19 kB | = | 27.81 kB | 27.66 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 111.93 kB | 111.46 kB | = | 26.64 kB | 26.50 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 111.93 kB | 111.46 kB | = | 26.64 kB | 26.50 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 110.37 kB | 109.91 kB | = | 26.21 kB | 26.06 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 110.37 kB | 109.91 kB | = | 26.21 kB | 26.06 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 115.40 kB | 114.90 kB | = | 27.20 kB | 27.05 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 115.40 kB | 114.90 kB | = | 27.20 kB | 27.05 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 109.48 kB | 109.01 kB | = | 25.97 kB | 25.82 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 109.48 kB | 109.01 kB | = | 25.97 kB | 25.82 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 115.05 kB | 114.55 kB | = | 26.93 kB | 26.78 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 115.05 kB | 114.55 kB | = | 26.93 kB | 26.78 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 112.76 kB | 112.26 kB | = | 26.37 kB | 26.21 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 112.76 kB | 112.26 kB | = | 26.37 kB | 26.21 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 106.60 kB | 106.11 kB | = | 24.99 kB | 24.83 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 106.60 kB | 106.11 kB | = | 24.99 kB | 24.83 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.25 kB | 2.20 kB | = | 0.88 kB | 0.87 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.25 kB | 2.20 kB | = | 0.88 kB | 0.87 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.25 kB | 2.20 kB | = | 0.88 kB | 0.87 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.48 kB | 2.41 kB | = | 0.94 kB | 0.92 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.48 kB | 2.41 kB | = | 0.94 kB | 0.92 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 2.48 kB | 2.41 kB | = | 0.94 kB | 0.92 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 1.35 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 1.35 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **=** | 1.35 kB | 1.31 kB | = | 0.63 kB | 0.62 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/76f7f70c4da63269953354524ac651be64d407a3/files/__test_utils__/ReactAllWarnings.js?compare=966d17483c2a628fda36794bc193c7ad2c3124eb) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 76f7f70c4da63269953354524ac651be64d407a3\n</p>\n",
"Yeah I suppose edge has implied tighter memory constraints. Do you think the transferred buffers are likely to not be freed quickly?\r\n\r\nbut yes I came to the same conclusion that it’s trivial for us to split up our large chunks to make them smaller and that is less bad than accidentally failing to assert the copy like what happened in the case I’m fixing"
] | 2024-03-15 22:57:23 | 2024-03-16 19:39:43 | 2024-03-16 19:39:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28568', 'html_url': 'https://github.com/facebook/react/pull/28568', 'diff_url': 'https://github.com/facebook/react/pull/28568.diff', 'patch_url': 'https://github.com/facebook/react/pull/28568.patch', 'merged_at': datetime.datetime(2024, 3, 16, 19, 39, 38)} | A while back we implemented a heuristic that if a chunk was large it was assumed to be produced by the render and thus was safe to stream which results in transferring the underlying object memory. Later we ran into an issue where a precomputed chunk grew large enough to trigger this hueristic and it started causing renders to fail because once a second render had occurred the precomputed chunk would not have an underlying buffer of bytes to send and these bytes would be omitted from the stream. We implemented a technique to detect large precomputed chunks and we enforced that these always be cloned before writing. Unfortunately our test coverage was not perfect and there has been for a very long time now a usage pattern where if you complete a boundary in one flush and then complete a boundary that has stylehsheet dependencies in another flush you can get a large precomputed chunk that was not being cloned to be sent twice causing streaming errors.
I've thought about why we even went with this solution in the first place and I think it was a mistake. It relies on a dev only check to catch paired with potentially version specific order of operations on the streaming side. This is too unreliable. Additionally the low limit of view size for Edge is not used in Node.js but there is not real justification for this.
In this change I updated the view size for edge streaming to match Node at 2048 bytes which is still relatively small and we have no data one way or another to preference 512 over this. Then I updated the assertion logic to error anytime a precomputed chunk exceeds the size. This eliminates the need to clone these chunks by just making sure our view size is always larger than the largest precomputed chunk we can possibly write. I'm generally in favor of this for a few reasons.
First, we'll always know during testing whether we've violated the limit as long as we exercise each stream config because the precomputed chunks are created in module scope. Second, we can always split up large chunks so making sure the precomptued chunk is smaller than whatever view size we actually desire is relatively trivial.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28568/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28568/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28567 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28567/labels{/name} | https://api.github.com/repos/facebook/react/issues/28567/comments | https://api.github.com/repos/facebook/react/issues/28567/events | https://github.com/facebook/react/pull/28567 | 2,189,460,131 | PR_kwDOAJy2Ks5pzFlF | 28,567 | Local | {'login': 'rizwan-r-r', 'id': 132520847, 'node_id': 'U_kgDOB-Ybjw', 'avatar_url': 'https://avatars.githubusercontent.com/u/132520847?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rizwan-r-r', 'html_url': 'https://github.com/rizwan-r-r', 'followers_url': 'https://api.github.com/users/rizwan-r-r/followers', 'following_url': 'https://api.github.com/users/rizwan-r-r/following{/other_user}', 'gists_url': 'https://api.github.com/users/rizwan-r-r/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rizwan-r-r/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rizwan-r-r/subscriptions', 'organizations_url': 'https://api.github.com/users/rizwan-r-r/orgs', 'repos_url': 'https://api.github.com/users/rizwan-r-r/repos', 'events_url': 'https://api.github.com/users/rizwan-r-r/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rizwan-r-r/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Hi @rizwan-r-r! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328567). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1293047d6063f3508af15e68cca916660ded791e...3db02d8f67c412cf1efd010302fd176fd40cbb6d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/3db02d8f67c412cf1efd010302fd176fd40cbb6d/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/3db02d8f67c412cf1efd010302fd176fd40cbb6d/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/3db02d8f67c412cf1efd010302fd176fd40cbb6d/files/facebook-www/ReactDOM-prod.classic.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **=** | 594.16 kB | 594.16 kB | = | 104.42 kB | 104.42 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/3db02d8f67c412cf1efd010302fd176fd40cbb6d/files/facebook-www/ReactDOM-prod.modern.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **=** | 577.42 kB | 577.42 kB | = | 101.45 kB | 101.45 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/3db02d8f67c412cf1efd010302fd176fd40cbb6d/files/__test_utils__/ReactAllWarnings.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/3db02d8f67c412cf1efd010302fd176fd40cbb6d/files/__test_utils__/ReactAllWarnings.js?compare=1293047d6063f3508af15e68cca916660ded791e) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 3db02d8f67c412cf1efd010302fd176fd40cbb6d\n</p>\n",
"Great to see you trying to get into open source.\r\n\r\nPlease experiment with markdown (e.g. https://dillinger.io/) or pull requests (see https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request for further documentation) on a personal repository. Opening Pull Requests or issues creates notifications for maintainers and everyone watching this repository."
] | 2024-03-15 20:58:24 | 2024-03-15 21:58:36 | 2024-03-15 21:58:35 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28567', 'html_url': 'https://github.com/facebook/react/pull/28567', 'diff_url': 'https://github.com/facebook/react/pull/28567.diff', 'patch_url': 'https://github.com/facebook/react/pull/28567.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28567/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28567/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28566 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28566/labels{/name} | https://api.github.com/repos/facebook/react/issues/28566/comments | https://api.github.com/repos/facebook/react/issues/28566/events | https://github.com/facebook/react/pull/28566 | 2,189,220,211 | PR_kwDOAJy2Ks5pyQLe | 28,566 | Remove excess `ms` prop from Suspense tests | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9ffe9102ffd08ca7a56c60aa6952208890d213ce...9bc26c80df44aaabf1592c0e68e8f6fa60efa6b6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/9bc26c80df44aaabf1592c0e68e8f6fa60efa6b6/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/9bc26c80df44aaabf1592c0e68e8f6fa60efa6b6/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/9bc26c80df44aaabf1592c0e68e8f6fa60efa6b6/files/facebook-www/ReactDOM-prod.classic.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 594.04 kB | 594.04 kB | = | 104.37 kB | 104.37 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/9bc26c80df44aaabf1592c0e68e8f6fa60efa6b6/files/facebook-www/ReactDOM-prod.modern.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 577.30 kB | 577.30 kB | = | 101.42 kB | 101.42 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9bc26c80df44aaabf1592c0e68e8f6fa60efa6b6/files/__test_utils__/ReactAllWarnings.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9bc26c80df44aaabf1592c0e68e8f6fa60efa6b6/files/__test_utils__/ReactAllWarnings.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 9bc26c80df44aaabf1592c0e68e8f6fa60efa6b6\n</p>\n"
] | 2024-03-15 18:16:17 | 2024-03-15 19:57:44 | 2024-03-15 19:57:43 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28566', 'html_url': 'https://github.com/facebook/react/pull/28566', 'diff_url': 'https://github.com/facebook/react/pull/28566.diff', 'patch_url': 'https://github.com/facebook/react/pull/28566.patch', 'merged_at': datetime.datetime(2024, 3, 15, 19, 57, 43)} | These tests now use the built-in cache and the `ms` prop was ignored for a while now so I removed them to avoid confusion when reading tests.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28566/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28566/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28565 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28565/labels{/name} | https://api.github.com/repos/facebook/react/issues/28565/comments | https://api.github.com/repos/facebook/react/issues/28565/events | https://github.com/facebook/react/pull/28565 | 2,189,189,350 | PR_kwDOAJy2Ks5pyJV7 | 28,565 | Revert rollout state of enableCache in React Native to next major only | {'login': 'rubennorte', 'id': 117921, 'node_id': 'MDQ6VXNlcjExNzkyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/117921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubennorte', 'html_url': 'https://github.com/rubennorte', 'followers_url': 'https://api.github.com/users/rubennorte/followers', 'following_url': 'https://api.github.com/users/rubennorte/following{/other_user}', 'gists_url': 'https://api.github.com/users/rubennorte/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rubennorte/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rubennorte/subscriptions', 'organizations_url': 'https://api.github.com/users/rubennorte/orgs', 'repos_url': 'https://api.github.com/users/rubennorte/repos', 'events_url': 'https://api.github.com/users/rubennorte/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rubennorte/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a870b2d5494351d75b68c3d9baf03a52fd40a8ef...91f571289e61d034200bf7a6affadef461b13f58\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/facebook-www/ReactDOM-prod.classic.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 594.16 kB | 594.16 kB | = | 104.42 kB | 104.42 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/facebook-www/ReactDOM-prod.modern.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 577.42 kB | 577.42 kB | = | 101.45 kB | 101.45 kB\n| [react-native/implementations/ReactNativeRenderer-dev.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactNativeRenderer-dev.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 999.93 kB | 965.07 kB | = | 200.16 kB | 193.94 kB\n| [react-native/implementations/ReactFabric-dev.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactFabric-dev.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 985.02 kB | 950.15 kB | = | 196.48 kB | 190.30 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactNativeRenderer-profiling.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 354.18 kB | 339.30 kB | = | 61.78 kB | 59.34 kB\n| [react-native/implementations/ReactFabric-profiling.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactFabric-profiling.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 344.81 kB | 329.76 kB | = | 60.18 kB | 57.66 kB\n| [react-native/implementations/ReactNativeRenderer-prod.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactNativeRenderer-prod.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 334.78 kB | 319.97 kB | = | 58.58 kB | 56.11 kB\n| [react-native/implementations/ReactFabric-prod.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactFabric-prod.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 326.13 kB | 311.14 kB | = | 57.09 kB | 54.61 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/__test_utils__/ReactAllWarnings.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [react-native/implementations/ReactNativeRenderer-dev.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactNativeRenderer-dev.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 999.93 kB | 965.07 kB | = | 200.16 kB | 193.94 kB\n| [react-native/implementations/ReactFabric-dev.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactFabric-dev.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 985.02 kB | 950.15 kB | = | 196.48 kB | 190.30 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactNativeRenderer-profiling.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 354.18 kB | 339.30 kB | = | 61.78 kB | 59.34 kB\n| [react-native/implementations/ReactFabric-profiling.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactFabric-profiling.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 344.81 kB | 329.76 kB | = | 60.18 kB | 57.66 kB\n| [react-native/implementations/ReactNativeRenderer-prod.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactNativeRenderer-prod.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 334.78 kB | 319.97 kB | = | 58.58 kB | 56.11 kB\n| [react-native/implementations/ReactFabric-prod.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/react-native/implementations/ReactFabric-prod.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 326.13 kB | 311.14 kB | = | 57.09 kB | 54.61 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/91f571289e61d034200bf7a6affadef461b13f58/files/__test_utils__/ReactAllWarnings.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 91f571289e61d034200bf7a6affadef461b13f58\n</p>\n"
] | 2024-03-15 17:56:57 | 2024-03-15 18:02:51 | 2024-03-15 18:02:47 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28565', 'html_url': 'https://github.com/facebook/react/pull/28565', 'diff_url': 'https://github.com/facebook/react/pull/28565.diff', 'patch_url': 'https://github.com/facebook/react/pull/28565.patch', 'merged_at': datetime.datetime(2024, 3, 15, 18, 2, 47)} | ## Summary
We're working on enabling the use of microtasks in React Native by default when using the new architecture. To enable this we need to synchronize the RN renderers from React, but doing this causes an error because the renderers now rely on an object defined in `React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED` (`ReactCurrentCache`) that's hasn't been released as a stable version yet (cache).
This reverts the change done in #28519 to avoid enabling the cache API in RN until we release a new version of React in npm.
## How did you test this change?
Manually built the RN renderer, copied it to the RN repository and tested e2e in RNTester. | {'url': 'https://api.github.com/repos/facebook/react/issues/28565/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28565/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28564 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28564/labels{/name} | https://api.github.com/repos/facebook/react/issues/28564/comments | https://api.github.com/repos/facebook/react/issues/28564/events | https://github.com/facebook/react/pull/28564 | 2,189,172,207 | PR_kwDOAJy2Ks5pyFit | 28,564 | [Flight] Encode React Elements in Replies as Temporary References | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"Lovely PR description! ❤️ "
] | 2024-03-15 17:45:28 | 2024-03-19 20:59:53 | 2024-03-19 20:59:53 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28564', 'html_url': 'https://github.com/facebook/react/pull/28564', 'diff_url': 'https://github.com/facebook/react/pull/28564.diff', 'patch_url': 'https://github.com/facebook/react/pull/28564.patch', 'merged_at': datetime.datetime(2024, 3, 19, 20, 59, 53)} | Currently you can accidentally pass React Element to a Server Action. It warns but in prod it actually works because we can encode the symbol and otherwise it's mostly a plain object. It only works if you only pass host components and no function props etc. which makes it potentially error later. The first thing this does it just early hard error for elements.
I made Lazy work by unwrapping though since that will be replaced by Promises later which works.
Our protocol is not fully symmetric in that elements flow from Server -> Client. Only the Server can resolve Components and only the client should really be able to receive host components. It's not intended that a Server can actually do something with them other than passing them to the client.
In the case of a Reply, we expect the client to be stateful. It's waiting for a response. So anything we can't serialize we can still pass by reference to an in memory object. So I introduce the concept of a TemporaryReferenceSet which is an opaque object that you create before encoding the reply. This then stashes any unserializable values in this set and encode the slot by id. When a new response from the Action then returns we pass the same temporary set into the parser which can then restore the objects. This lets you pass a value by reference to the server and back into another slot.
For example it can be used to render children inside a parent tree from a server action:
```
export async function Component({ children }) {
"use server";
return <div>{children}</div>;
}
```
(You wouldn't normally do this due to the waterfalls but for advanced cases.)
A common scenario where this comes up accidentally today is in `useActionState`.
```
export function action(state, formData) {
"use server";
if (errored) {
return <div>This action <strong>errored</strong></div>;
}
return null;
}
```
```
const [errors, formAction] = useActionState(action);
return <div>{errors}<div>;
```
It feels like I'm just passing the JSX from server to client. However, because `useActionState` also sends the previous state *back* to the server this should not actually be valid. Before this PR this actually worked accidentally. You get a DEV warning but it used to work in prod. Once you do something like pass a client reference it won't work tho. We could perhaps make client references work by stashing where we got them from but it wouldn't work with all possible JSX.
By adding temporary references to the action implementation this will work again - on the client. It'll also be more efficient since we don't send back the JSX content that you shouldn't introspect on the server anyway.
However, a flaw here is that the progressive enhancement of this case won't work because we can't use temporary references for progressive enhancement since there's no in memory stash. What is worse is that it won't error if you hydrate. ~It also will error late in the example above because the first state is "undefined" so invoking the form once works - it errors on the second attempt when it tries to send the error state back again.~ It actually errors on the first invocation because we need to eagerly serialize "previous state" into the form. So at least that's better.
I think maybe the solution to this particular pattern would be to allow JSX to serialize if you have no temporary reference set, and remember client references so that client references can be returned back to the server as client references. That way anything you could send from the server could also be returned to the server. But it would only deopt to serializing it for progressive enhancement. The consequence of that would be that there's a lot of JSX that might accidentally seem like it should work but it's only if you've gotten it from the server before that it works. This would have to have pair them somehow though since you can't take a client reference from one implementation of Flight and use it with another. | {'url': 'https://api.github.com/repos/facebook/react/issues/28564/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/28564/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28563 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28563/labels{/name} | https://api.github.com/repos/facebook/react/issues/28563/comments | https://api.github.com/repos/facebook/react/issues/28563/events | https://github.com/facebook/react/issues/28563 | 2,188,571,119 | I_kwDOAJy2Ks6CcvHv | 28,563 | Bug: when installing the application, the old version of "react-scripts" is installed | {'login': 'quant12345', 'id': 32775019, 'node_id': 'MDQ6VXNlcjMyNzc1MDE5', 'avatar_url': 'https://avatars.githubusercontent.com/u/32775019?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/quant12345', 'html_url': 'https://github.com/quant12345', 'followers_url': 'https://api.github.com/users/quant12345/followers', 'following_url': 'https://api.github.com/users/quant12345/following{/other_user}', 'gists_url': 'https://api.github.com/users/quant12345/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/quant12345/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/quant12345/subscriptions', 'organizations_url': 'https://api.github.com/users/quant12345/orgs', 'repos_url': 'https://api.github.com/users/quant12345/repos', 'events_url': 'https://api.github.com/users/quant12345/events{/privacy}', 'received_events_url': 'https://api.github.com/users/quant12345/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\nCoding Questions\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to browse through frequent questions about using React, as well as ask for help with specific questions.\r\n\r\nhttps://stackoverflow.com/questions/tagged/react\r\n\r\nTalk to other React developers\r\nThere are many online forums which are a great place for discussion about best practices and application architecture as well as the future of React.\r\n\r\nhttps://react.dev/community"
] | 2024-03-15 13:53:11 | 2024-03-15 20:16:56 | 2024-03-15 20:16:56 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
6.22.3
## Steps To Reproduce
1.npx create-react-app my_app
Ubuntu 22.04
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
**package.json**
```
{
"name": "roureact",
"version": "0.1.0",
"private": true,
"dependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-router-dom": "^6.22.3",
"react-scripts": "0.9.5"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test --env=jsdom",
"eject": "react-scripts eject"
}
}
```
## The expected behavior
new version `"react-scripts"` | {'url': 'https://api.github.com/repos/facebook/react/issues/28563/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28563/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28562 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28562/labels{/name} | https://api.github.com/repos/facebook/react/issues/28562/comments | https://api.github.com/repos/facebook/react/issues/28562/events | https://github.com/facebook/react/pull/28562 | 2,188,351,994 | PR_kwDOAJy2Ks5pvNAM | 28,562 | Fix log assertion in cancels tasks in Scheduler-test | {'login': 'sweetliquid', 'id': 18693190, 'node_id': 'MDQ6VXNlcjE4NjkzMTkw', 'avatar_url': 'https://avatars.githubusercontent.com/u/18693190?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sweetliquid', 'html_url': 'https://github.com/sweetliquid', 'followers_url': 'https://api.github.com/users/sweetliquid/followers', 'following_url': 'https://api.github.com/users/sweetliquid/following{/other_user}', 'gists_url': 'https://api.github.com/users/sweetliquid/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sweetliquid/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sweetliquid/subscriptions', 'organizations_url': 'https://api.github.com/users/sweetliquid/orgs', 'repos_url': 'https://api.github.com/users/sweetliquid/repos', 'events_url': 'https://api.github.com/users/sweetliquid/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sweetliquid/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a870b2d5494351d75b68c3d9baf03a52fd40a8ef...527d3a976d6ebb5e3690a5af485e49dc2934ac95\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/527d3a976d6ebb5e3690a5af485e49dc2934ac95/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/527d3a976d6ebb5e3690a5af485e49dc2934ac95/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/527d3a976d6ebb5e3690a5af485e49dc2934ac95/files/facebook-www/ReactDOM-prod.classic.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 594.16 kB | 594.16 kB | = | 104.42 kB | 104.42 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/527d3a976d6ebb5e3690a5af485e49dc2934ac95/files/facebook-www/ReactDOM-prod.modern.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 577.42 kB | 577.42 kB | = | 101.45 kB | 101.45 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/527d3a976d6ebb5e3690a5af485e49dc2934ac95/files/__test_utils__/ReactAllWarnings.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/527d3a976d6ebb5e3690a5af485e49dc2934ac95/files/__test_utils__/ReactAllWarnings.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 527d3a976d6ebb5e3690a5af485e49dc2934ac95\n</p>\n"
] | 2024-03-15 11:58:05 | 2024-03-15 20:21:46 | 2024-03-15 20:21:46 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28562', 'html_url': 'https://github.com/facebook/react/pull/28562', 'diff_url': 'https://github.com/facebook/react/pull/28562.diff', 'patch_url': 'https://github.com/facebook/react/pull/28562.patch', 'merged_at': datetime.datetime(2024, 3, 15, 20, 21, 46)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<img width="611" alt="image" src="https://github.com/facebook/react/assets/18693190/bfb63a64-c0b0-4e03-909a-2d40479ef0ef">
<img width="247" alt="image" src="https://github.com/facebook/react/assets/18693190/41bbeff7-7d77-48e3-b14d-7b637292837a">
In old tests, it was always pass the test even if the task was not cancelled. Because no fireMessageEvent was called and the `onmessage` was not executed.
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28562/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28562/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28561 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28561/labels{/name} | https://api.github.com/repos/facebook/react/issues/28561/comments | https://api.github.com/repos/facebook/react/issues/28561/events | https://github.com/facebook/react/issues/28561 | 2,188,134,646 | I_kwDOAJy2Ks6CbEj2 | 28,561 | Question and suggest: The official identifier of Server Compnoent and Client Component | {'login': 'aofong19871029', 'id': 5194217, 'node_id': 'MDQ6VXNlcjUxOTQyMTc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5194217?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aofong19871029', 'html_url': 'https://github.com/aofong19871029', 'followers_url': 'https://api.github.com/users/aofong19871029/followers', 'following_url': 'https://api.github.com/users/aofong19871029/following{/other_user}', 'gists_url': 'https://api.github.com/users/aofong19871029/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/aofong19871029/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/aofong19871029/subscriptions', 'organizations_url': 'https://api.github.com/users/aofong19871029/orgs', 'repos_url': 'https://api.github.com/users/aofong19871029/repos', 'events_url': 'https://api.github.com/users/aofong19871029/events{/privacy}', 'received_events_url': 'https://api.github.com/users/aofong19871029/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"`.client.js` and `.server.js` was the convention that was proposed originally but later changed to using `'use client'` and `'use server'` directives instead in https://github.com/reactjs/rfcs/pull/227.\r\n\r\n[`'use client'` directive](https://react.dev/reference/react/use-client#use-client) and [`'use server'` directives](https://react.dev/reference/react/use-server) are the official convention.",
"Such an approach violates the principle of separation of concerns, as component files should be independent of where they are used (on the server or client). Instead, it's better to strive for creating reusable components that can work seamlessly both on the server and client without modifications.",
"Some components only make sense on the server (e.g. accessing the file system) and need server directives. Most components can be used as both and don't need directives. The linked RFCs go into more detail. \r\n\r\nIf there are issues with the current approach, I recommend filing a new issue outlining the problems in detail with some examples. Closing this since the original question was answered."
] | 2024-03-15 09:56:01 | 2024-03-17 14:10:14 | 2024-03-17 14:10:11 | NONE | null | null | null | As so far , only next.js and react original js support react server componet.
In next.js developer is to being requested to use “use client” to idenfy the react client component , and all of the other js are default to react server component.
In the community find the another way to identity component is to change its file suffix
'.server.js' means this is a server component
'.client.js' means its a client component
So I want to know **what is the react official identifier for server component and client component in future?**
| {'url': 'https://api.github.com/repos/facebook/react/issues/28561/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28561/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28560 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28560/labels{/name} | https://api.github.com/repos/facebook/react/issues/28560/comments | https://api.github.com/repos/facebook/react/issues/28560/events | https://github.com/facebook/react/pull/28560 | 2,187,412,178 | PR_kwDOAJy2Ks5psA3p | 28,560 | Bump follow-redirects from 1.13.0 to 1.15.6 in /fixtures/dom | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/users/dependabot%5Bbot%5D/followers', 'following_url': 'https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}', 'gists_url': 'https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dependabot%5Bbot%5D/subscriptions', 'organizations_url': 'https://api.github.com/users/dependabot%5Bbot%5D/orgs', 'repos_url': 'https://api.github.com/users/dependabot%5Bbot%5D/repos', 'events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/received_events', 'type': 'Bot', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/react/labels/dependencies', 'name': 'dependencies', 'color': '0366d6', 'default': False, 'description': 'Pull requests that update a dependency file'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a870b2d5494351d75b68c3d9baf03a52fd40a8ef...ab6305f310935e58475837f1d5adc35437377a56\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/ab6305f310935e58475837f1d5adc35437377a56/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/ab6305f310935e58475837f1d5adc35437377a56/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/ab6305f310935e58475837f1d5adc35437377a56/files/facebook-www/ReactDOM-prod.classic.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 594.16 kB | 594.16 kB | = | 104.42 kB | 104.42 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/ab6305f310935e58475837f1d5adc35437377a56/files/facebook-www/ReactDOM-prod.modern.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **=** | 577.42 kB | 577.42 kB | = | 101.45 kB | 101.45 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ab6305f310935e58475837f1d5adc35437377a56/files/__test_utils__/ReactAllWarnings.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ab6305f310935e58475837f1d5adc35437377a56/files/__test_utils__/ReactAllWarnings.js?compare=a870b2d5494351d75b68c3d9baf03a52fd40a8ef) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ab6305f310935e58475837f1d5adc35437377a56\n</p>\n"
] | 2024-03-14 22:50:37 | 2024-03-18 15:56:04 | 2024-03-18 15:55:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28560', 'html_url': 'https://github.com/facebook/react/pull/28560', 'diff_url': 'https://github.com/facebook/react/pull/28560.diff', 'patch_url': 'https://github.com/facebook/react/pull/28560.patch', 'merged_at': datetime.datetime(2024, 3, 18, 15, 55, 56)} | Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.0 to 1.15.6.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/35a517c5861d79dc8bff7db8626013d20b711b06"><code>35a517c</code></a> Release version 1.15.6 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/c4f847f85176991f95ab9c88af63b1294de8649b"><code>c4f847f</code></a> Drop Proxy-Authorization across hosts.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/8526b4a1b2ab3a2e4044299377df623a661caa76"><code>8526b4a</code></a> Use GitHub for disclosure.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/b1677ce00110ee50dc5da576751d39b281fc4944"><code>b1677ce</code></a> Release version 1.15.5 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/d8914f7982403ea096b39bd594a00ee9d3b7e224"><code>d8914f7</code></a> Preserve fragment in responseUrl.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/65858205e59f1e23c9bf173348a7a7cbb8ac47f5"><code>6585820</code></a> Release version 1.15.4 of the npm package.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/7a6567e16dfa9ad18a70bfe91784c28653fbf19d"><code>7a6567e</code></a> Disallow bracketed hostnames.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/05629af696588b90d64e738bc2e809a97a5f92fc"><code>05629af</code></a> Prefer native URL instead of deprecated url.parse.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/1cba8e85fa73f563a439fe460cf028688e4358df"><code>1cba8e8</code></a> Prefer native URL instead of legacy url.resolve.</li>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/72bc2a4229bc18dc9fbd57c60579713e6264cb92"><code>72bc2a4</code></a> Simplify _processResponse error handling.</li>
<li>Additional commits viewable in <a href="https://github.com/follow-redirects/follow-redirects/compare/v1.13.0...v1.15.6">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts).
</details> | {'url': 'https://api.github.com/repos/facebook/react/issues/28560/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28560/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28559 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28559/labels{/name} | https://api.github.com/repos/facebook/react/issues/28559/comments | https://api.github.com/repos/facebook/react/issues/28559/events | https://github.com/facebook/react/pull/28559 | 2,186,623,403 | PR_kwDOAJy2Ks5ppSMo | 28,559 | Make `enableNewBooleanProps` www dynamic | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9ffe9102ffd08ca7a56c60aa6952208890d213ce...89f9f3017d3a6aaa4fc77f946be4e33a613b5abc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/89f9f3017d3a6aaa4fc77f946be4e33a613b5abc/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/89f9f3017d3a6aaa4fc77f946be4e33a613b5abc/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/89f9f3017d3a6aaa4fc77f946be4e33a613b5abc/files/facebook-www/ReactDOM-prod.classic.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **+0.02%** | 594.04 kB | 594.16 kB | +0.04% | 104.37 kB | 104.42 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/89f9f3017d3a6aaa4fc77f946be4e33a613b5abc/files/facebook-www/ReactDOM-prod.modern.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **+0.02%** | 577.30 kB | 577.42 kB | +0.03% | 101.42 kB | 101.45 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/89f9f3017d3a6aaa4fc77f946be4e33a613b5abc/files/__test_utils__/ReactAllWarnings.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [facebook-www/ReactDOMServerStreaming-dev.modern.js](https://react-builds.vercel.app/commits/89f9f3017d3a6aaa4fc77f946be4e33a613b5abc/files/facebook-www/ReactDOMServerStreaming-dev.modern.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **+0.35%** | 486.24 kB | 487.97 kB | +0.32% | 98.74 kB | 99.05 kB\n| [facebook-www/ReactDOMServer-dev.modern.js](https://react-builds.vercel.app/commits/89f9f3017d3a6aaa4fc77f946be4e33a613b5abc/files/facebook-www/ReactDOMServer-dev.modern.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **+0.35%** | 493.47 kB | 495.19 kB | +0.31% | 100.36 kB | 100.67 kB\n| [facebook-www/ReactDOMServer-dev.classic.js](https://react-builds.vercel.app/commits/89f9f3017d3a6aaa4fc77f946be4e33a613b5abc/files/facebook-www/ReactDOMServer-dev.classic.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **+0.35%** | 496.05 kB | 497.77 kB | +0.32% | 100.85 kB | 101.17 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/89f9f3017d3a6aaa4fc77f946be4e33a613b5abc/files/__test_utils__/ReactAllWarnings.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 89f9f3017d3a6aaa4fc77f946be4e33a613b5abc\n</p>\n",
"@jackpope Do you merge it and take care of rolling it out internally?",
"@eps1lon Yes I can handle. Thanks for setting up the dynamic flag!"
] | 2024-03-14 15:10:42 | 2024-03-14 15:58:08 | 2024-03-14 15:50:12 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28559', 'html_url': 'https://github.com/facebook/react/pull/28559', 'diff_url': 'https://github.com/facebook/react/pull/28559.diff', 'patch_url': 'https://github.com/facebook/react/pull/28559.patch', 'merged_at': datetime.datetime(2024, 3, 14, 15, 50, 12)} | Feature: https://github.com/facebook/react/pull/24730 | {'url': 'https://api.github.com/repos/facebook/react/issues/28559/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28559/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28558 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28558/labels{/name} | https://api.github.com/repos/facebook/react/issues/28558/comments | https://api.github.com/repos/facebook/react/issues/28558/events | https://github.com/facebook/react/issues/28558 | 2,186,056,802 | I_kwDOAJy2Ks6CTJRi | 28,558 | Bug: Source is not showing in 5.0.2 | {'login': 'pavel-plehanov', 'id': 144036324, 'node_id': 'U_kgDOCJXR5A', 'avatar_url': 'https://avatars.githubusercontent.com/u/144036324?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pavel-plehanov', 'html_url': 'https://github.com/pavel-plehanov', 'followers_url': 'https://api.github.com/users/pavel-plehanov/followers', 'following_url': 'https://api.github.com/users/pavel-plehanov/following{/other_user}', 'gists_url': 'https://api.github.com/users/pavel-plehanov/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/pavel-plehanov/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/pavel-plehanov/subscriptions', 'organizations_url': 'https://api.github.com/users/pavel-plehanov/orgs', 'repos_url': 'https://api.github.com/users/pavel-plehanov/repos', 'events_url': 'https://api.github.com/users/pavel-plehanov/events{/privacy}', 'received_events_url': 'https://api.github.com/users/pavel-plehanov/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"It's working in firefox but not in chrome, likely recent chrome update broke it",
"> Он работает в Firefox, но не в Chrome, вероятно, недавнее обновление Chrome сломало его.\r\n\r\nIn my Firefox - v5.0.0",
"Hey @pavel-plehanov, thanks for reporting this. \r\n\r\nAs I've mentioned in https://github.com/facebook/react/issues/28544#issuecomment-1991591646, this is expected change. In v5.0.0 RDT is using `__debugSource` field from fiber, which is soon will be removed with the next React release.\r\n\r\nThe way how RDT defines source has changed in https://github.com/facebook/react/pull/28471: `bundle.js:[lineNumber]` is the actual source, because this is what is loaded in the browser, unless you have source maps, which list other sources.\r\n\r\nTechnically, yes, this is a regression on RDT side, but an expected one, because previously used debugging fields are no longer available (removed from React) for different reasons.",
"> Hey @pavel-plehanov, thanks for reporting this.\r\n> \r\n> As I've mentioned in [#28544 (comment)](https://github.com/facebook/react/issues/28544#issuecomment-1991591646), this is expected change. In v5.0.0 RDT is using `__debugSource` field from fiber, which is soon will be removed with the next React release.\r\n> \r\n> The way how RDT defines source has changed in #28471: `bundle.js:[lineNumber]` is the actual source, because this is what is loaded in the browser, unless you have source maps, which list other sources.\r\n> \r\n> Technically, yes, this is a regression on RDT side, but an expected one, because previously used debugging fields are no longer available (removed from React) for different reasons.\r\n\r\n\r\nHow do I enable sourcemaps in CRA development mode?",
"How would we debug legacy apps? How can we get hold of the older versions to install?",
"> How would we debug legacy apps? How can we get hold of the older versions to install?\r\n\r\nI followed the instructions here: \r\n\r\nhttps://gist.github.com/juniorcesarabreu/115a4f5141cd1a841119c511c4c66d3f\r\n\r\nI will downgrade until there is better support for this feature.",
"After all, the #1 use of this extension is to find the correct file and line to edit in a large project. ATM when you point to a component all you get is chunk.xxxxx.js:2321312",
"An archive of past versions is available in the Firefox",
"I can confirm that downgrading to 5.0.0 fixes this issue in Chrome.\r\nThe issue is also present in Firefox but I didn't try the downgrade there.",
"Any one have any idea why source number is not showing ? for me it displaying like this \r\n\r\n"
] | 2024-03-14 10:59:36 | 2024-04-08 09:13:01 | null | NONE | null | null | null | ## Stand
DevTools version: 5.0.2-47cf347e4
Chrome 122.0.6261.129 x64, Edge 122.0.2365.80 x64
## Propblem
In the DevTools -> Components -> source.
The path to the bundle.js file is specified.
#### v5.0.2
#### v5.0.0
## Analog Issue
https://github.com/facebook/react/issues/28544
@hoxyq this is has nothing to do with reality.
But "source" **work** in "DevTools version: **5.0.0**-993c4d003"
And **doesnt wokr** in "DevTools version: **5.0.2**-47cf347e4"
Tested one application on the same PC at the same time in the defferent version DevTools.
Equal SourceMap
React version: 18
## The current behavior
Open DevTools, choose component -> the source field contains the name of the component
## The expected behavior
Open DevTools, choose component -> the source field says "bundle.js:[lineNumber]".
| {'url': 'https://api.github.com/repos/facebook/react/issues/28558/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28558/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28557 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28557/labels{/name} | https://api.github.com/repos/facebook/react/issues/28557/comments | https://api.github.com/repos/facebook/react/issues/28557/events | https://github.com/facebook/react/pull/28557 | 2,185,948,301 | PR_kwDOAJy2Ks5pm8Jt | 28,557 | Ensure dispatch from `useFormState` works in `StrictMode` | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bbc571aee431d44799ae6a70832ea834325a5af9...e32f38a05b1861af1be67ce223dafbf5f83e4799\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/e32f38a05b1861af1be67ce223dafbf5f83e4799/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=bbc571aee431d44799ae6a70832ea834325a5af9) | **=** | 176.83 kB | 176.84 kB | +0.02% | 54.91 kB | 54.92 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/e32f38a05b1861af1be67ce223dafbf5f83e4799/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=bbc571aee431d44799ae6a70832ea834325a5af9) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/e32f38a05b1861af1be67ce223dafbf5f83e4799/files/facebook-www/ReactDOM-prod.classic.js?compare=bbc571aee431d44799ae6a70832ea834325a5af9) | **=** | 594.04 kB | 594.07 kB | = | 104.37 kB | 104.38 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/e32f38a05b1861af1be67ce223dafbf5f83e4799/files/facebook-www/ReactDOM-prod.modern.js?compare=bbc571aee431d44799ae6a70832ea834325a5af9) | **=** | 577.30 kB | 577.33 kB | = | 101.42 kB | 101.43 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/e32f38a05b1861af1be67ce223dafbf5f83e4799/files/__test_utils__/ReactAllWarnings.js?compare=bbc571aee431d44799ae6a70832ea834325a5af9) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/e32f38a05b1861af1be67ce223dafbf5f83e4799/files/__test_utils__/ReactAllWarnings.js?compare=bbc571aee431d44799ae6a70832ea834325a5af9) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e32f38a05b1861af1be67ce223dafbf5f83e4799\n</p>\n",
"This was introduced by https://github.com/facebook/react/pull/28514. Easy oversight to make, glad we caught it quickly.\r\n\r\nNote that it doesn't just affect StrictMode, the same issue happen if you called `setState` during render to trigger a re-render. Or if you suspended with `use` after `useFormState` has already been called. That last one is the most idiomatic so I'd probably write the regression test using that pattern."
] | 2024-03-14 10:06:36 | 2024-03-20 15:16:13 | 2024-03-20 15:15:22 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28557', 'html_url': 'https://github.com/facebook/react/pull/28557', 'diff_url': 'https://github.com/facebook/react/pull/28557.diff', 'patch_url': 'https://github.com/facebook/react/pull/28557.patch', 'merged_at': datetime.datetime(2024, 3, 20, 15, 15, 22)} | ## Summary
Closes https://github.com/facebook/react/issues/28556
We didn't follow the Rules of Hooks in the rerender implementation for mounts.
## Test plan
- Added test based on "useFormState updates state asynchronously and queues multiple actions" but with StrictMode and less dispatches (because it repros on the first attempt) | {'url': 'https://api.github.com/repos/facebook/react/issues/28557/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28557/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28556 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28556/labels{/name} | https://api.github.com/repos/facebook/react/issues/28556/comments | https://api.github.com/repos/facebook/react/issues/28556/events | https://github.com/facebook/react/issues/28556 | 2,185,634,128 | I_kwDOAJy2Ks6CRiFQ | 28,556 | Bug: useFormState formAction becomes null in strict mode | {'login': 'akmtagline', 'id': 134274836, 'node_id': 'U_kgDOCADfFA', 'avatar_url': 'https://avatars.githubusercontent.com/u/134274836?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/akmtagline', 'html_url': 'https://github.com/akmtagline', 'followers_url': 'https://api.github.com/users/akmtagline/followers', 'following_url': 'https://api.github.com/users/akmtagline/following{/other_user}', 'gists_url': 'https://api.github.com/users/akmtagline/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/akmtagline/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/akmtagline/subscriptions', 'organizations_url': 'https://api.github.com/users/akmtagline/orgs', 'repos_url': 'https://api.github.com/users/akmtagline/repos', 'events_url': 'https://api.github.com/users/akmtagline/events{/privacy}', 'received_events_url': 'https://api.github.com/users/akmtagline/received_events', 'type': 'User', 'site_admin': False} | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"I simplified the repro to a single file since the `use server;` directive has no effect in CodeSandbox: https://codesandbox.io/p/sandbox/useformstate-strictmode-double-invoke-action-nulled-6ltttr\r\n\r\n18.3.0-canary-bb0944fe5-20240313: bad\r\n18.3.0-canary-b36ae8d7a-20231207: good\r\n18.3.0-canary-971b62f47-20240129: good\r\n18.3.0-canary-2e470a788-20240214: good\r\n18.3.0-canary-01ab35a9a-20240228: good\r\n18.3.0-canary-0066e0b68-20240306: good\r\n18.3.0-canary-eb33bd747-20240312: good\r\n\r\nLast good: 18.3.0-canary-eb33bd747-20240312\r\nFirst bad: 18.3.0-canary-bb0944fe5-20240313\r\n\r\nNew changes in 18.3.0-canary-bb0944fe5-20240313: https://github.com/facebook/react/compare/eb33bd747...bb0944fe5\r\n\r\nLooks like https://github.com/facebook/react/pull/28514 broke this.\r\n\r\n\r\n"
] | 2024-03-14 07:30:03 | 2024-03-20 15:15:24 | 2024-03-20 15:15:24 | NONE | null | null | null | The form action returned from the hook `useFormState` becomes null when using React strict mode. It causes the page to reload on the submission of the form and the action does not work. I know that the React strict mode performs some actions twice intentionally to find unexpected behavior in the development. But, it would be better if we could use it without disabling the Strict mode.
React version: 0.0.0-experimental-bb0944fe5-20240313
## Steps To Reproduce
1. Enable strict mode
2. Submit the form that uses form action returned from useFormState
Link to code example:
https://codesandbox.io/p/sandbox/jolly-minsky-kmkspd
https://codesandbox.io/p/sandbox/damp-tree-yv2vzy
## The current behavior
Form action becomes null causing the page to reload.
## The expected behavior
Form action should be a function provided as the argument in the `useFormState` hook. | {'url': 'https://api.github.com/repos/facebook/react/issues/28556/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28556/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28555 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28555/labels{/name} | https://api.github.com/repos/facebook/react/issues/28555/comments | https://api.github.com/repos/facebook/react/issues/28555/events | https://github.com/facebook/react/pull/28555 | 2,185,633,810 | PR_kwDOAJy2Ks5pl7Q6 | 28,555 | just a spelling mistake. | {'login': 'bubucuo', 'id': 9839620, 'node_id': 'MDQ6VXNlcjk4Mzk2MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9839620?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bubucuo', 'html_url': 'https://github.com/bubucuo', 'followers_url': 'https://api.github.com/users/bubucuo/followers', 'following_url': 'https://api.github.com/users/bubucuo/following{/other_user}', 'gists_url': 'https://api.github.com/users/bubucuo/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bubucuo/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bubucuo/subscriptions', 'organizations_url': 'https://api.github.com/users/bubucuo/orgs', 'repos_url': 'https://api.github.com/users/bubucuo/repos', 'events_url': 'https://api.github.com/users/bubucuo/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bubucuo/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Thanks!"
] | 2024-03-14 07:29:48 | 2024-03-14 14:04:45 | 2024-03-14 14:04:45 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28555', 'html_url': 'https://github.com/facebook/react/pull/28555', 'diff_url': 'https://github.com/facebook/react/pull/28555.diff', 'patch_url': 'https://github.com/facebook/react/pull/28555.patch', 'merged_at': datetime.datetime(2024, 3, 14, 14, 4, 45)} | just a spelling mistake
| {'url': 'https://api.github.com/repos/facebook/react/issues/28555/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28555/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28554 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28554/labels{/name} | https://api.github.com/repos/facebook/react/issues/28554/comments | https://api.github.com/repos/facebook/react/issues/28554/events | https://github.com/facebook/react/issues/28554 | 2,184,797,864 | I_kwDOAJy2Ks6COV6o | 28,554 | Google Translate causing "Text content does not match server-rendered HTML" | {'login': 'maxiedaniels', 'id': 195294, 'node_id': 'MDQ6VXNlcjE5NTI5NA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/195294?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/maxiedaniels', 'html_url': 'https://github.com/maxiedaniels', 'followers_url': 'https://api.github.com/users/maxiedaniels/followers', 'following_url': 'https://api.github.com/users/maxiedaniels/following{/other_user}', 'gists_url': 'https://api.github.com/users/maxiedaniels/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/maxiedaniels/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/maxiedaniels/subscriptions', 'organizations_url': 'https://api.github.com/users/maxiedaniels/orgs', 'repos_url': 'https://api.github.com/users/maxiedaniels/repos', 'events_url': 'https://api.github.com/users/maxiedaniels/events{/privacy}', 'received_events_url': 'https://api.github.com/users/maxiedaniels/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"@maxiedaniels, can you provide a sandbox reproducing this? (or you might need to create a new repository, not sure if the sandbox would interfere with Google Translate)\r\n\r\nThanks! ❤️"
] | 2024-03-13 20:05:29 | 2024-03-13 20:11:18 | null | NONE | null | null | null | I know there is a well known bug with google translate, where if you have a conditional text node in a parent with other children, it causes a removeChild error. I suspect this is yet another Google Translate issue, but I can't find any posts about it so i wanted to report it.
This is a snippet from my Next.js 14 project, React 18.2.
```
<div className="md:col-span-4 lg:col-span-5">
<div className="mb-2">
<Link href="/" className="block">
<span className="flex text-xl font-light">
<Image className="" src={Logo1x} height={64} width={64} alt="Hero" priority placeholder="blur"/>
<div className="flex flex-col justify-center ml-5">
<div className="flex text-xl font-light">
<p className="font-poppins text-white">My Text</p>
<p className="font-poppins text-vai-highlight">My Text2</p>
</div>
<div className="text-sm text-gray-400 transition duration-150 ease-in-out">More text here.</div>
</div>
</span>
</Link>
</div>
</div>
```
The error when using Google Translate to Italian:
```
app-index.js:35 Warning: Prop `alt` did not match. Server: "Eroe" Client: "Hero"
app-index.js:35 Warning: An error occurred during hydration. The server HTML was replaced with client content in <#document>.
Uncaught Error: Text content does not match server-rendered HTML.
```
The interesting part is that if i remove this snippet, i'll see the error pop up on another element - for example, if i remove the <Image> here, then it'll say the first inner-most <p> with 'My Text' changed. | {'url': 'https://api.github.com/repos/facebook/react/issues/28554/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28554/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28553 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28553/labels{/name} | https://api.github.com/repos/facebook/react/issues/28553/comments | https://api.github.com/repos/facebook/react/issues/28553/events | https://github.com/facebook/react/pull/28553 | 2,184,433,153 | PR_kwDOAJy2Ks5ph2sE | 28,553 | feat[devtools]: add package for fusebox integration | {'login': 'hoxyq', 'id': 28902667, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_url': 'https://api.github.com/users/hoxyq/following{/other_user}', 'gists_url': 'https://api.github.com/users/hoxyq/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hoxyq/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hoxyq/subscriptions', 'organizations_url': 'https://api.github.com/users/hoxyq/orgs', 'repos_url': 'https://api.github.com/users/hoxyq/repos', 'events_url': 'https://api.github.com/users/hoxyq/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hoxyq/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d012a32f840cf575b9d07bf1ed96af34af99e060...2204347fae842c67b54d061680d9360e0bd8fa3a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/2204347fae842c67b54d061680d9360e0bd8fa3a/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=d012a32f840cf575b9d07bf1ed96af34af99e060) | **=** | 168.76 kB | 168.76 kB | = | 52.91 kB | 52.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/2204347fae842c67b54d061680d9360e0bd8fa3a/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=d012a32f840cf575b9d07bf1ed96af34af99e060) | **=** | 170.57 kB | 170.57 kB | = | 53.44 kB | 53.44 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/2204347fae842c67b54d061680d9360e0bd8fa3a/files/facebook-www/ReactDOM-prod.classic.js?compare=d012a32f840cf575b9d07bf1ed96af34af99e060) | **=** | 590.84 kB | 590.84 kB | = | 103.91 kB | 103.91 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/2204347fae842c67b54d061680d9360e0bd8fa3a/files/facebook-www/ReactDOM-prod.modern.js?compare=d012a32f840cf575b9d07bf1ed96af34af99e060) | **=** | 566.66 kB | 566.66 kB | = | 100.10 kB | 100.10 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2204347fae842c67b54d061680d9360e0bd8fa3a/files/__test_utils__/ReactAllWarnings.js?compare=d012a32f840cf575b9d07bf1ed96af34af99e060) | **Deleted** | 64.44 kB | 0.00 kB | Deleted | 16.10 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2204347fae842c67b54d061680d9360e0bd8fa3a/files/__test_utils__/ReactAllWarnings.js?compare=d012a32f840cf575b9d07bf1ed96af34af99e060) | **Deleted** | 64.44 kB | 0.00 kB | Deleted | 16.10 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2204347fae842c67b54d061680d9360e0bd8fa3a\n</p>\n"
] | 2024-03-13 16:30:43 | 2024-04-12 14:29:38 | 2024-04-12 14:29:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28553', 'html_url': 'https://github.com/facebook/react/pull/28553', 'diff_url': 'https://github.com/facebook/react/pull/28553.diff', 'patch_url': 'https://github.com/facebook/react/pull/28553.patch', 'merged_at': datetime.datetime(2024, 4, 12, 14, 29, 35)} | ## Summary
Stacked on https://github.com/facebook/react/pull/28552. Review only the [last commit at the top](https://github.com/facebook/react/pull/28553/commits/c69952f1bf6e23252d47e0f7eb98efbbb2cc2c55).
These changes add new package `react-devtools-fusebox`, which is the entrypoint for the RDT Frontend, which will be used in Chrome DevTools panel. The main differences from other frontend shells (extension, standalone) are:
1. This package builds scripts in ESM format, this is required by Chrome DevTools, see webpack config:
https://github.com/facebook/react/blob/c69952f1bf6e23252d47e0f7eb98efbbb2cc2c55/packages/react-devtools-fusebox/webpack.config.frontend.js#L50-L52
2. The build includes styles in a separate `.css` file, which is required for Chrome DevTools: styles are loaded lazily once panel is mounted. | {'url': 'https://api.github.com/repos/facebook/react/issues/28553/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28553/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28552 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28552/labels{/name} | https://api.github.com/repos/facebook/react/issues/28552/comments | https://api.github.com/repos/facebook/react/issues/28552/events | https://github.com/facebook/react/pull/28552 | 2,184,202,048 | PR_kwDOAJy2Ks5phEDW | 28,552 | feat[devtools]: add method for connecting backend with custom messaging protocol | {'login': 'hoxyq', 'id': 28902667, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_url': 'https://api.github.com/users/hoxyq/following{/other_user}', 'gists_url': 'https://api.github.com/users/hoxyq/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hoxyq/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hoxyq/subscriptions', 'organizations_url': 'https://api.github.com/users/hoxyq/orgs', 'repos_url': 'https://api.github.com/users/hoxyq/repos', 'events_url': 'https://api.github.com/users/hoxyq/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hoxyq/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [] | 2024-03-13 14:48:47 | 2024-04-12 14:17:10 | 2024-04-12 14:17:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28552', 'html_url': 'https://github.com/facebook/react/pull/28552', 'diff_url': 'https://github.com/facebook/react/pull/28552.diff', 'patch_url': 'https://github.com/facebook/react/pull/28552.patch', 'merged_at': datetime.datetime(2024, 4, 12, 14, 17, 7)} | ## Summary
RDT backend will now expose method `connectWithCustomMessagingProtocol`, which will be similar to the classic `connectToDevTools` one, but with few differences:
1. It delegates the communication management between frontend and backend to the owner (whos injecting RDT backend). Unlike the `connectToDevTools`, which is relying on websocket connection and receives host and port as an arguments.
2. It returns a callback, which can be used for unsubscribing the current backend instance from the global DevTools hook.
This is a prerequisite for any non-browser RDT integration, which is not designed to be based on websocket.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28552/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28552/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28551 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28551/labels{/name} | https://api.github.com/repos/facebook/react/issues/28551/comments | https://api.github.com/repos/facebook/react/issues/28551/events | https://github.com/facebook/react/issues/28551 | 2,182,810,209 | I_kwDOAJy2Ks6CGwph | 28,551 | Bug: | {'login': 'Aliqateebah', 'id': 109043364, 'node_id': 'U_kgDOBn_epA', 'avatar_url': 'https://avatars.githubusercontent.com/u/109043364?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Aliqateebah', 'html_url': 'https://github.com/Aliqateebah', 'followers_url': 'https://api.github.com/users/Aliqateebah/followers', 'following_url': 'https://api.github.com/users/Aliqateebah/following{/other_user}', 'gists_url': 'https://api.github.com/users/Aliqateebah/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Aliqateebah/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Aliqateebah/subscriptions', 'organizations_url': 'https://api.github.com/users/Aliqateebah/orgs', 'repos_url': 'https://api.github.com/users/Aliqateebah/repos', 'events_url': 'https://api.github.com/users/Aliqateebah/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Aliqateebah/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2024-03-12 22:47:09 | 2024-03-13 11:29:26 | 2024-03-13 11:29:26 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
## The expected behavior | {'url': 'https://api.github.com/repos/facebook/react/issues/28551/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 3, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28551/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28550 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28550/labels{/name} | https://api.github.com/repos/facebook/react/issues/28550/comments | https://api.github.com/repos/facebook/react/issues/28550/events | https://github.com/facebook/react/pull/28550 | 2,182,808,208 | PR_kwDOAJy2Ks5pcTST | 28,550 | Add `alwaysThrottleDisappearingFallbacks` Flag | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'following_url': 'https://api.github.com/users/yungsters/following{/other_user}', 'gists_url': 'https://api.github.com/users/yungsters/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/yungsters/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/yungsters/subscriptions', 'organizations_url': 'https://api.github.com/users/yungsters/orgs', 'repos_url': 'https://api.github.com/users/yungsters/repos', 'events_url': 'https://api.github.com/users/yungsters/events{/privacy}', 'received_events_url': 'https://api.github.com/users/yungsters/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e...2cb6843fa2dbb4bb4f1aa77cc2015809c2226ede\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/2cb6843fa2dbb4bb4f1aa77cc2015809c2226ede/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **=** | 176.83 kB | 176.83 kB | = | 54.90 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/2cb6843fa2dbb4bb4f1aa77cc2015809c2226ede/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/2cb6843fa2dbb4bb4f1aa77cc2015809c2226ede/files/facebook-www/ReactDOM-prod.classic.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **+0.02%** | 594.16 kB | 594.27 kB | +0.02% | 104.41 kB | 104.44 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/2cb6843fa2dbb4bb4f1aa77cc2015809c2226ede/files/facebook-www/ReactDOM-prod.modern.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **+0.02%** | 577.42 kB | 577.53 kB | +0.02% | 101.45 kB | 101.47 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2cb6843fa2dbb4bb4f1aa77cc2015809c2226ede/files/__test_utils__/ReactAllWarnings.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2cb6843fa2dbb4bb4f1aa77cc2015809c2226ede/files/__test_utils__/ReactAllWarnings.js?compare=7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2cb6843fa2dbb4bb4f1aa77cc2015809c2226ede\n</p>\n",
"> Isn't it weird that no tests need updated?\r\n\r\nI assume that's because the feature flag is set to the same value as `alwaysThrottleRetries` for open source configurations."
] | 2024-03-12 22:44:59 | 2024-03-18 18:16:51 | 2024-03-18 18:16:48 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28550', 'html_url': 'https://github.com/facebook/react/pull/28550', 'diff_url': 'https://github.com/facebook/react/pull/28550.diff', 'patch_url': 'https://github.com/facebook/react/pull/28550.patch', 'merged_at': datetime.datetime(2024, 3, 18, 18, 16, 47)} | ## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that gates the changes from https://github.com/facebook/react/pull/26802 (instead of being controlled by `alwaysThrottleRetries`). The values of this new flag mirror the current values of `alwaysThrottleRetries` such that there is no behavior difference.
This additional feature flag allows us to incrementally validate the change (arguably bug fix) from https://github.com/facebook/react/pull/26802 independently from `alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28550/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28550/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28549 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28549/labels{/name} | https://api.github.com/repos/facebook/react/issues/28549/comments | https://api.github.com/repos/facebook/react/issues/28549/events | https://github.com/facebook/react/pull/28549 | 2,182,559,183 | PR_kwDOAJy2Ks5pbcY4 | 28,549 | Concurrent RTR in ReactHooksInspectionIntegration-test | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', 'following_url': 'https://api.github.com/users/jackpope/following{/other_user}', 'gists_url': 'https://api.github.com/users/jackpope/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jackpope/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jackpope/subscriptions', 'organizations_url': 'https://api.github.com/users/jackpope/orgs', 'repos_url': 'https://api.github.com/users/jackpope/repos', 'events_url': 'https://api.github.com/users/jackpope/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jackpope/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5cec48e145f6b43879b9ef40cdda812b88fff31c...004dd8b1235f8d65b6e816adfbdeeb4ef5b312da\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/004dd8b1235f8d65b6e816adfbdeeb4ef5b312da/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=5cec48e145f6b43879b9ef40cdda812b88fff31c) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/004dd8b1235f8d65b6e816adfbdeeb4ef5b312da/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=5cec48e145f6b43879b9ef40cdda812b88fff31c) | **=** | 173.26 kB | 173.26 kB | = | 54.04 kB | 54.04 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/004dd8b1235f8d65b6e816adfbdeeb4ef5b312da/files/facebook-www/ReactDOM-prod.classic.js?compare=5cec48e145f6b43879b9ef40cdda812b88fff31c) | **=** | 594.27 kB | 594.27 kB | = | 104.44 kB | 104.44 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/004dd8b1235f8d65b6e816adfbdeeb4ef5b312da/files/facebook-www/ReactDOM-prod.modern.js?compare=5cec48e145f6b43879b9ef40cdda812b88fff31c) | **=** | 577.53 kB | 577.53 kB | = | 101.47 kB | 101.47 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/004dd8b1235f8d65b6e816adfbdeeb4ef5b312da/files/__test_utils__/ReactAllWarnings.js?compare=5cec48e145f6b43879b9ef40cdda812b88fff31c) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/004dd8b1235f8d65b6e816adfbdeeb4ef5b312da/files/__test_utils__/ReactAllWarnings.js?compare=5cec48e145f6b43879b9ef40cdda812b88fff31c) | **Deleted** | 66.48 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 004dd8b1235f8d65b6e816adfbdeeb4ef5b312da\n</p>\n"
] | 2024-03-12 19:53:10 | 2024-03-20 15:15:36 | 2024-03-20 15:15:32 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28549', 'html_url': 'https://github.com/facebook/react/pull/28549', 'diff_url': 'https://github.com/facebook/react/pull/28549.diff', 'patch_url': 'https://github.com/facebook/react/pull/28549.patch', 'merged_at': datetime.datetime(2024, 3, 20, 15, 15, 32)} | More test updates to use concurrent root in RTR
`yarn test packages/react-debug-tools/src/__tests__/ReactHooksInspectionIntegration-test.js` | {'url': 'https://api.github.com/repos/facebook/react/issues/28549/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28549/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28548 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28548/labels{/name} | https://api.github.com/repos/facebook/react/issues/28548/comments | https://api.github.com/repos/facebook/react/issues/28548/events | https://github.com/facebook/react/pull/28548 | 2,182,502,816 | PR_kwDOAJy2Ks5pbP9F | 28,548 | Revert "Land enableClientRenderFallbackOnTextMismatch for www" | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: eb33bd74779df6e91c54a47e8f07b22b72a073c7...9b62380c19eb942b974ced62de7ab1be91e19c37\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/9b62380c19eb942b974ced62de7ab1be91e19c37/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=eb33bd74779df6e91c54a47e8f07b22b72a073c7) | **=** | 176.71 kB | 176.71 kB | = | 54.89 kB | 54.89 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/9b62380c19eb942b974ced62de7ab1be91e19c37/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=eb33bd74779df6e91c54a47e8f07b22b72a073c7) | **=** | 177.25 kB | 177.25 kB | = | 55.25 kB | 55.25 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/9b62380c19eb942b974ced62de7ab1be91e19c37/files/facebook-www/ReactDOM-prod.classic.js?compare=eb33bd74779df6e91c54a47e8f07b22b72a073c7) | **+0.07%** | 592.84 kB | 593.26 kB | +0.11% | 104.15 kB | 104.26 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/9b62380c19eb942b974ced62de7ab1be91e19c37/files/facebook-www/ReactDOM-prod.modern.js?compare=eb33bd74779df6e91c54a47e8f07b22b72a073c7) | **+0.07%** | 576.10 kB | 576.52 kB | +0.11% | 101.21 kB | 101.32 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9b62380c19eb942b974ced62de7ab1be91e19c37/files/__test_utils__/ReactAllWarnings.js?compare=eb33bd74779df6e91c54a47e8f07b22b72a073c7) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9b62380c19eb942b974ced62de7ab1be91e19c37/files/__test_utils__/ReactAllWarnings.js?compare=eb33bd74779df6e91c54a47e8f07b22b72a073c7) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 9b62380c19eb942b974ced62de7ab1be91e19c37\n</p>\n"
] | 2024-03-12 19:18:15 | 2024-03-12 19:29:46 | 2024-03-12 19:29:41 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28548', 'html_url': 'https://github.com/facebook/react/pull/28548', 'diff_url': 'https://github.com/facebook/react/pull/28548.diff', 'patch_url': 'https://github.com/facebook/react/pull/28548.patch', 'merged_at': datetime.datetime(2024, 3, 12, 19, 29, 41)} | We're looking to run further experiments on this.
Reverts facebook/react#28538 | {'url': 'https://api.github.com/repos/facebook/react/issues/28548/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28548/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28547 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28547/labels{/name} | https://api.github.com/repos/facebook/react/issues/28547/comments | https://api.github.com/repos/facebook/react/issues/28547/events | https://github.com/facebook/react/issues/28547 | 2,182,420,899 | I_kwDOAJy2Ks6CFRmj | 28,547 | Bug: Search functionality not working correctly on react.dev in Safari on iOS real device (iPhone 12 Pro) | {'login': 'MeetYourCreator', 'id': 57572988, 'node_id': 'MDQ6VXNlcjU3NTcyOTg4', 'avatar_url': 'https://avatars.githubusercontent.com/u/57572988?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MeetYourCreator', 'html_url': 'https://github.com/MeetYourCreator', 'followers_url': 'https://api.github.com/users/MeetYourCreator/followers', 'following_url': 'https://api.github.com/users/MeetYourCreator/following{/other_user}', 'gists_url': 'https://api.github.com/users/MeetYourCreator/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/MeetYourCreator/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/MeetYourCreator/subscriptions', 'organizations_url': 'https://api.github.com/users/MeetYourCreator/orgs', 'repos_url': 'https://api.github.com/users/MeetYourCreator/repos', 'events_url': 'https://api.github.com/users/MeetYourCreator/events{/privacy}', 'received_events_url': 'https://api.github.com/users/MeetYourCreator/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hey there, @MeetYourCreator! 👋\r\n\r\nSince you've already opened this issue on the documentation repo. I'd close it here. Thanks!",
"Thanks @pwbriggs. Will close the issue here.🙂"
] | 2024-03-12 18:36:08 | 2024-03-13 16:47:06 | 2024-03-13 16:47:05 | NONE | null | null | null | ## Steps To Reproduce
1. Open react.dev in Safari on iPhone (real device)
2. Tap search icon: note that search function is working as intended
3. Scroll down to "Write components with code and markup" section
4. Tap search icon: note that action doesn't open search
5. Scroll down again and tap the search icon several times: note that action doesn't open search
6. Repeat step 5: note that eventually screen freezes
An issue has been opened in the [react.dev repo as well](https://github.com/reactjs/react.dev/issues/6694)
---
## The current behavior
Search functionality does not work correctly on iOS real device (iPhone 12 Pro).
https://github.com/facebook/react/assets/57572988/72673d2b-0d83-4bcd-b851-565eff6155b7
Since search functionality is currently working as expected on macOS, both in Chrome and Safari, the issue might be in implementation of [Algolia InstantSearch iOS](https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/ios/):
https://github.com/facebook/react/assets/57572988/9878e087-2ec3-4227-85aa-6e3cc79d7a8d
The iOS real device that this behavior was recorded on is using the current iOS version:
---
## The expected behavior
Search functionality is working as expected on macOS, both in Chrome and Safari. Should work similarly on iOS real device:
**macOs Chrome**
https://github.com/facebook/react/assets/57572988/07dd29d9-fb96-45a7-bdbc-d1d320ed8117
**macOS Safari**
https://github.com/facebook/react/assets/57572988/ac1e01e0-f8e9-4270-bb6e-bed47b9f8a17 | {'url': 'https://api.github.com/repos/facebook/react/issues/28547/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28547/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28546 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28546/labels{/name} | https://api.github.com/repos/facebook/react/issues/28546/comments | https://api.github.com/repos/facebook/react/issues/28546/events | https://github.com/facebook/react/pull/28546 | 2,182,393,454 | PR_kwDOAJy2Ks5pa3XQ | 28,546 | Update isConcurrent RTR option usage | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', 'following_url': 'https://api.github.com/users/jackpope/following{/other_user}', 'gists_url': 'https://api.github.com/users/jackpope/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jackpope/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jackpope/subscriptions', 'organizations_url': 'https://api.github.com/users/jackpope/orgs', 'repos_url': 'https://api.github.com/users/jackpope/repos', 'events_url': 'https://api.github.com/users/jackpope/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jackpope/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 7d6f1e3c13686272c1d76813992d4e782fcb84e6...2a36964b04a7a4fe69ac7577b4d1724da35d7a5a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/2a36964b04a7a4fe69ac7577b4d1724da35d7a5a/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/2a36964b04a7a4fe69ac7577b4d1724da35d7a5a/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/2a36964b04a7a4fe69ac7577b4d1724da35d7a5a/files/facebook-www/ReactDOM-prod.classic.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 593.92 kB | 593.92 kB | = | 104.85 kB | 104.85 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/2a36964b04a7a4fe69ac7577b4d1724da35d7a5a/files/facebook-www/ReactDOM-prod.modern.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 577.18 kB | 577.18 kB | = | 101.91 kB | 101.91 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2a36964b04a7a4fe69ac7577b4d1724da35d7a5a/files/__test_utils__/ReactAllWarnings.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2a36964b04a7a4fe69ac7577b4d1724da35d7a5a/files/__test_utils__/ReactAllWarnings.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2a36964b04a7a4fe69ac7577b4d1724da35d7a5a\n</p>\n",
"@eps1lon Yes we can -- I can replace any FB usage. Was planning to make that change in https://github.com/facebook/react/pull/28498 . But it makes more sense here. Updated"
] | 2024-03-12 18:22:06 | 2024-03-18 15:35:19 | 2024-03-18 15:35:16 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28546', 'html_url': 'https://github.com/facebook/react/pull/28546', 'diff_url': 'https://github.com/facebook/react/pull/28546.diff', 'patch_url': 'https://github.com/facebook/react/pull/28546.patch', 'merged_at': datetime.datetime(2024, 3, 18, 15, 35, 16)} | Reverting some of https://github.com/facebook/react/pull/27804 which renamed this option to stable. This PR just replaces internal usage to make upcoming PRs cleaner.
Keeping isConcurrent unstable for the next major release in order to enable a broader deprecation of RTR and be consistent with concurrent rendering everywhere for next major. (https://github.com/facebook/react/pull/28498)
- Next major will use concurrent root
- The old behavior (legacy root by default, concurrent root with unstable option) will be preserved for React Native until new architecture is fully shipped.
- Flag and legacy root usage can be removed after RN dependency is unblocked without an additional breaking change
| {'url': 'https://api.github.com/repos/facebook/react/issues/28546/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28546/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28545 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28545/labels{/name} | https://api.github.com/repos/facebook/react/issues/28545/comments | https://api.github.com/repos/facebook/react/issues/28545/events | https://github.com/facebook/react/issues/28545 | 2,181,488,821 | I_kwDOAJy2Ks6CBuC1 | 28,545 | Bug: Hydration error due to <button> | {'login': 'JAGADEESHWARAN20', 'id': 66456490, 'node_id': 'MDQ6VXNlcjY2NDU2NDkw', 'avatar_url': 'https://avatars.githubusercontent.com/u/66456490?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JAGADEESHWARAN20', 'html_url': 'https://github.com/JAGADEESHWARAN20', 'followers_url': 'https://api.github.com/users/JAGADEESHWARAN20/followers', 'following_url': 'https://api.github.com/users/JAGADEESHWARAN20/following{/other_user}', 'gists_url': 'https://api.github.com/users/JAGADEESHWARAN20/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/JAGADEESHWARAN20/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/JAGADEESHWARAN20/subscriptions', 'organizations_url': 'https://api.github.com/users/JAGADEESHWARAN20/orgs', 'repos_url': 'https://api.github.com/users/JAGADEESHWARAN20/repos', 'events_url': 'https://api.github.com/users/JAGADEESHWARAN20/events{/privacy}', 'received_events_url': 'https://api.github.com/users/JAGADEESHWARAN20/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"i tried So many time to find this issue , but I don't get it ....\r\n\r\n## screenshot:\r\n\r\n\r\n\r\n## how to remove this also\r\n\r\n",
"Hey @JAGADEESHWARAN20 👋\r\n\r\nI'm not an expert on Next.js, but it looks like this error is caused by nesting two interactive `<button>`s. That is, you have a button within another button.\r\n\r\nHope this helps!",
"@JAGADEESHWARAN20 How did you run this project? using yarn test? ",
"Using npm run dev",
"The error is present because you have nested two buttons because the generated html code will render two buttons side by side whereas during hydration the buttons are nested.",
"Yeah nesting buttons is [invalid HTML](https://www.w3.org/TR/2011/WD-html5-20110525/the-button-element.html#the-button-element)."
] | 2024-03-12 12:23:30 | 2024-03-24 01:26:43 | 2024-03-24 01:26:43 | NONE | null | null | null |
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## is there any way to fix this issue
Unhandled Runtime Error
Error: Hydration failed because the initial UI does not match what was rendered on the server.
See more info here: https://nextjs.org/docs/messages/react-hydration-error
In HTML, <button> cannot be a descendant of <button>.
This will cause a hydration error.
<button>
^^^^^^^^
<_c>
<button>
^^^^^^^^
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
https://github.com/JAGADEESHWARAN20/Shopwithdashboard/blob/main/app/(dashboard)/%5BstoreId%5D/(routes)/settings/components/SettingsForm.tsx
| {'url': 'https://api.github.com/repos/facebook/react/issues/28545/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28545/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28544 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28544/labels{/name} | https://api.github.com/repos/facebook/react/issues/28544/comments | https://api.github.com/repos/facebook/react/issues/28544/events | https://github.com/facebook/react/issues/28544 | 2,181,477,166 | I_kwDOAJy2Ks6CBrMu | 28,544 | Source is not showing | {'login': 'sai-kola', 'id': 59258771, 'node_id': 'MDQ6VXNlcjU5MjU4Nzcx', 'avatar_url': 'https://avatars.githubusercontent.com/u/59258771?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sai-kola', 'html_url': 'https://github.com/sai-kola', 'followers_url': 'https://api.github.com/users/sai-kola/followers', 'following_url': 'https://api.github.com/users/sai-kola/following{/other_user}', 'gists_url': 'https://api.github.com/users/sai-kola/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sai-kola/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sai-kola/subscriptions', 'organizations_url': 'https://api.github.com/users/sai-kola/orgs', 'repos_url': 'https://api.github.com/users/sai-kola/repos', 'events_url': 'https://api.github.com/users/sai-kola/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sai-kola/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"should i need to do any change in setting to get actual source not source in bundle.js",
"Hey, this is a recent change in v5.0.2 of the extension - https://github.com/facebook/react/pull/28471.\r\n\r\nIf you want to see an actual source location of your component, your application should start shipping source maps. React DevTools will attempt to read them and will perform symbolication.\r\n\r\nImportant: React DevTools won't be able to show you the path to the source file on the disk, the original data for this is now removed from React.",
"How to do source maps",
"I'm facing the same issue in my Next.js project. It by default exposes the source map on dev mode.\r\n\r\n\r\n\r\nthe file name is right but the line/column is wrong, \r\n\r\nAlso, it is not picking up the file/position for styled-components:\r\n\r\n\r\n",
"@KinIcy, did you try https://github.com/facebook/react/issues/28544#issuecomment-1991591646 above?",
"> @KinIcy, did you try [#28544 (comment)](https://github.com/facebook/react/issues/28544#issuecomment-1991591646) above?\r\n\r\nyes, I verified my Next.js setup and it should be exposing the source maps by default. Or at least that is what the Sources tab says in Chrome:\r\n\r\n\r\n",
"> > @KinIcy, did you try [#28544 (comment)](https://github.com/facebook/react/issues/28544#issuecomment-1991591646) above?\r\n> \r\n> yes, I verified my Next.js setup and it should be exposing the source maps by default. Or at least that is what the Sources tab says in Chrome:\r\n> \r\n> \r\n\r\nSimilar thing is happening for CRA. Chrome shows source maps loaded but RDT is not able to access it"
] | 2024-03-12 12:17:44 | 2024-03-15 08:57:46 | 2024-03-12 12:56:18 | NONE | null | null | null | if I select any component is should show source of that component but it is showing it in bundle I need source of that component
I have attached the SS check last line ,what can i do to get source, not in bundle source
| {'url': 'https://api.github.com/repos/facebook/react/issues/28544/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28544/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28543 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28543/labels{/name} | https://api.github.com/repos/facebook/react/issues/28543/comments | https://api.github.com/repos/facebook/react/issues/28543/events | https://github.com/facebook/react/pull/28543 | 2,180,962,838 | PR_kwDOAJy2Ks5pV5re | 28,543 | fix: calling onblue event on unmount. | {'login': 'Liknox', 'id': 92331274, 'node_id': 'U_kgDOBYDdCg', 'avatar_url': 'https://avatars.githubusercontent.com/u/92331274?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Liknox', 'html_url': 'https://github.com/Liknox', 'followers_url': 'https://api.github.com/users/Liknox/followers', 'following_url': 'https://api.github.com/users/Liknox/following{/other_user}', 'gists_url': 'https://api.github.com/users/Liknox/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Liknox/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Liknox/subscriptions', 'organizations_url': 'https://api.github.com/users/Liknox/orgs', 'repos_url': 'https://api.github.com/users/Liknox/repos', 'events_url': 'https://api.github.com/users/Liknox/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Liknox/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 89021fb4ec9aa82194b0788566e736a4cedfc0e4...1949942fc670b390fc7597cf756d60102c5d99bf\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/1949942fc670b390fc7597cf756d60102c5d99bf/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=89021fb4ec9aa82194b0788566e736a4cedfc0e4) | **+0.06%** | 176.71 kB | 176.81 kB | +0.08% | 54.89 kB | 54.93 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/1949942fc670b390fc7597cf756d60102c5d99bf/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=89021fb4ec9aa82194b0788566e736a4cedfc0e4) | **+0.06%** | 177.25 kB | 177.35 kB | +0.07% | 55.25 kB | 55.29 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/1949942fc670b390fc7597cf756d60102c5d99bf/files/facebook-www/ReactDOM-prod.classic.js?compare=89021fb4ec9aa82194b0788566e736a4cedfc0e4) | **+0.02%** | 592.84 kB | 592.98 kB | +0.06% | 104.15 kB | 104.21 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/1949942fc670b390fc7597cf756d60102c5d99bf/files/facebook-www/ReactDOM-prod.modern.js?compare=89021fb4ec9aa82194b0788566e736a4cedfc0e4) | **+0.03%** | 576.10 kB | 576.24 kB | +0.05% | 101.21 kB | 101.25 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/1949942fc670b390fc7597cf756d60102c5d99bf/files/__test_utils__/ReactAllWarnings.js?compare=89021fb4ec9aa82194b0788566e736a4cedfc0e4) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/1949942fc670b390fc7597cf756d60102c5d99bf/files/__test_utils__/ReactAllWarnings.js?compare=89021fb4ec9aa82194b0788566e736a4cedfc0e4) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 1949942fc670b390fc7597cf756d60102c5d99bf\n</p>\n"
] | 2024-03-12 07:58:34 | 2024-03-12 23:13:37 | 2024-03-12 23:13:37 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28543', 'html_url': 'https://github.com/facebook/react/pull/28543', 'diff_url': 'https://github.com/facebook/react/pull/28543.diff', 'patch_url': 'https://github.com/facebook/react/pull/28543.patch', 'merged_at': None} | Working wit React, there was a small bug i discovered, related to unmounting off a particular element in the DOM, in vanilla JS whenever a particular item gets removed from the DOM, an onBlur event is triggered automatically, as said in MDN.
React simply does not seem to call this onBlur event when a particular element is unmounted, i might be wrong to judge why the same wasn't implemented in the context of react, anyways this would mean a learning opportunity for me to understand react design principles more better.
here is a Vanilla Js repro of the onBlur being called.
This Behaviour falls under the category where React and Vanilla JS act differently , earlier i raised https://github.com/facebook/react/pull/27016 , reviewed by sophie , which concluded to refer away from custom event logic as of now, as the future of react seems to get rid of React event system logic and rely on browser event system. | {'url': 'https://api.github.com/repos/facebook/react/issues/28543/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28543/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28542 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28542/labels{/name} | https://api.github.com/repos/facebook/react/issues/28542/comments | https://api.github.com/repos/facebook/react/issues/28542/events | https://github.com/facebook/react/issues/28542 | 2,180,910,684 | I_kwDOAJy2Ks6B_g5c | 28,542 | Fix gap between footer logo and links | {'login': 'amanr-dev', 'id': 124811276, 'node_id': 'U_kgDOB3B4DA', 'avatar_url': 'https://avatars.githubusercontent.com/u/124811276?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/amanr-dev', 'html_url': 'https://github.com/amanr-dev', 'followers_url': 'https://api.github.com/users/amanr-dev/followers', 'following_url': 'https://api.github.com/users/amanr-dev/following{/other_user}', 'gists_url': 'https://api.github.com/users/amanr-dev/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/amanr-dev/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/amanr-dev/subscriptions', 'organizations_url': 'https://api.github.com/users/amanr-dev/orgs', 'repos_url': 'https://api.github.com/users/amanr-dev/repos', 'events_url': 'https://api.github.com/users/amanr-dev/events{/privacy}', 'received_events_url': 'https://api.github.com/users/amanr-dev/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Is that site on GitHub?\r\n",
"issue : #28542\r\nCan you assign this to me?\r\nCan you help me , I know what is the problem and I can resolve but I don't know how to start?Should I clone the file first?\r\n",
"Hey @amanr-dev, I was checking and i saw everything alright. I checked on a few resolutions and all seems to be fine. Could you provide more information to replicate that UI error ?",
"Hey @amanr-dev, I checked both `react.dev/learn` & `react.dev/community` on all resolutions and everything seems to be fine.",
"I'm proficient with this,Can you assign it to me",
"@Harshit1723 the resolution was that this issue isn't reproducible on other devices. Can you reproduce this issue on your device? If so, please open a new issue with instructions for how to repro.\r\n\r\nThanks!",
"Could you assign this issue to me? I can reproduce it on my device:\r\n\r\n<img width=\"1425\" alt=\"Screenshot 2024-03-20 at 09 49 17\" src=\"https://github.com/facebook/react/assets/106407013/8ce1b164-5ac7-4717-ae38-4bc891b471fd\">\r\n\r\nI am using a Macbook.\r\n\r\nSteps to reproduce:\r\n\r\n- Open the website [link](https://react.dev/learn)\r\n- Scroll to the footer and you will see there is no space between the loge and the (link)[https://opensource.fb.com/]\r\n\r\n**Suggestion:**\r\n\r\nThe space between the logo and the link should look like this:\r\n\r\n<img width=\"434\" alt=\"image\" src=\"https://github.com/facebook/react/assets/106407013/52117d49-b7ad-487e-a657-d30bf11dcb56\">\r\n\r\nInstead of this:\r\n\r\n<img width=\"211\" alt=\"image\" src=\"https://github.com/facebook/react/assets/106407013/889efa33-ebf3-4c4f-aec1-07c7361d5456\">\r\n\r\n\r\n\r\n",
"@RitaDee, assigned to you",
"Thank you, @amanr-dev for assigning this issue to me.",
"@RitaDee I think you misunderstood the issue. The Meta Open Source logo is supposed to look like that (as seen on https://opensource.fb.com). I think the issue @amanr-dev was referring to was this one:\r\n\r\n\r\n\r\nThanks anyway though! ❤️",
"It seems fine ,which system are you using?i'm not getting this issue?",
"> one\r\n\r\nYes , you are right",
"> It seems fine ,which system are you using?i'm not getting this issue?\r\n\r\nMy device's screen size is `1519 × 742`",
"I think you should close this issue.",
"<img width=\"1186\" alt=\"Screenshot 2024-03-20 at 9 16 35 PM\" src=\"https://github.com/facebook/react/assets/159920447/83e65a85-5591-4ce3-add6-7adfe002f60f\">\r\nI checked this on my system but it is correctly aligned.",
"> Thank you, @amanr-dev for assigning this issue to me.\r\n\r\nHi @RitaDee, I think I should close this issue a second time. The reason is that the code for the website is not available in the Repository. \r\n"
] | 2024-03-12 07:23:53 | 2024-03-21 15:43:04 | 2024-03-21 15:43:04 | NONE | null | null | null | At the `react.dev/learn` & `react.dev/community` or any route add a gap between footer's `logo` and `links`
# screenshot
| {'url': 'https://api.github.com/repos/facebook/react/issues/28542/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 1, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28542/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28541 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28541/labels{/name} | https://api.github.com/repos/facebook/react/issues/28541/comments | https://api.github.com/repos/facebook/react/issues/28541/events | https://github.com/facebook/react/pull/28541 | 2,180,113,090 | PR_kwDOAJy2Ks5pTACU | 28,541 | ReactDOM: Remove every test-util except `act()` | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4cc0f8ee609068739308d03bac75b5d38f016f73...82e3562448dec7bc0319b9608563eac4f8ab41af\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 176.92 kB | 176.92 kB | = | 54.99 kB | 54.99 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 173.10 kB | 173.10 kB | = | 53.94 kB | 53.94 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/facebook-www/ReactDOM-prod.classic.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 592.31 kB | 592.31 kB | = | 103.83 kB | 103.83 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/facebook-www/ReactDOM-prod.modern.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 573.20 kB | 573.20 kB | = | 100.71 kB | 100.71 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 12.03 kB | 8.73 kB | = | 4.70 kB | 2.75 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 11.94 kB | 8.59 kB | = | 4.66 kB | 2.67 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 42.64 kB | 26.34 kB | = | 12.10 kB | 7.16 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/umd/react-dom-test-utils.development.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 47.41 kB | 28.06 kB | = | 13.09 kB | 7.34 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/cjs/react-dom-test-utils.development.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 44.63 kB | 26.38 kB | = | 12.87 kB | 7.19 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/__test_utils__/ReactAllWarnings.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **Deleted** | 65.07 kB | 0.00 kB | Deleted | 16.27 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 12.03 kB | 8.73 kB | = | 4.70 kB | 2.75 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 11.94 kB | 8.59 kB | = | 4.66 kB | 2.67 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 42.64 kB | 26.34 kB | = | 12.10 kB | 7.16 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/umd/react-dom-test-utils.development.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 47.41 kB | 28.06 kB | = | 13.09 kB | 7.34 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/oss-experimental/react-dom/cjs/react-dom-test-utils.development.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **=** | 44.63 kB | 26.38 kB | = | 12.87 kB | 7.19 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/82e3562448dec7bc0319b9608563eac4f8ab41af/files/__test_utils__/ReactAllWarnings.js?compare=4cc0f8ee609068739308d03bac75b5d38f016f73) | **Deleted** | 65.07 kB | 0.00 kB | Deleted | 16.27 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 82e3562448dec7bc0319b9608563eac4f8ab41af\n</p>\n",
"I looked into vendoring ReactTestUtils in WWW to avoiding needing additional gating here but it has too much internal usage for it to be stable. \r\n\r\nCan we apply either gating on the utils functions themselves or a build fork of the whole module? And additionally can we keep the ReactTestUtils-test with gating for www? Let me know if you want help with the additional work here.\r\n\r\nIdeally within a couple months we can fully remove.",
"> Can we apply either gating on the utils functions themselves or a build fork of the whole module?\r\n\r\nWe use special `.fb` entrypoints on other packages so I hope I can leverage these for test-utils and then just gate the tests behind `www`.",
"Didn't go with the special `.fb` entrypoint since that implies forking for modern, classic, experimental and stable. I used a simple feature flag instead like we do for `ReactDOM.render`"
] | 2024-03-11 20:04:24 | 2024-03-27 15:12:56 | 2024-03-27 15:04:56 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28541', 'html_url': 'https://github.com/facebook/react/pull/28541', 'diff_url': 'https://github.com/facebook/react/pull/28541.diff', 'patch_url': 'https://github.com/facebook/react/pull/28541.patch', 'merged_at': datetime.datetime(2024, 3, 27, 15, 4, 56)} | ## Summary
Removes every API from `react-dom/test-utils` except `act` in favor of using `@testing-library/react`. Removal is gated behind `disableDOMTestUtils` that's off for Meta builds.
The functions aren't removed but instead throw with a helpful error message. We're doing the same for `ReactDOM.render`.
Also reverts https://github.com/facebook/react/pull/28446 to restore test coverage.
Some APIs like `renderIntoDocument` are technically gated behind `disableDOMTestUtils` and `disableLegacyRoot`. We could just combine both flags to prevent drift.
## How did you test this change?
- `yarn test ReactTestUtils-test`
| {'url': 'https://api.github.com/repos/facebook/react/issues/28541/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28541/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28540 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28540/labels{/name} | https://api.github.com/repos/facebook/react/issues/28540/comments | https://api.github.com/repos/facebook/react/issues/28540/events | https://github.com/facebook/react/pull/28540 | 2,179,789,285 | PR_kwDOAJy2Ks5pR2-N | 28,540 | Export unstable_useMemoCache in experimental server runtime | {'login': 'gsathya', 'id': 565765, 'node_id': 'MDQ6VXNlcjU2NTc2NQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/565765?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gsathya', 'html_url': 'https://github.com/gsathya', 'followers_url': 'https://api.github.com/users/gsathya/followers', 'following_url': 'https://api.github.com/users/gsathya/following{/other_user}', 'gists_url': 'https://api.github.com/users/gsathya/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gsathya/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gsathya/subscriptions', 'organizations_url': 'https://api.github.com/users/gsathya/orgs', 'repos_url': 'https://api.github.com/users/gsathya/repos', 'events_url': 'https://api.github.com/users/gsathya/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gsathya/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: dfaed5582550f11b27aae967a8e7084202dd2d90...9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8/files/facebook-www/ReactDOM-prod.classic.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8/files/facebook-www/ReactDOM-prod.modern.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8/files/__test_utils__/ReactAllWarnings.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react/cjs/react.react-server.production.min.js](https://react-builds.vercel.app/commits/9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8/files/oss-experimental/react/cjs/react.react-server.production.min.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **+0.79%** | 9.62 kB | 9.70 kB | +0.21% | 3.84 kB | 3.85 kB\n| [oss-experimental/react/cjs/react.react-server.production.js](https://react-builds.vercel.app/commits/9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8/files/oss-experimental/react/cjs/react.react-server.production.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **+0.56%** | 39.92 kB | 40.14 kB | +0.39% | 11.80 kB | 11.84 kB\n| [oss-experimental/react/cjs/react.react-server.development.js](https://react-builds.vercel.app/commits/9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8/files/oss-experimental/react/cjs/react.react-server.development.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **+0.27%** | 82.27 kB | 82.49 kB | +0.20% | 23.13 kB | 23.17 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8/files/__test_utils__/ReactAllWarnings.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 9493aa7df0b276c1fee9aecd7d977d1fe5e5cdb8\n</p>\n",
"It doesn't actually do anything so compiling a server layer with Forget would actually be a regression and arguably a bug. It should ideally error early if you do that.",
"The same thing applies to Fizz in a way too btw since we're trying to replace the multi-pass renders there.",
"Previous discussion in https://github.com/facebook/react/pull/27829",
"> It doesn't actually do anything so compiling a server layer with Forget would actually be a regression and arguably a bug. It should ideally error early if you do that.\r\n\r\n@sebmarkbage is there a reliable way to know if the compiler is trying to compile a server component (and therefore bail out of it?)",
"It varies by environment but since Server Components needs to compile in a separate layer of the bundler with a different set of compilers/plugins, you would typically simply exclude Forget from the compilation there.",
"> It doesn't actually do anything so compiling a server layer with Forget would actually be a regression and arguably a bug. It should ideally error early if you do that.\r\n\r\nThat makes sense but we've got potential optimisations planned that could help server components. I guess we could turn it on then, but maybe the safe default now is to run the compiler always but not do any memoization for server components?"
] | 2024-03-11 17:45:53 | 2024-03-13 15:28:36 | 2024-03-13 15:03:17 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28540', 'html_url': 'https://github.com/facebook/react/pull/28540', 'diff_url': 'https://github.com/facebook/react/pull/28540.diff', 'patch_url': 'https://github.com/facebook/react/pull/28540.patch', 'merged_at': None} | Flight already has an implementation of useMemoCache:
https://github.com/facebook/react/blob/main/packages/react-server/src/ReactFlightHooks.js#L73-L79
This PR exports the existing hook. | {'url': 'https://api.github.com/repos/facebook/react/issues/28540/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28540/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28539 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28539/labels{/name} | https://api.github.com/repos/facebook/react/issues/28539/comments | https://api.github.com/repos/facebook/react/issues/28539/events | https://github.com/facebook/react/issues/28539 | 2,179,310,399 | I_kwDOAJy2Ks6B5aM_ | 28,539 | Bug: ESLint rule doesn't catch mistake with non-exhaustive dependencies | {'login': 'arendjr', 'id': 533294, 'node_id': 'MDQ6VXNlcjUzMzI5NA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/533294?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/arendjr', 'html_url': 'https://github.com/arendjr', 'followers_url': 'https://api.github.com/users/arendjr/followers', 'following_url': 'https://api.github.com/users/arendjr/following{/other_user}', 'gists_url': 'https://api.github.com/users/arendjr/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/arendjr/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/arendjr/subscriptions', 'organizations_url': 'https://api.github.com/users/arendjr/orgs', 'repos_url': 'https://api.github.com/users/arendjr/repos', 'events_url': 'https://api.github.com/users/arendjr/events{/privacy}', 'received_events_url': 'https://api.github.com/users/arendjr/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [] | 2024-03-11 14:40:57 | 2024-03-11 18:29:21 | null | NONE | null | null | null | React version: 18.2
## Steps To Reproduce
1. Use the `useState()` hook.
* For example: `const [count, setCount] = useState(0)`
2. Create a function that directly uses the setter.
* For example: `const inc: () => setCount((count) => count + 1)`
3. Witness how the function using the setter is not required to be listed as dependency, leading to soundness issues.
* For example:
```jsx
const incAndRemember = useCallback(() => {
inc();
setLast({ last: inc }); // We might be setting a stale reference here,
}, []); // because `inc` doesn't need to be specified here.
```
4. Behavior in other hooks will start to diverge from what was intended if we ever rely on the identity of the reference we set.
Link to code example: https://github.com/arendjr/react-unstable-handler
## The current behavior
When a function inside a component (only) uses a setter of a `useState()` hook, that function is determined to be "stable" (non-reactive) despite its identity being unstable. Because the ESLint rule assumes the function is stable, it doesn't require it to be listed in dependency arrays, which may lead to soundness issues with other hooks, such as witnessed in the linked repository.
It appears the current behavior is in violation of the documentation regarding reactive values (https://react.dev/learn/lifecycle-of-reactive-effects#all-variables-declared-in-the-component-body-are-reactive ), which says:
> **All values inside the component (including props, state, and variables in your component’s body) are reactive. Any reactive value can change on a re-render, so you need to include reactive values as Effect’s dependencies.**
## The expected behavior
Whether a function is considered stable or not should be strictly determined by its identity.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28539/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28539/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28538 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28538/labels{/name} | https://api.github.com/repos/facebook/react/issues/28538/comments | https://api.github.com/repos/facebook/react/issues/28538/events | https://github.com/facebook/react/pull/28538 | 2,179,251,937 | PR_kwDOAJy2Ks5pP_ZD | 28,538 | Land enableClientRenderFallbackOnTextMismatch for www | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlonii/followers', 'following_url': 'https://api.github.com/users/rickhanlonii/following{/other_user}', 'gists_url': 'https://api.github.com/users/rickhanlonii/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rickhanlonii/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rickhanlonii/subscriptions', 'organizations_url': 'https://api.github.com/users/rickhanlonii/orgs', 'repos_url': 'https://api.github.com/users/rickhanlonii/repos', 'events_url': 'https://api.github.com/users/rickhanlonii/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rickhanlonii/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: dfaed5582550f11b27aae967a8e7084202dd2d90...8af44976ff066f6e7dd10ce9449891c163f4359c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/8af44976ff066f6e7dd10ce9449891c163f4359c/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/8af44976ff066f6e7dd10ce9449891c163f4359c/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/8af44976ff066f6e7dd10ce9449891c163f4359c/files/facebook-www/ReactDOM-prod.classic.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **=** | 594.34 kB | 593.92 kB | = | 104.96 kB | 104.85 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/8af44976ff066f6e7dd10ce9449891c163f4359c/files/facebook-www/ReactDOM-prod.modern.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **=** | 577.60 kB | 577.18 kB | = | 102.02 kB | 101.91 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/8af44976ff066f6e7dd10ce9449891c163f4359c/files/__test_utils__/ReactAllWarnings.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/8af44976ff066f6e7dd10ce9449891c163f4359c/files/__test_utils__/ReactAllWarnings.js?compare=dfaed5582550f11b27aae967a8e7084202dd2d90) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8af44976ff066f6e7dd10ce9449891c163f4359c\n</p>\n"
] | 2024-03-11 14:17:44 | 2024-03-11 15:40:53 | 2024-03-11 15:40:48 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28538', 'html_url': 'https://github.com/facebook/react/pull/28538', 'diff_url': 'https://github.com/facebook/react/pull/28538.diff', 'patch_url': 'https://github.com/facebook/react/pull/28538.patch', 'merged_at': datetime.datetime(2024, 3, 11, 15, 40, 48)} | This is landed, we can hardcode the flag | {'url': 'https://api.github.com/repos/facebook/react/issues/28538/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28538/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28537 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28537/labels{/name} | https://api.github.com/repos/facebook/react/issues/28537/comments | https://api.github.com/repos/facebook/react/issues/28537/events | https://github.com/facebook/react/pull/28537 | 2,177,829,613 | PR_kwDOAJy2Ks5pLKeZ | 28,537 | Refactor React README.md | {'login': 'akileshjayakumar', 'id': 115217361, 'node_id': 'U_kgDOBt4T0Q', 'avatar_url': 'https://avatars.githubusercontent.com/u/115217361?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/akileshjayakumar', 'html_url': 'https://github.com/akileshjayakumar', 'followers_url': 'https://api.github.com/users/akileshjayakumar/followers', 'following_url': 'https://api.github.com/users/akileshjayakumar/following{/other_user}', 'gists_url': 'https://api.github.com/users/akileshjayakumar/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/akileshjayakumar/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/akileshjayakumar/subscriptions', 'organizations_url': 'https://api.github.com/users/akileshjayakumar/orgs', 'repos_url': 'https://api.github.com/users/akileshjayakumar/repos', 'events_url': 'https://api.github.com/users/akileshjayakumar/events{/privacy}', 'received_events_url': 'https://api.github.com/users/akileshjayakumar/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Hi @akileshjayakumar! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328537). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 706d95f486fbdec35b771ea4aaf3e78feb907249...01e742b019ce110907fcead5dd23e6c6f3e3484f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/01e742b019ce110907fcead5dd23e6c6f3e3484f/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/01e742b019ce110907fcead5dd23e6c6f3e3484f/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/01e742b019ce110907fcead5dd23e6c6f3e3484f/files/facebook-www/ReactDOM-prod.classic.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/01e742b019ce110907fcead5dd23e6c6f3e3484f/files/facebook-www/ReactDOM-prod.modern.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/01e742b019ce110907fcead5dd23e6c6f3e3484f/files/__test_utils__/ReactAllWarnings.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/01e742b019ce110907fcead5dd23e6c6f3e3484f/files/__test_utils__/ReactAllWarnings.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 01e742b019ce110907fcead5dd23e6c6f3e3484f\n</p>\n",
"Thanks! Unfortunately, we don't accept changes to the README because folks will bikeshed it with endless PRs."
] | 2024-03-10 17:57:59 | 2024-03-24 19:21:12 | 2024-03-24 15:44:53 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28537', 'html_url': 'https://github.com/facebook/react/pull/28537', 'diff_url': 'https://github.com/facebook/react/pull/28537.diff', 'patch_url': 'https://github.com/facebook/react/pull/28537.patch', 'merged_at': None} | Refactor React README.md | {'url': 'https://api.github.com/repos/facebook/react/issues/28537/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28537/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28536 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28536/labels{/name} | https://api.github.com/repos/facebook/react/issues/28536/comments | https://api.github.com/repos/facebook/react/issues/28536/events | https://github.com/facebook/react/pull/28536 | 2,177,700,555 | PR_kwDOAJy2Ks5pKwsq | 28,536 | Update README.md. Fixed typo in scripts/error-codes/README.md | {'login': 'Tianyou3', 'id': 150884120, 'node_id': 'U_kgDOCP5PGA', 'avatar_url': 'https://avatars.githubusercontent.com/u/150884120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Tianyou3', 'html_url': 'https://github.com/Tianyou3', 'followers_url': 'https://api.github.com/users/Tianyou3/followers', 'following_url': 'https://api.github.com/users/Tianyou3/following{/other_user}', 'gists_url': 'https://api.github.com/users/Tianyou3/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Tianyou3/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Tianyou3/subscriptions', 'organizations_url': 'https://api.github.com/users/Tianyou3/orgs', 'repos_url': 'https://api.github.com/users/Tianyou3/repos', 'events_url': 'https://api.github.com/users/Tianyou3/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Tianyou3/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @Tianyou3! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328536). Thanks!",
"CLA signed",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 706d95f486fbdec35b771ea4aaf3e78feb907249...b3a25d8e41d0e5613e897fd442146ef9821f3723\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/b3a25d8e41d0e5613e897fd442146ef9821f3723/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/b3a25d8e41d0e5613e897fd442146ef9821f3723/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/b3a25d8e41d0e5613e897fd442146ef9821f3723/files/facebook-www/ReactDOM-prod.classic.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/b3a25d8e41d0e5613e897fd442146ef9821f3723/files/facebook-www/ReactDOM-prod.modern.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/b3a25d8e41d0e5613e897fd442146ef9821f3723/files/__test_utils__/ReactAllWarnings.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/b3a25d8e41d0e5613e897fd442146ef9821f3723/files/__test_utils__/ReactAllWarnings.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b3a25d8e41d0e5613e897fd442146ef9821f3723\n</p>\n",
"Thanks, but we don't usually accept PRs that fix minor typos in comments because of the noise."
] | 2024-03-10 12:43:27 | 2024-03-24 15:45:51 | 2024-03-24 15:45:51 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28536', 'html_url': 'https://github.com/facebook/react/pull/28536', 'diff_url': 'https://github.com/facebook/react/pull/28536.diff', 'patch_url': 'https://github.com/facebook/react/pull/28536.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28536/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28536/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28535 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28535/labels{/name} | https://api.github.com/repos/facebook/react/issues/28535/comments | https://api.github.com/repos/facebook/react/issues/28535/events | https://github.com/facebook/react/pull/28535 | 2,177,628,652 | PR_kwDOAJy2Ks5pKjQ3 | 28,535 | Fix scroll event type | {'login': 'chirokas', 'id': 157580465, 'node_id': 'U_kgDOCWR8sQ', 'avatar_url': 'https://avatars.githubusercontent.com/u/157580465?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/chirokas', 'html_url': 'https://github.com/chirokas', 'followers_url': 'https://api.github.com/users/chirokas/followers', 'following_url': 'https://api.github.com/users/chirokas/following{/other_user}', 'gists_url': 'https://api.github.com/users/chirokas/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/chirokas/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/chirokas/subscriptions', 'organizations_url': 'https://api.github.com/users/chirokas/orgs', 'repos_url': 'https://api.github.com/users/chirokas/repos', 'events_url': 'https://api.github.com/users/chirokas/events{/privacy}', 'received_events_url': 'https://api.github.com/users/chirokas/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"Hi @chirokas! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328535). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 706d95f486fbdec35b771ea4aaf3e78feb907249...ec18c3e06a310c53d108d724952a94063ea74c30\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/ec18c3e06a310c53d108d724952a94063ea74c30/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 177.10 kB | 177.06 kB | = | 55.20 kB | 55.19 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/ec18c3e06a310c53d108d724952a94063ea74c30/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 177.64 kB | 177.60 kB | = | 55.53 kB | 55.54 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/ec18c3e06a310c53d108d724952a94063ea74c30/files/facebook-www/ReactDOM-prod.classic.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 594.34 kB | 594.20 kB | = | 104.96 kB | 104.95 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/ec18c3e06a310c53d108d724952a94063ea74c30/files/facebook-www/ReactDOM-prod.modern.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **=** | 577.60 kB | 577.46 kB | = | 102.02 kB | 101.99 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ec18c3e06a310c53d108d724952a94063ea74c30/files/__test_utils__/ReactAllWarnings.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ec18c3e06a310c53d108d724952a94063ea74c30/files/__test_utils__/ReactAllWarnings.js?compare=706d95f486fbdec35b771ea4aaf3e78feb907249) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ec18c3e06a310c53d108d724952a94063ea74c30\n</p>\n",
"If there are any problems, please guide me. Thanks! @rickhanlonii @kassens",
"This seems correct and I confirmed that at least in the simple case, we're setting `view` and `detail` on the event, which is always `undefined`: https://codesandbox.io/p/sandbox/romantic-babycat-77fgyp\r\n\r\nBut changing the event system has dragons so I'm not sure if this is a safe change, because it does change more than just the types."
] | 2024-03-10 09:44:13 | 2024-03-24 00:47:02 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28535', 'html_url': 'https://github.com/facebook/react/pull/28535', 'diff_url': 'https://github.com/facebook/react/pull/28535.diff', 'patch_url': 'https://github.com/facebook/react/pull/28535.patch', 'merged_at': None} | The scroll event type is Event, not UIEvent.
https://developer.mozilla.org/en-US/docs/Web/API/Element/scroll_event
https://drafts.csswg.org/cssom-view/#eventdef-document-scroll
https://github.com/facebook/react/blob/a4939017ffe2e04a94efca0f48b661bc778a6fa4/packages/react-dom-bindings/src/events/plugins/SimpleEventPlugin.js#L142-L144 | {'url': 'https://api.github.com/repos/facebook/react/issues/28535/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28535/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28534 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28534/labels{/name} | https://api.github.com/repos/facebook/react/issues/28534/comments | https://api.github.com/repos/facebook/react/issues/28534/events | https://github.com/facebook/react/pull/28534 | 2,177,216,856 | PR_kwDOAJy2Ks5pJQgz | 28,534 | Remove remaining usages of ReactTestUtils in tests unrelated to `react-dom/test-util` | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 850fac4915864a487e7cb9ecae8a75dbac144174...d9fa63a99b852ceff375ecaa7cc84ff17f30abe7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d9fa63a99b852ceff375ecaa7cc84ff17f30abe7/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d9fa63a99b852ceff375ecaa7cc84ff17f30abe7/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/d9fa63a99b852ceff375ecaa7cc84ff17f30abe7/files/facebook-www/ReactDOM-prod.classic.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/d9fa63a99b852ceff375ecaa7cc84ff17f30abe7/files/facebook-www/ReactDOM-prod.modern.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d9fa63a99b852ceff375ecaa7cc84ff17f30abe7/files/__test_utils__/ReactAllWarnings.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d9fa63a99b852ceff375ecaa7cc84ff17f30abe7/files/__test_utils__/ReactAllWarnings.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against d9fa63a99b852ceff375ecaa7cc84ff17f30abe7\n</p>\n"
] | 2024-03-09 12:57:36 | 2024-03-11 12:33:16 | 2024-03-11 12:27:04 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28534', 'html_url': 'https://github.com/facebook/react/pull/28534', 'diff_url': 'https://github.com/facebook/react/pull/28534.diff', 'patch_url': 'https://github.com/facebook/react/pull/28534.patch', 'merged_at': datetime.datetime(2024, 3, 11, 12, 27, 4)} | Batched the remaining usages since these were straight forward. Completes removal of `ReactTestUtils` from tests unrelated to `react-dom/test-util` together with:
- https://github.com/facebook/react/pull/28531
- https://github.com/facebook/react/pull/28532
- https://github.com/facebook/react/pull/28533 | {'url': 'https://api.github.com/repos/facebook/react/issues/28534/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28534/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28533 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28533/labels{/name} | https://api.github.com/repos/facebook/react/issues/28533/comments | https://api.github.com/repos/facebook/react/issues/28533/events | https://github.com/facebook/react/pull/28533 | 2,177,201,205 | PR_kwDOAJy2Ks5pJNbn | 28,533 | Remove ReactTestUtils from ReactBrowserEventEmitter-test | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 850fac4915864a487e7cb9ecae8a75dbac144174...a3429f63d465fa2f5a7efd4fbbd865c958f945c1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/a3429f63d465fa2f5a7efd4fbbd865c958f945c1/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/a3429f63d465fa2f5a7efd4fbbd865c958f945c1/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/a3429f63d465fa2f5a7efd4fbbd865c958f945c1/files/facebook-www/ReactDOM-prod.classic.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/a3429f63d465fa2f5a7efd4fbbd865c958f945c1/files/facebook-www/ReactDOM-prod.modern.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/a3429f63d465fa2f5a7efd4fbbd865c958f945c1/files/__test_utils__/ReactAllWarnings.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/a3429f63d465fa2f5a7efd4fbbd865c958f945c1/files/__test_utils__/ReactAllWarnings.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against a3429f63d465fa2f5a7efd4fbbd865c958f945c1\n</p>\n"
] | 2024-03-09 12:06:27 | 2024-03-11 21:12:01 | 2024-03-11 21:11:52 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28533', 'html_url': 'https://github.com/facebook/react/pull/28533', 'diff_url': 'https://github.com/facebook/react/pull/28533.diff', 'patch_url': 'https://github.com/facebook/react/pull/28533.patch', 'merged_at': datetime.datetime(2024, 3, 11, 21, 11, 52)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/28533/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28533/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28532 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28532/labels{/name} | https://api.github.com/repos/facebook/react/issues/28532/comments | https://api.github.com/repos/facebook/react/issues/28532/events | https://github.com/facebook/react/pull/28532 | 2,177,183,384 | PR_kwDOAJy2Ks5pJJ6z | 28,532 | Remove ReactTestUtils from refs-destruction-test | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 850fac4915864a487e7cb9ecae8a75dbac144174...b851dbfa7a5b5eea22f8dd73027037ae4dfb952f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/b851dbfa7a5b5eea22f8dd73027037ae4dfb952f/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/b851dbfa7a5b5eea22f8dd73027037ae4dfb952f/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/b851dbfa7a5b5eea22f8dd73027037ae4dfb952f/files/facebook-www/ReactDOM-prod.classic.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/b851dbfa7a5b5eea22f8dd73027037ae4dfb952f/files/facebook-www/ReactDOM-prod.modern.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/b851dbfa7a5b5eea22f8dd73027037ae4dfb952f/files/__test_utils__/ReactAllWarnings.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/b851dbfa7a5b5eea22f8dd73027037ae4dfb952f/files/__test_utils__/ReactAllWarnings.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b851dbfa7a5b5eea22f8dd73027037ae4dfb952f\n</p>\n"
] | 2024-03-09 11:07:57 | 2024-03-11 21:11:54 | 2024-03-11 21:11:40 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28532', 'html_url': 'https://github.com/facebook/react/pull/28532', 'diff_url': 'https://github.com/facebook/react/pull/28532.diff', 'patch_url': 'https://github.com/facebook/react/pull/28532.patch', 'merged_at': datetime.datetime(2024, 3, 11, 21, 11, 40)} | ```diff
-expect(ReactTestUtils.isDOMComponent(maybeElement)).toBe(true);
+expect(maybeElement).toBeInstanceOf(Element);
```
It's not equivalent since `isDOMComponent` checks `maybeElement.nodeType === Element.ELEMENT_NODE && !!maybeElement.tagName` but `instanceof` check seems sufficient here. Checking `nodeType` is mostly for cross-realm checks and checking falsy `tagName` seems like a check specifically for incomplete DOM implementations because tagName can't be empty by spec I believe. | {'url': 'https://api.github.com/repos/facebook/react/issues/28532/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28532/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28531 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28531/labels{/name} | https://api.github.com/repos/facebook/react/issues/28531/comments | https://api.github.com/repos/facebook/react/issues/28531/events | https://github.com/facebook/react/pull/28531 | 2,177,179,518 | PR_kwDOAJy2Ks5pJJJa | 28,531 | Remove ReactTestUtils from ReactLegacyUpdates-test | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 850fac4915864a487e7cb9ecae8a75dbac144174...41b703247550069e6a53ab9e68bc4de0296e484f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/41b703247550069e6a53ab9e68bc4de0296e484f/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/41b703247550069e6a53ab9e68bc4de0296e484f/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/41b703247550069e6a53ab9e68bc4de0296e484f/files/facebook-www/ReactDOM-prod.classic.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/41b703247550069e6a53ab9e68bc4de0296e484f/files/facebook-www/ReactDOM-prod.modern.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/41b703247550069e6a53ab9e68bc4de0296e484f/files/__test_utils__/ReactAllWarnings.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/41b703247550069e6a53ab9e68bc4de0296e484f/files/__test_utils__/ReactAllWarnings.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 41b703247550069e6a53ab9e68bc4de0296e484f\n</p>\n"
] | 2024-03-09 10:55:35 | 2024-03-11 21:11:44 | 2024-03-11 21:11:31 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28531', 'html_url': 'https://github.com/facebook/react/pull/28531', 'diff_url': 'https://github.com/facebook/react/pull/28531.diff', 'patch_url': 'https://github.com/facebook/react/pull/28531.patch', 'merged_at': datetime.datetime(2024, 3, 11, 21, 11, 31)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/28531/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28531/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28530 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28530/labels{/name} | https://api.github.com/repos/facebook/react/issues/28530/comments | https://api.github.com/repos/facebook/react/issues/28530/events | https://github.com/facebook/react/issues/28530 | 2,177,030,416 | I_kwDOAJy2Ks6BwtkQ | 28,530 | Bug: | {'login': 'Aliqateebah', 'id': 109043364, 'node_id': 'U_kgDOBn_epA', 'avatar_url': 'https://avatars.githubusercontent.com/u/109043364?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Aliqateebah', 'html_url': 'https://github.com/Aliqateebah', 'followers_url': 'https://api.github.com/users/Aliqateebah/followers', 'following_url': 'https://api.github.com/users/Aliqateebah/following{/other_user}', 'gists_url': 'https://api.github.com/users/Aliqateebah/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Aliqateebah/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Aliqateebah/subscriptions', 'organizations_url': 'https://api.github.com/users/Aliqateebah/orgs', 'repos_url': 'https://api.github.com/users/Aliqateebah/repos', 'events_url': 'https://api.github.com/users/Aliqateebah/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Aliqateebah/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2024-03-09 03:27:00 | 2024-03-09 10:28:52 | 2024-03-09 10:28:52 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
## The expected behavior | {'url': 'https://api.github.com/repos/facebook/react/issues/28530/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 1, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28530/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28529 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28529/labels{/name} | https://api.github.com/repos/facebook/react/issues/28529/comments | https://api.github.com/repos/facebook/react/issues/28529/events | https://github.com/facebook/react/issues/28529 | 2,176,917,723 | I_kwDOAJy2Ks6BwSDb | 28,529 | Bug: error boundary does not catch exceptions from 'true' branch of an if-statement | {'login': 'overwriter', 'id': 58150390, 'node_id': 'MDQ6VXNlcjU4MTUwMzkw', 'avatar_url': 'https://avatars.githubusercontent.com/u/58150390?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/overwriter', 'html_url': 'https://github.com/overwriter', 'followers_url': 'https://api.github.com/users/overwriter/followers', 'following_url': 'https://api.github.com/users/overwriter/following{/other_user}', 'gists_url': 'https://api.github.com/users/overwriter/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/overwriter/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/overwriter/subscriptions', 'organizations_url': 'https://api.github.com/users/overwriter/orgs', 'repos_url': 'https://api.github.com/users/overwriter/repos', 'events_url': 'https://api.github.com/users/overwriter/events{/privacy}', 'received_events_url': 'https://api.github.com/users/overwriter/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [] | 2024-03-08 23:25:15 | 2024-03-08 23:25:15 | null | NONE | null | null | null | When wrapping a standard-implementation error boundary around a component, as per [https://react.dev/reference/react/Component#catching-rendering-errors-with-an-error-boundary](https://react.dev/reference/react/Component#catching-rendering-errors-with-an-error-boundary), and the wrapped component throws an exception from within an if-statement's conditional branch, it weirdly only catches the exceptions thrown on the `false` branch, but ignores those on the `true` branch.
React version: 18.2.0
## Steps To Reproduce
1. See the code example (also available in the TS playground link below)
2. See the instructions in the comments of the code example
```typescript
import { FunctionComponent, useEffect, useRef, useState } from "react";
const Weird: FunctionComponent = () => {
const [version, setVersion] = useState<number>(0);
const renderCount = useRef<number>(0);
const condition = useRef<number>(0);
console.info(`renderCount=${renderCount.current++}, version=${version}, condition=${condition.current}`);
useEffect(() => {
const id: NodeJS.Timeout = setTimeout(() => setVersion(i => i + 1), 1_000);
return () => clearTimeout(id);
}, []);
// How to test this example:
// 1. run the code and observe that it works as expected: the error boundary catches the exception
// 2. change 'errorBoundaryCatchesError' to 'false'
// 3. comment throwing line marked with "scenario a" below
// 4. uncomment the throwing line marked with "scenario b" below
// 5. run the code again to observe that the exception does not get caught by the error boundary anymore
const errorBoundaryCatchesError: boolean = true;
if (version === 1) {
const testCondition: number = errorBoundaryCatchesError ? 1 : 0;
if (condition.current++ === testCondition) {
// scenario b - true branch
// throw new Error("ignored error");
} else {
// scenario a - false branch
throw new Error("caught error");
}
}
return <div>Hello</div>;
}
export default Weird;
```
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example: [Typescript Playground](https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgMQK4DsDGNgXQYQnDwFN0YAaOVAZxIFEAzRk7K2kgJRMfboGUYAQxgk4AXziMoROACIoJIdjkBuAFDrMeGvADqJYFAAmALhQZsuAkUjoy8ALxwAFAEo4jgHyJ1cf3Da6LpwANoAbiRQNNZUdDAAalExeAC6ntQCwqIAPOioIABGUV4uAAxuGgGBOvCK6MZRhBhOmVw8eQXFUKUVVQFBIUHGwDh4GRzcjJ1FJeWVmtWDEAA2JAB0wOiMEC4ABvWNUM3kjgAkCIdNEC3rmKhQ9TAA1M-iVJHR1ucInyno7xqDVG3wuwxBeDuDye4j2Cz8AQ4TBY2Bc7k8PgQCOq-kG8GAZjgADkII0AFL8dYAFVAJBurXiNJAdNQMDRHm8cHiSS+eBcwAxcAFzzgAEY3FRRQB9MqyhY4gKKGAPdCuDk+TBrIRQJkstkE+UBQGhVLw6oAenNcAAEhAAO5wGAQR0kEIwAAWwBocBIAA8hOA1qZsXBLWL1nAoBhHe6xNpGnAhA04BBCnQoJEYyIhfA7dAANbeoTev1gViiQkesRRGRQOCFG4NbUAT0CIkwse9VZ9vswJDAY3QIbDACYIx2kwBzMQAchr0AAQo3jC38O3O-RHtAZ47nTPGEIVnQZ8OrQBmcdEZnkGMyO1bSdwFZbMQgbX5kjGOD3j3yGh99BtVwRM5HrEgVntU84AAFgjSwrwcGMxA9O8HyfF84DfKAPy-H93T-ACgOdQpQOKCC7SggBWCMo1Vbt4zEIRJyELZdxTNMokzD1s27P0+wHaw4GMCBXTgdAIHgad4EwIRUEnd14EKVteK3OsGwwFcoFbJNmxAaASBDPEfVUpcNNXddXU3WtzAbVYlFVZwYCjEgNBDYBGFcP5BMcHyxQ8LEFVxWoXV0QhgUHcx8lmOtnHnKBTKbLS1xgDtLNUuAAH4xTgcwyn6BV3NccFByhR4HFeTxfNEUK8BGQd-JDQLQytf8yCI+s4AAWkdZz6ygJMO0awKwxQ+0xJIB0rOgFw5GASdxMUL84rkQ0FUkcC6F8JqLRawioGAoQuqkQ9NsKfqsHdIaFVGh17Em1SZpkuSFOM2sVvynFxBDL6QyVFU4ByEZwi8a1wIgnJzSBrwNB+0toHgRoD1QFZ9EMExVCAA)
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
When the above function component, `Weird`, is wrapped into a standard-implementation error boundary, like this:
```typescript
<ErrorBoundary>
<Weird />
</ErrorBoundary>
```
...the exception thrown in the component only gets caught by the error boundary if it is thrown from the `false` branch of the if-statement, but not if thrown on the `true` branch.
## The expected behavior
Independently on which branch the exception is thrown from, it should get caught in both cases. | {'url': 'https://api.github.com/repos/facebook/react/issues/28529/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28529/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28528 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28528/labels{/name} | https://api.github.com/repos/facebook/react/issues/28528/comments | https://api.github.com/repos/facebook/react/issues/28528/events | https://github.com/facebook/react/pull/28528 | 2,176,612,452 | PR_kwDOAJy2Ks5pHPAE | 28,528 | Upgrade flow to 0.230.0 | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 338dddc089d5865761219f02b5175db85c54c489...306aafd373367479d4647a31c40080f77e25c280\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/306aafd373367479d4647a31c40080f77e25c280/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/306aafd373367479d4647a31c40080f77e25c280/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/306aafd373367479d4647a31c40080f77e25c280/files/facebook-www/ReactDOM-prod.classic.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/306aafd373367479d4647a31c40080f77e25c280/files/facebook-www/ReactDOM-prod.modern.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/306aafd373367479d4647a31c40080f77e25c280/files/__test_utils__/ReactAllWarnings.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/306aafd373367479d4647a31c40080f77e25c280/files/__test_utils__/ReactAllWarnings.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 306aafd373367479d4647a31c40080f77e25c280\n</p>\n"
] | 2024-03-08 19:02:08 | 2024-03-08 22:39:36 | 2024-03-08 22:39:27 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28528', 'html_url': 'https://github.com/facebook/react/pull/28528', 'diff_url': 'https://github.com/facebook/react/pull/28528.diff', 'patch_url': 'https://github.com/facebook/react/pull/28528.patch', 'merged_at': datetime.datetime(2024, 3, 8, 22, 39, 27)} | Upgrade flow to 0.230.0
Ran
```
yarn add -W flow-bin flow-remove-types hermes-parser hermes-eslint
```
| {'url': 'https://api.github.com/repos/facebook/react/issues/28528/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28528/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28527 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28527/labels{/name} | https://api.github.com/repos/facebook/react/issues/28527/comments | https://api.github.com/repos/facebook/react/issues/28527/events | https://github.com/facebook/react/pull/28527 | 2,176,477,358 | PR_kwDOAJy2Ks5pGxNg | 28,527 | Configure Dynamic Feature Flags for React Native | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'following_url': 'https://api.github.com/users/yungsters/following{/other_user}', 'gists_url': 'https://api.github.com/users/yungsters/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/yungsters/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/yungsters/subscriptions', 'organizations_url': 'https://api.github.com/users/yungsters/orgs', 'repos_url': 'https://api.github.com/users/yungsters/repos', 'events_url': 'https://api.github.com/users/yungsters/events{/privacy}', 'received_events_url': 'https://api.github.com/users/yungsters/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4e2fe10fa388d499ba20a2821c9ddb1a6b129320...dbeba02d6e3cf769efe771b1abc45c0b0a615e2b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-www/ReactDOM-prod.classic.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-www/ReactDOM-prod.modern.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [facebook-react-native/react-is/cjs/ReactIs-prod.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react-is/cjs/ReactIs-prod.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+13.26%** | 4.64 kB | 5.26 kB | +11.21% | 1.14 kB | 1.27 kB\n| [facebook-react-native/react-is/cjs/ReactIs-profiling.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react-is/cjs/ReactIs-profiling.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+13.26%** | 4.64 kB | 5.26 kB | +11.21% | 1.14 kB | 1.27 kB\n| [facebook-react-native/react-is/cjs/ReactIs-dev.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react-is/cjs/ReactIs-dev.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+10.82%** | 7.26 kB | 8.05 kB | +9.51% | 1.83 kB | 2.00 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react/cjs/React-prod.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+5.60%** | 19.07 kB | 20.14 kB | +4.52% | 4.85 kB | 5.07 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react/cjs/React-profiling.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+5.56%** | 19.22 kB | 20.29 kB | +4.52% | 4.86 kB | 5.08 kB\n| [react-native/implementations/ReactFabric-prod.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactFabric-prod.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+4.70%** | 350.31 kB | 366.79 kB | +4.46% | 61.96 kB | 64.73 kB\n| [react-native/implementations/ReactNativeRenderer-prod.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactNativeRenderer-prod.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+4.60%** | 357.76 kB | 374.20 kB | +4.30% | 63.29 kB | 66.01 kB\n| [react-native/implementations/ReactFabric-profiling.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactFabric-profiling.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+4.36%** | 377.61 kB | 394.08 kB | +4.22% | 66.21 kB | 69.01 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactNativeRenderer-profiling.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+4.28%** | 385.08 kB | 401.56 kB | +4.11% | 67.52 kB | 70.29 kB\n| [react-native/implementations/ReactFabric-dev.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactFabric-dev.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+3.85%** | 1,049.29 kB | 1,089.72 kB | +3.46% | 210.41 kB | 217.70 kB\n| [react-native/implementations/ReactNativeRenderer-dev.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactNativeRenderer-dev.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+3.80%** | 1,063.89 kB | 1,104.29 kB | +3.43% | 214.21 kB | 221.55 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/__test_utils__/ReactAllWarnings.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [facebook-react-native/react-is/cjs/ReactIs-prod.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react-is/cjs/ReactIs-prod.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+13.26%** | 4.64 kB | 5.26 kB | +11.21% | 1.14 kB | 1.27 kB\n| [facebook-react-native/react-is/cjs/ReactIs-profiling.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react-is/cjs/ReactIs-profiling.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+13.26%** | 4.64 kB | 5.26 kB | +11.21% | 1.14 kB | 1.27 kB\n| [facebook-react-native/react-is/cjs/ReactIs-dev.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react-is/cjs/ReactIs-dev.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+10.82%** | 7.26 kB | 8.05 kB | +9.51% | 1.83 kB | 2.00 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react/cjs/React-prod.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+5.60%** | 19.07 kB | 20.14 kB | +4.52% | 4.85 kB | 5.07 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react/cjs/React-profiling.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+5.56%** | 19.22 kB | 20.29 kB | +4.52% | 4.86 kB | 5.08 kB\n| [react-native/implementations/ReactFabric-prod.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactFabric-prod.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+4.70%** | 350.31 kB | 366.79 kB | +4.46% | 61.96 kB | 64.73 kB\n| [react-native/implementations/ReactNativeRenderer-prod.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactNativeRenderer-prod.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+4.60%** | 357.76 kB | 374.20 kB | +4.30% | 63.29 kB | 66.01 kB\n| [react-native/implementations/ReactFabric-profiling.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactFabric-profiling.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+4.36%** | 377.61 kB | 394.08 kB | +4.22% | 66.21 kB | 69.01 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactNativeRenderer-profiling.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+4.28%** | 385.08 kB | 401.56 kB | +4.11% | 67.52 kB | 70.29 kB\n| [react-native/implementations/ReactFabric-dev.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactFabric-dev.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+3.85%** | 1,049.29 kB | 1,089.72 kB | +3.46% | 210.41 kB | 217.70 kB\n| [react-native/implementations/ReactNativeRenderer-dev.fb.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/react-native/implementations/ReactNativeRenderer-dev.fb.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+3.80%** | 1,063.89 kB | 1,104.29 kB | +3.43% | 214.21 kB | 221.55 kB\n| [facebook-react-native/react/cjs/React-dev.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react/cjs/React-dev.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+1.26%** | 122.11 kB | 123.65 kB | +0.82% | 29.30 kB | 29.54 kB\n| [facebook-react-native/react/cjs/JSXDEVRuntime-dev.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react/cjs/JSXDEVRuntime-dev.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+1.00%** | 47.80 kB | 48.28 kB | +0.44% | 12.70 kB | 12.76 kB\n| [facebook-react-native/react/cjs/JSXRuntime-dev.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/facebook-react-native/react/cjs/JSXRuntime-dev.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **+0.98%** | 49.21 kB | 49.69 kB | +0.44% | 13.07 kB | 13.13 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/dbeba02d6e3cf769efe771b1abc45c0b0a615e2b/files/__test_utils__/ReactAllWarnings.js?compare=4e2fe10fa388d499ba20a2821c9ddb1a6b129320) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against dbeba02d6e3cf769efe771b1abc45c0b0a615e2b\n</p>\n"
] | 2024-03-08 17:31:38 | 2024-03-09 00:14:14 | 2024-03-09 00:14:09 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28527', 'html_url': 'https://github.com/facebook/react/pull/28527', 'diff_url': 'https://github.com/facebook/react/pull/28527.diff', 'patch_url': 'https://github.com/facebook/react/pull/28527.patch', 'merged_at': datetime.datetime(2024, 3, 9, 0, 14, 9)} | ## Summary
This PR is a subset of https://github.com/facebook/react/pull/28425, which only includes the feature flags that will be configured as dynamic.
The following list summarizes the feature flag changes:
* RN FB
* Change to Dynamic
* consoleManagedByDevToolsDuringStrictMode
* enableAsyncActions
* enableDeferRootSchedulingToMicrotask
* enableRenderableContext
* useModernStrictMode
## How did you test this change?
Ran the following successfully:
```
$ yarn test
$ yarn flow native
$ yarn flow fabric
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28527/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28527/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28526 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28526/labels{/name} | https://api.github.com/repos/facebook/react/issues/28526/comments | https://api.github.com/repos/facebook/react/issues/28526/events | https://github.com/facebook/react/pull/28526 | 2,176,394,823 | PR_kwDOAJy2Ks5pGfOZ | 28,526 | Remove renderSubtreeIntoContainer_DO_NOT_USE | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 338dddc089d5865761219f02b5175db85c54c489...b7cde9e5916b0e5963262552b9c276f44c5c6f46\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/b7cde9e5916b0e5963262552b9c276f44c5c6f46/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/b7cde9e5916b0e5963262552b9c276f44c5c6f46/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/b7cde9e5916b0e5963262552b9c276f44c5c6f46/files/facebook-www/ReactDOM-prod.classic.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/b7cde9e5916b0e5963262552b9c276f44c5c6f46/files/facebook-www/ReactDOM-prod.modern.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/b7cde9e5916b0e5963262552b9c276f44c5c6f46/files/__test_utils__/ReactAllWarnings.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n| [facebook-www/shims/renderSubtreeIntoContainer_DO_NOT_USE.js](https://react-builds.vercel.app/commits/b7cde9e5916b0e5963262552b9c276f44c5c6f46/files/facebook-www/shims/renderSubtreeIntoContainer_DO_NOT_USE.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **Deleted** | 0.31 kB | 0.00 kB | Deleted | 0.23 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/b7cde9e5916b0e5963262552b9c276f44c5c6f46/files/__test_utils__/ReactAllWarnings.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n| [facebook-www/shims/renderSubtreeIntoContainer_DO_NOT_USE.js](https://react-builds.vercel.app/commits/b7cde9e5916b0e5963262552b9c276f44c5c6f46/files/facebook-www/shims/renderSubtreeIntoContainer_DO_NOT_USE.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **Deleted** | 0.31 kB | 0.00 kB | Deleted | 0.23 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b7cde9e5916b0e5963262552b9c276f44c5c6f46\n</p>\n"
] | 2024-03-08 16:42:22 | 2024-03-12 15:31:40 | 2024-03-12 15:31:34 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28526', 'html_url': 'https://github.com/facebook/react/pull/28526', 'diff_url': 'https://github.com/facebook/react/pull/28526.diff', 'patch_url': 'https://github.com/facebook/react/pull/28526.patch', 'merged_at': datetime.datetime(2024, 3, 12, 15, 31, 34)} | Once D54648741 lands internally, we no longer need this shim.
NOTE: There is still some work left to remove the `unstable_renderSubtreeIntoContainer` export. | {'url': 'https://api.github.com/repos/facebook/react/issues/28526/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28526/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28525 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28525/labels{/name} | https://api.github.com/repos/facebook/react/issues/28525/comments | https://api.github.com/repos/facebook/react/issues/28525/events | https://github.com/facebook/react/pull/28525 | 2,175,330,613 | PR_kwDOAJy2Ks5pC1nX | 28,525 | fix: typo | {'login': 'testwill', 'id': 8717479, 'node_id': 'MDQ6VXNlcjg3MTc0Nzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8717479?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/testwill', 'html_url': 'https://github.com/testwill', 'followers_url': 'https://api.github.com/users/testwill/followers', 'following_url': 'https://api.github.com/users/testwill/following{/other_user}', 'gists_url': 'https://api.github.com/users/testwill/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/testwill/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/testwill/subscriptions', 'organizations_url': 'https://api.github.com/users/testwill/orgs', 'repos_url': 'https://api.github.com/users/testwill/repos', 'events_url': 'https://api.github.com/users/testwill/events{/privacy}', 'received_events_url': 'https://api.github.com/users/testwill/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Thanks but we don't generally merge small typo fixes.",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 338dddc089d5865761219f02b5175db85c54c489...49ec8337e73145c4701d02411578648e2b83f816\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/49ec8337e73145c4701d02411578648e2b83f816/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/49ec8337e73145c4701d02411578648e2b83f816/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/49ec8337e73145c4701d02411578648e2b83f816/files/facebook-www/ReactDOM-prod.classic.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/49ec8337e73145c4701d02411578648e2b83f816/files/facebook-www/ReactDOM-prod.modern.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/49ec8337e73145c4701d02411578648e2b83f816/files/__test_utils__/ReactAllWarnings.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/49ec8337e73145c4701d02411578648e2b83f816/files/__test_utils__/ReactAllWarnings.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 49ec8337e73145c4701d02411578648e2b83f816\n</p>\n"
] | 2024-03-08 05:54:33 | 2024-03-08 05:58:54 | 2024-03-08 05:57:12 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28525', 'html_url': 'https://github.com/facebook/react/pull/28525', 'diff_url': 'https://github.com/facebook/react/pull/28525.diff', 'patch_url': 'https://github.com/facebook/react/pull/28525.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28525/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28525/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28524 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28524/labels{/name} | https://api.github.com/repos/facebook/react/issues/28524/comments | https://api.github.com/repos/facebook/react/issues/28524/events | https://github.com/facebook/react/pull/28524 | 2,175,321,781 | PR_kwDOAJy2Ks5pCzwv | 28,524 | [joke] its not fine | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlonii/followers', 'following_url': 'https://api.github.com/users/rickhanlonii/following{/other_user}', 'gists_url': 'https://api.github.com/users/rickhanlonii/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rickhanlonii/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rickhanlonii/subscriptions', 'organizations_url': 'https://api.github.com/users/rickhanlonii/orgs', 'repos_url': 'https://api.github.com/users/rickhanlonii/repos', 'events_url': 'https://api.github.com/users/rickhanlonii/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rickhanlonii/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 64f354cf27a17c4e5b0dfcd908e47940cf947771...294322c0c448ed0f0de9347b456578d2040a6608\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/facebook-www/ReactDOM-prod.classic.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/facebook-www/ReactDOM-prod.modern.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/__test_utils__/ReactAllWarnings.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable-semver/react/cjs/react.development.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/oss-stable-semver/react/cjs/react.development.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **+0.30%** | 98.43 kB | 98.72 kB | +0.44% | 26.52 kB | 26.63 kB\n| [oss-stable/react/cjs/react.development.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/oss-stable/react/cjs/react.development.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **+0.30%** | 98.46 kB | 98.75 kB | +0.44% | 26.55 kB | 26.66 kB\n| [facebook-react-native/react/cjs/React-dev.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/facebook-react-native/react/cjs/React-dev.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **+0.29%** | 122.04 kB | 122.39 kB | +0.46% | 29.29 kB | 29.42 kB\n| [oss-experimental/react/cjs/react.development.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/oss-experimental/react/cjs/react.development.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **+0.29%** | 101.07 kB | 101.37 kB | +0.42% | 27.38 kB | 27.50 kB\n| [facebook-www/React-dev.modern.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/facebook-www/React-dev.modern.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **+0.29%** | 124.16 kB | 124.52 kB | +0.41% | 29.56 kB | 29.68 kB\n| [facebook-www/React-dev.classic.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/facebook-www/React-dev.classic.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **+0.28%** | 125.75 kB | 126.10 kB | +0.37% | 29.94 kB | 30.05 kB\n| [oss-stable-semver/react/umd/react.development.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/oss-stable-semver/react/umd/react.development.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **+0.26%** | 121.02 kB | 121.33 kB | +0.39% | 31.09 kB | 31.21 kB\n| [oss-stable/react/umd/react.development.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/oss-stable/react/umd/react.development.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **+0.26%** | 121.04 kB | 121.36 kB | +0.39% | 31.11 kB | 31.23 kB\n| [oss-experimental/react/umd/react.development.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/oss-experimental/react/umd/react.development.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **+0.25%** | 123.76 kB | 124.07 kB | +0.37% | 31.99 kB | 32.11 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/294322c0c448ed0f0de9347b456578d2040a6608/files/__test_utils__/ReactAllWarnings.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 294322c0c448ed0f0de9347b456578d2040a6608\n</p>\n",
"What would be needed to enable cross-renderer contexts instead?",
"What if it’s installed globally?",
"@markerikson this is a cheeky joke. Obviously we wouldn't land this. \r\n\r\nThe issue to track that feature request is still https://github.com/facebook/react/issues/13332. It's unclear how to implement support for that feature, but we've been talking to @drcmda about options for third-party renderers. When we have more info, we'll update the issue.",
"Spent some time investigating. Regardless the versions would have to be in perfect lock-step but that turns out to be a requirement anyway so that's fine.\r\n\r\nThe proper solution that behaves like a Portal should forward the value during a concurrent render into the child. Meaning it should actually be part of the same render phase. That's not just an issue with Context but Props too. Ideally it shouldn't have to commit the outer root before forwarding the inner values.\r\n\r\nAdditionally, it's not just Context that is contextual. There's internal contexts and for example if you Suspend in the child renderer outside a Suspense boundary, it should affect the parent render. E.g. a startTransition in the parent should stall or .\r\n\r\nThat's the proper implementation. It's very difficult, and may require compromising on performance for everyone, but it's not impossible. Realistically, that amount of work, I don't see that getting prioritized any time soon. There's just way more pressing issues.\r\n\r\nThe smaller version of converting an outer render into a sync secondary render after commit, with no Suspense or Transition integration etc. is easier. That might be \"good enough\". However, there's the question of whether encouraging thinking of these is a single root given that new features won't work seamlessly anyway. So it might've been \"good enough\" before but not \"good enough\" in the future.\r\n\r\nThere's also a whole other approach of creating fake DOM nodes using the DOM renderer.",
"> Spent some time investigating. Regardless the versions would have to be in perfect lock-step but that turns out to be a requirement anyway so that's fine.\r\n> \r\n> The proper solution that behaves like a Portal should forward the value during a concurrent render into the child. Meaning it should actually be part of the same render phase. That's not just an issue with Context but Props too. Ideally it shouldn't have to commit the outer root before forwarding the inner values.\r\n> \r\n> Additionally, it's not just Context that is contextual. There's internal contexts and for example if you Suspend in the child renderer outside a Suspense boundary, it should affect the parent render. E.g. a startTransition in the parent should stall or .\r\n> \r\n> That's the proper implementation. It's very difficult, and may require compromising on performance for everyone, but it's not impossible. Realistically, that amount of work, I don't see that getting prioritized any time soon. There's just way more pressing issues.\r\n> \r\n> The smaller version of converting an outer render into a sync secondary render after commit, with no Suspense or Transition integration etc. is easier. That might be \"good enough\". However, there's the question of whether encouraging thinking of these is a single root given that new features won't work seamlessly anyway. So it might've been \"good enough\" before but not \"good enough\" in the future.\r\n> \r\n> There's also a whole other approach of creating fake DOM nodes using the DOM renderer.\r\n\r\nhello @sebmarkbage we hacked the context via its-fine by injecting it https://github.com/pmndrs/its-fine/blob/main/src/index.tsx#L217-L234 a renderer must wrap its contents into a bridge. this of course is tapping into fiber internals.\r\n\r\nwe hacked suspense as well as error boundaries with a throw. now the renderer can suspend the dom while loading assets, or be caught in the dom if it fails. we would be very happy if there are official means.\r\n\r\n```jsx\r\nexport function Block({ set }) {\r\n useIsomorphicLayoutEffect(() => {\r\n set(new Promise(() => null))\r\n return () => set(false)\r\n }, [set])\r\n return null\r\n}\r\n\r\nfunction Canvas(...) {\r\n ...\r\n const [block, setBlock] = React.useState(false)\r\n const [error, setError] = React.useState(false)\r\n\r\n // Suspend this component if block is a promise (2nd run)\r\n if (block) throw block\r\n // Throw exception outwards if anything within canvas throws\r\n if (error) throw error\r\n\r\n ...\r\n\r\n root.current.render(\r\n <Bridge>\r\n <ErrorBoundary set={setError}>\r\n <React.Suspense fallback={<Block set={setBlock} />}>{children}</React.Suspense>\r\n </ErrorBoundary>\r\n </Bridge>,\r\n )\r\n```"
] | 2024-03-08 05:44:37 | 2024-03-13 08:11:11 | 2024-03-12 19:46:11 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28524', 'html_url': 'https://github.com/facebook/react/pull/28524', 'diff_url': 'https://github.com/facebook/react/pull/28524.diff', 'patch_url': 'https://github.com/facebook/react/pull/28524.patch', 'merged_at': None} | cheeky idea for blocking this import | {'url': 'https://api.github.com/repos/facebook/react/issues/28524/reactions', 'total_count': 35, '+1': 0, '-1': 15, 'laugh': 14, 'hooray': 0, 'confused': 6, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28524/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28523 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28523/labels{/name} | https://api.github.com/repos/facebook/react/issues/28523/comments | https://api.github.com/repos/facebook/react/issues/28523/events | https://github.com/facebook/react/pull/28523 | 2,175,159,570 | PR_kwDOAJy2Ks5pCQwq | 28,523 | Set didPerformSomeWork after performing work | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlonii/followers', 'following_url': 'https://api.github.com/users/rickhanlonii/following{/other_user}', 'gists_url': 'https://api.github.com/users/rickhanlonii/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rickhanlonii/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rickhanlonii/subscriptions', 'organizations_url': 'https://api.github.com/users/rickhanlonii/orgs', 'repos_url': 'https://api.github.com/users/rickhanlonii/repos', 'events_url': 'https://api.github.com/users/rickhanlonii/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rickhanlonii/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 64f354cf27a17c4e5b0dfcd908e47940cf947771...d7792699a89fdf7aeecd82c7120ecffbe2b35dd7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d7792699a89fdf7aeecd82c7120ecffbe2b35dd7/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/d7792699a89fdf7aeecd82c7120ecffbe2b35dd7/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/d7792699a89fdf7aeecd82c7120ecffbe2b35dd7/files/facebook-www/ReactDOM-prod.classic.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/d7792699a89fdf7aeecd82c7120ecffbe2b35dd7/files/facebook-www/ReactDOM-prod.modern.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d7792699a89fdf7aeecd82c7120ecffbe2b35dd7/files/__test_utils__/ReactAllWarnings.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d7792699a89fdf7aeecd82c7120ecffbe2b35dd7/files/__test_utils__/ReactAllWarnings.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against d7792699a89fdf7aeecd82c7120ecffbe2b35dd7\n</p>\n",
"I think this is basically the same as this: https://github.com/facebook/react/pull/26746"
] | 2024-03-08 02:31:12 | 2024-03-22 17:09:04 | null | MEMBER | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28523', 'html_url': 'https://github.com/facebook/react/pull/28523', 'diff_url': 'https://github.com/facebook/react/pull/28523.diff', 'patch_url': 'https://github.com/facebook/react/pull/28523.patch', 'merged_at': None} | ## Overview
Not sure if this fix is correct, but wanted to open to discuss.
`performSyncWorkOnRoot` can immediately throw `'Should not already be working.'` without doing any work. When this happens, we catch the error and continue in the loop, which will throw again, and we're in an infinite loop.
Moving the check to after the work is complete will break the loop, but probably miss some work.
@yungsters and I found the loop when syncing the enableCache flag to RN. Turns out, RN internally is using mismatching versions of the renderer (main) and react (npm), so it's a busted setup that needs fixed, but exposed this hang. | {'url': 'https://api.github.com/repos/facebook/react/issues/28523/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28523/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28522 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28522/labels{/name} | https://api.github.com/repos/facebook/react/issues/28522/comments | https://api.github.com/repos/facebook/react/issues/28522/events | https://github.com/facebook/react/pull/28522 | 2,174,922,222 | PR_kwDOAJy2Ks5pBd4A | 28,522 | Concurrent rendering in ReactDevToolsHooksIntegration-test | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', 'following_url': 'https://api.github.com/users/jackpope/following{/other_user}', 'gists_url': 'https://api.github.com/users/jackpope/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jackpope/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jackpope/subscriptions', 'organizations_url': 'https://api.github.com/users/jackpope/orgs', 'repos_url': 'https://api.github.com/users/jackpope/repos', 'events_url': 'https://api.github.com/users/jackpope/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jackpope/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 338dddc089d5865761219f02b5175db85c54c489...307aad91b534d985da54916d58c198e8ede4cd39\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/307aad91b534d985da54916d58c198e8ede4cd39/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/307aad91b534d985da54916d58c198e8ede4cd39/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/307aad91b534d985da54916d58c198e8ede4cd39/files/facebook-www/ReactDOM-prod.classic.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/307aad91b534d985da54916d58c198e8ede4cd39/files/facebook-www/ReactDOM-prod.modern.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/307aad91b534d985da54916d58c198e8ede4cd39/files/__test_utils__/ReactAllWarnings.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/307aad91b534d985da54916d58c198e8ede4cd39/files/__test_utils__/ReactAllWarnings.js?compare=338dddc089d5865761219f02b5175db85c54c489) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 307aad91b534d985da54916d58c198e8ede4cd39\n</p>\n"
] | 2024-03-07 22:24:13 | 2024-03-11 19:06:39 | 2024-03-11 19:06:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28522', 'html_url': 'https://github.com/facebook/react/pull/28522', 'diff_url': 'https://github.com/facebook/react/pull/28522.diff', 'patch_url': 'https://github.com/facebook/react/pull/28522.patch', 'merged_at': datetime.datetime(2024, 3, 11, 19, 6, 35)} | ## Summary
We need to unblock flipping the default for RTR to be concurrent rendering. Update ReactDevToolsHooksIntegration-test to use `unstable_isConcurrent` in place.
## How did you test this change?
`yarn test packages/react-debug-tools/src/__tests__/ReactDevToolsHooksIntegration-test.js` | {'url': 'https://api.github.com/repos/facebook/react/issues/28522/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28522/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28521 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28521/labels{/name} | https://api.github.com/repos/facebook/react/issues/28521/comments | https://api.github.com/repos/facebook/react/issues/28521/events | https://github.com/facebook/react/pull/28521 | 2,174,920,850 | PR_kwDOAJy2Ks5pBdkd | 28,521 | Concurrent rendering for ReactART-test | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', 'following_url': 'https://api.github.com/users/jackpope/following{/other_user}', 'gists_url': 'https://api.github.com/users/jackpope/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jackpope/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jackpope/subscriptions', 'organizations_url': 'https://api.github.com/users/jackpope/orgs', 'repos_url': 'https://api.github.com/users/jackpope/repos', 'events_url': 'https://api.github.com/users/jackpope/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jackpope/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0aab065eb3250a9714a62dc05587cbb571da7f71...525d5fd1355436d92cb0f5717727d6acd732df7e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/525d5fd1355436d92cb0f5717727d6acd732df7e/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/525d5fd1355436d92cb0f5717727d6acd732df7e/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/525d5fd1355436d92cb0f5717727d6acd732df7e/files/facebook-www/ReactDOM-prod.classic.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 594.27 kB | 594.27 kB | = | 104.44 kB | 104.44 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/525d5fd1355436d92cb0f5717727d6acd732df7e/files/facebook-www/ReactDOM-prod.modern.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **=** | 577.53 kB | 577.53 kB | = | 101.47 kB | 101.47 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/525d5fd1355436d92cb0f5717727d6acd732df7e/files/__test_utils__/ReactAllWarnings.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/525d5fd1355436d92cb0f5717727d6acd732df7e/files/__test_utils__/ReactAllWarnings.js?compare=0aab065eb3250a9714a62dc05587cbb571da7f71) | **Deleted** | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 525d5fd1355436d92cb0f5717727d6acd732df7e\n</p>\n",
"Seems like various www tests are failing with these changes"
] | 2024-03-07 22:23:04 | 2024-03-18 19:40:05 | 2024-03-18 19:40:02 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28521', 'html_url': 'https://github.com/facebook/react/pull/28521', 'diff_url': 'https://github.com/facebook/react/pull/28521.diff', 'patch_url': 'https://github.com/facebook/react/pull/28521.patch', 'merged_at': datetime.datetime(2024, 3, 18, 19, 40, 2)} | ## Summary
We need to unblock flipping the default for RTR to be concurrent rendering. Update ReactART-test to use `unstable_isConcurrent` in place.
## How did you test this change?
`yarn test packages/react-art/src/__tests__/ReactART-test.js`
| {'url': 'https://api.github.com/repos/facebook/react/issues/28521/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28521/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28520 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28520/labels{/name} | https://api.github.com/repos/facebook/react/issues/28520/comments | https://api.github.com/repos/facebook/react/issues/28520/events | https://github.com/facebook/react/pull/28520 | 2,174,595,946 | PR_kwDOAJy2Ks5pAWjd | 28,520 | Fix ReactHooksInspection-test.js | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'following_url': 'https://api.github.com/users/yungsters/following{/other_user}', 'gists_url': 'https://api.github.com/users/yungsters/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/yungsters/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/yungsters/subscriptions', 'organizations_url': 'https://api.github.com/users/yungsters/orgs', 'repos_url': 'https://api.github.com/users/yungsters/repos', 'events_url': 'https://api.github.com/users/yungsters/events{/privacy}', 'received_events_url': 'https://api.github.com/users/yungsters/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4...fd0e1832d40ced398a90944b4a8b335cf78f2ff0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/fd0e1832d40ced398a90944b4a8b335cf78f2ff0/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/fd0e1832d40ced398a90944b4a8b335cf78f2ff0/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/fd0e1832d40ced398a90944b4a8b335cf78f2ff0/files/facebook-www/ReactDOM-prod.classic.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/fd0e1832d40ced398a90944b4a8b335cf78f2ff0/files/facebook-www/ReactDOM-prod.modern.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/fd0e1832d40ced398a90944b4a8b335cf78f2ff0/files/__test_utils__/ReactAllWarnings.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/fd0e1832d40ced398a90944b4a8b335cf78f2ff0/files/__test_utils__/ReactAllWarnings.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fd0e1832d40ced398a90944b4a8b335cf78f2ff0\n</p>\n"
] | 2024-03-07 19:16:14 | 2024-03-07 19:22:46 | 2024-03-07 19:22:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28520', 'html_url': 'https://github.com/facebook/react/pull/28520', 'diff_url': 'https://github.com/facebook/react/pull/28520.diff', 'patch_url': 'https://github.com/facebook/react/pull/28520.patch', 'merged_at': datetime.datetime(2024, 3, 7, 19, 22, 43)} | ## Summary
Currently, `ReactHooksInspection-test.js` fails because something is polluting the resulting `Promise` with symbol properties. This changes the unit test to be more resilient to such symbol properties.
## How did you test this change?
Ran the following successfully:
```
$ yarn test
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28520/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28520/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28519 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28519/labels{/name} | https://api.github.com/repos/facebook/react/issues/28519/comments | https://api.github.com/repos/facebook/react/issues/28519/events | https://github.com/facebook/react/pull/28519 | 2,174,559,642 | PR_kwDOAJy2Ks5pAOXJ | 28,519 | Configure "Always On" Feature Flags for React Native | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'following_url': 'https://api.github.com/users/yungsters/following{/other_user}', 'gists_url': 'https://api.github.com/users/yungsters/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/yungsters/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/yungsters/subscriptions', 'organizations_url': 'https://api.github.com/users/yungsters/orgs', 'repos_url': 'https://api.github.com/users/yungsters/repos', 'events_url': 'https://api.github.com/users/yungsters/events{/privacy}', 'received_events_url': 'https://api.github.com/users/yungsters/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4...377312268d9a02694a7d9a57181b35b00c388cd7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/facebook-www/ReactDOM-prod.classic.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/facebook-www/ReactDOM-prod.modern.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [react-native/implementations/ReactFabric-prod.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactFabric-prod.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+4.59%** | 334.92 kB | 350.31 kB | +4.00% | 59.58 kB | 61.96 kB\n| [react-native/implementations/ReactNativeRenderer-prod.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactNativeRenderer-prod.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+4.44%** | 342.53 kB | 357.76 kB | +3.88% | 60.92 kB | 63.29 kB\n| [react-native/implementations/ReactFabric-profiling.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactFabric-profiling.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+4.27%** | 362.14 kB | 377.61 kB | +3.82% | 63.78 kB | 66.21 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactNativeRenderer-profiling.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+4.13%** | 369.79 kB | 385.08 kB | +3.60% | 65.18 kB | 67.52 kB\n| [react-native/implementations/ReactFabric-dev.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactFabric-dev.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+3.44%** | 1,014.39 kB | 1,049.29 kB | +3.05% | 204.18 kB | 210.41 kB\n| [react-native/implementations/ReactNativeRenderer-dev.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactNativeRenderer-dev.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+3.39%** | 1,028.99 kB | 1,063.89 kB | +3.03% | 207.92 kB | 214.21 kB\n| [react-native/implementations/ReactFabric-dev.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactFabric-dev.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+2.32%** | 979.42 kB | 1,002.11 kB | +1.99% | 197.14 kB | 201.06 kB\n| [react-native/implementations/ReactNativeRenderer-dev.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactNativeRenderer-dev.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+2.28%** | 995.70 kB | 1,018.40 kB | +1.94% | 201.26 kB | 205.16 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/__test_utils__/ReactAllWarnings.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [react-native/implementations/ReactFabric-prod.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactFabric-prod.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+4.59%** | 334.92 kB | 350.31 kB | +4.00% | 59.58 kB | 61.96 kB\n| [react-native/implementations/ReactNativeRenderer-prod.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactNativeRenderer-prod.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+4.44%** | 342.53 kB | 357.76 kB | +3.88% | 60.92 kB | 63.29 kB\n| [react-native/implementations/ReactFabric-profiling.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactFabric-profiling.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+4.27%** | 362.14 kB | 377.61 kB | +3.82% | 63.78 kB | 66.21 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactNativeRenderer-profiling.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+4.13%** | 369.79 kB | 385.08 kB | +3.60% | 65.18 kB | 67.52 kB\n| [react-native/implementations/ReactFabric-dev.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactFabric-dev.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+3.44%** | 1,014.39 kB | 1,049.29 kB | +3.05% | 204.18 kB | 210.41 kB\n| [react-native/implementations/ReactNativeRenderer-dev.fb.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactNativeRenderer-dev.fb.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+3.39%** | 1,028.99 kB | 1,063.89 kB | +3.03% | 207.92 kB | 214.21 kB\n| [react-native/implementations/ReactFabric-dev.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactFabric-dev.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+2.32%** | 979.42 kB | 1,002.11 kB | +1.99% | 197.14 kB | 201.06 kB\n| [react-native/implementations/ReactNativeRenderer-dev.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactNativeRenderer-dev.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+2.28%** | 995.70 kB | 1,018.40 kB | +1.94% | 201.26 kB | 205.16 kB\n| [react-native/implementations/ReactFabric-prod.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactFabric-prod.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+1.13%** | 323.21 kB | 326.87 kB | +0.70% | 57.06 kB | 57.47 kB\n| [react-native/implementations/ReactFabric-profiling.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactFabric-profiling.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+1.07%** | 341.89 kB | 345.55 kB | +0.71% | 60.11 kB | 60.54 kB\n| [react-native/implementations/ReactNativeRenderer-prod.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactNativeRenderer-prod.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+1.05%** | 332.40 kB | 335.88 kB | +0.60% | 58.73 kB | 59.08 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/react-native/implementations/ReactNativeRenderer-profiling.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **+0.99%** | 351.79 kB | 355.28 kB | +0.66% | 61.89 kB | 62.30 kB\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 935.43 kB | 933.09 kB | = | 186.73 kB | 186.46 kB\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 331.47 kB | 330.39 kB | = | 58.37 kB | 58.22 kB\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **=** | 315.57 kB | 314.49 kB | = | 55.93 kB | 55.78 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/377312268d9a02694a7d9a57181b35b00c388cd7/files/__test_utils__/ReactAllWarnings.js?compare=447fc27e3613d9fd026fbf48aa8a5e5a3f5167d4) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 377312268d9a02694a7d9a57181b35b00c388cd7\n</p>\n"
] | 2024-03-07 18:58:35 | 2024-03-08 17:20:07 | 2024-03-08 17:20:03 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28519', 'html_url': 'https://github.com/facebook/react/pull/28519', 'diff_url': 'https://github.com/facebook/react/pull/28519.diff', 'patch_url': 'https://github.com/facebook/react/pull/28519.patch', 'merged_at': datetime.datetime(2024, 3, 8, 17, 20, 3)} | ## Summary
This PR is a subset of https://github.com/facebook/react/pull/28425, which only includes the feature flags that will be configured as "always on" (i.e. not "dynamic").
The following list summarizes the feature flag changes:
* RN FB
* Always Enable
* enableCache
* enableCustomElementPropertySupport
* RN OSS
* Always Enable
* disableLegacyContext
* enableCache
* enableCustomElementPropertySupport
* RN Test
* Always Enable
* disableModulePatternComponents
* enableCustomElementPropertySupport
## How did you test this change?
Ran the following successfully:
```
$ yarn test
$ yarn flow native
$ yarn flow fabric
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28519/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28519/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28518 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28518/labels{/name} | https://api.github.com/repos/facebook/react/issues/28518/comments | https://api.github.com/repos/facebook/react/issues/28518/events | https://github.com/facebook/react/pull/28518 | 2,174,337,881 | PR_kwDOAJy2Ks5o_dy3 | 28,518 | fix[devtools/e2e]: fixed source inspection in e2e tests | {'login': 'hoxyq', 'id': 28902667, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_url': 'https://api.github.com/users/hoxyq/following{/other_user}', 'gists_url': 'https://api.github.com/users/hoxyq/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hoxyq/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hoxyq/subscriptions', 'organizations_url': 'https://api.github.com/users/hoxyq/orgs', 'repos_url': 'https://api.github.com/users/hoxyq/repos', 'events_url': 'https://api.github.com/users/hoxyq/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hoxyq/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [] | 2024-03-07 17:05:32 | 2024-03-07 17:59:40 | 2024-03-07 17:59:37 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28518', 'html_url': 'https://github.com/facebook/react/pull/28518', 'diff_url': 'https://github.com/facebook/react/pull/28518.diff', 'patch_url': 'https://github.com/facebook/react/pull/28518.patch', 'merged_at': datetime.datetime(2024, 3, 7, 17, 59, 37)} | DevTools e2e tests started to fail after landing https://github.com/facebook/react/pull/28471:
- https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798270
- https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798275
- https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798271
- https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798274
- https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798269
There are 2 reasons for that:
1. Versions 16.0 and 16.5 use legacy renderer, which doesn't support source inspection by design:
https://github.com/facebook/react/blob/850fac4915864a487e7cb9ecae8a75dbac144174/packages/react-devtools-shared/src/backend/legacy/renderer.js#L831
The corresponding e2e test is now gated for versions >=16.8
2. For other versions (>=16.8), the source is actually `e2e-app-regression.js`, because these regression tests open a different page (not the one we open for tests against React from source)
https://github.com/facebook/react/blob/850fac4915864a487e7cb9ecae8a75dbac144174/packages/react-devtools-inline/playwright.config.js#L15-L17 | {'url': 'https://api.github.com/repos/facebook/react/issues/28518/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28518/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28517 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28517/labels{/name} | https://api.github.com/repos/facebook/react/issues/28517/comments | https://api.github.com/repos/facebook/react/issues/28517/events | https://github.com/facebook/react/issues/28517 | 2,174,337,619 | I_kwDOAJy2Ks6BmcJT | 28,517 | Bug: Property 'inputType' does not exist on type 'Event' | {'login': 'dehoward', 'id': 52973358, 'node_id': 'MDQ6VXNlcjUyOTczMzU4', 'avatar_url': 'https://avatars.githubusercontent.com/u/52973358?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dehoward', 'html_url': 'https://github.com/dehoward', 'followers_url': 'https://api.github.com/users/dehoward/followers', 'following_url': 'https://api.github.com/users/dehoward/following{/other_user}', 'gists_url': 'https://api.github.com/users/dehoward/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dehoward/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dehoward/subscriptions', 'organizations_url': 'https://api.github.com/users/dehoward/orgs', 'repos_url': 'https://api.github.com/users/dehoward/repos', 'events_url': 'https://api.github.com/users/dehoward/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dehoward/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"can i work on this if it has not been assigned to anyone?\r\n",
"> can i work on this if it has not been assigned to anyone?\r\n\r\nwhy not？",
"@dehoward @yezhonghu0503 I dont see the the object you are passing in the onclick function but im guessing the inputType key is present. looks like you are trying to get the key-value pair but its not directly available. i would write a condition to check if the inputType property exists before accessing it. Here's how you can modify this code. \r\n\r\n```js\r\nimport React from 'react';\r\n\r\nexport default function App() {\r\n const handleChange = (event) => {\r\n if (event.nativeEvent && event.nativeEvent.inputType) {\r\n console.log(JSON.stringify(event.nativeEvent.inputType));\r\n } else {\r\n console.log('inputType property not available');\r\n }\r\n };\r\n\r\n return (\r\n <div className='App'>\r\n <input onChange={handleChange} />\r\n </div>\r\n );\r\n}\r\n```\r\n\r\nlet me know if this fixes the bug. ",
"I guess we have to ensure that the event object is of the correct type (InputEvent) before accessing the inputType property. ",
"do you guys still have an error?"
] | 2024-03-07 17:05:23 | 2024-03-24 14:24:02 | 2024-03-13 12:06:27 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.0.0
## Steps To Reproduce
<img width="458" alt="image" src="https://github.com/facebook/react/assets/52973358/5beea44e-13b6-4653-8b0d-88496e63bd82">
create an `onChange` handler for an `input` and try to access `event.nativeEvent.inputType`
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
https://playcode.io/1790904
## The current behavior
Doesn't allow type
## The expected behavior
Should allow property access | {'url': 'https://api.github.com/repos/facebook/react/issues/28517/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28517/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28516 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28516/labels{/name} | https://api.github.com/repos/facebook/react/issues/28516/comments | https://api.github.com/repos/facebook/react/issues/28516/events | https://github.com/facebook/react/pull/28516 | 2,174,147,383 | PR_kwDOAJy2Ks5o-zux | 28,516 | Screenshotsquestionman | {'login': 'ShadowLightnin', 'id': 124177398, 'node_id': 'U_kgDOB2bL9g', 'avatar_url': 'https://avatars.githubusercontent.com/u/124177398?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ShadowLightnin', 'html_url': 'https://github.com/ShadowLightnin', 'followers_url': 'https://api.github.com/users/ShadowLightnin/followers', 'following_url': 'https://api.github.com/users/ShadowLightnin/following{/other_user}', 'gists_url': 'https://api.github.com/users/ShadowLightnin/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ShadowLightnin/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ShadowLightnin/subscriptions', 'organizations_url': 'https://api.github.com/users/ShadowLightnin/orgs', 'repos_url': 'https://api.github.com/users/ShadowLightnin/repos', 'events_url': 'https://api.github.com/users/ShadowLightnin/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ShadowLightnin/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Hi @ShadowLightnin! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328516). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 850fac4915864a487e7cb9ecae8a75dbac144174...03c1dfff87687713648302a5ecc814a4ffbfb8e2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/03c1dfff87687713648302a5ecc814a4ffbfb8e2/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/03c1dfff87687713648302a5ecc814a4ffbfb8e2/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/03c1dfff87687713648302a5ecc814a4ffbfb8e2/files/facebook-www/ReactDOM-prod.classic.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/03c1dfff87687713648302a5ecc814a4ffbfb8e2/files/facebook-www/ReactDOM-prod.modern.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/03c1dfff87687713648302a5ecc814a4ffbfb8e2/files/__test_utils__/ReactAllWarnings.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/03c1dfff87687713648302a5ecc814a4ffbfb8e2/files/__test_utils__/ReactAllWarnings.js?compare=850fac4915864a487e7cb9ecae8a75dbac144174) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 03c1dfff87687713648302a5ecc814a4ffbfb8e2\n</p>\n"
] | 2024-03-07 15:35:59 | 2024-03-07 15:41:06 | 2024-03-07 15:37:11 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28516', 'html_url': 'https://github.com/facebook/react/pull/28516', 'diff_url': 'https://github.com/facebook/react/pull/28516.diff', 'patch_url': 'https://github.com/facebook/react/pull/28516.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28516/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28516/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28515 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28515/labels{/name} | https://api.github.com/repos/facebook/react/issues/28515/comments | https://api.github.com/repos/facebook/react/issues/28515/events | https://github.com/facebook/react/pull/28515 | 2,173,033,175 | PR_kwDOAJy2Ks5o6-k3 | 28,515 | Remove invokeGuardedCallback and replay trick | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 7d6f1e3c13686272c1d76813992d4e782fcb84e6...8ed9d7ce7bd4b803f2ec5c44e283120163ee8743\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 177.10 kB | 176.71 kB | = | 55.20 kB | 54.89 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 177.64 kB | 177.25 kB | = | 55.53 kB | 55.25 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactDOM-prod.classic.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 593.92 kB | 592.84 kB | = | 104.85 kB | 104.15 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactDOM-prod.modern.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 577.18 kB | 576.10 kB | = | 101.91 kB | 101.21 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.52 kB | 12.03 kB | = | 4.87 kB | 4.70 kB\n| [oss-stable-semver/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/umd/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.52 kB | 12.03 kB | = | 4.87 kB | 4.70 kB\n| [oss-stable/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/umd/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.52 kB | 12.03 kB | = | 4.87 kB | 4.70 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.43 kB | 11.94 kB | = | 4.82 kB | 4.66 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.43 kB | 11.94 kB | = | 4.82 kB | 4.66 kB\n| [oss-stable/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.43 kB | 11.94 kB | = | 4.82 kB | 4.66 kB\n| [facebook-www/ReactTestUtils-dev.classic.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactTestUtils-dev.classic.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 54.14 kB | 51.14 kB | = | 13.80 kB | 13.07 kB\n| [facebook-www/ReactTestUtils-dev.modern.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactTestUtils-dev.modern.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 54.14 kB | 51.14 kB | = | 13.80 kB | 13.07 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 45.18 kB | 42.64 kB | = | 12.81 kB | 12.11 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 45.18 kB | 42.64 kB | = | 12.81 kB | 12.11 kB\n| [oss-stable/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom-test-utils.production.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 45.18 kB | 42.64 kB | = | 12.81 kB | 12.11 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/umd/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 58.17 kB | 47.41 kB | = | 16.21 kB | 13.10 kB\n| [oss-stable-semver/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/umd/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 58.17 kB | 47.41 kB | = | 16.21 kB | 13.10 kB\n| [oss-stable/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/umd/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 58.17 kB | 47.41 kB | = | 16.21 kB | 13.10 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 55.01 kB | 44.64 kB | = | 15.92 kB | 12.87 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 55.01 kB | 44.64 kB | = | 15.92 kB | 12.87 kB\n| [oss-stable/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 55.01 kB | 44.64 kB | = | 15.92 kB | 12.87 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/__test_utils__/ReactAllWarnings.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-dom/umd/react-dom.profiling.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/umd/react-dom.profiling.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 186.40 kB | 186.01 kB | = | 58.15 kB | 57.72 kB\n| [oss-stable/react-dom/umd/react-dom.profiling.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/umd/react-dom.profiling.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 185.85 kB | 185.46 kB | = | 57.85 kB | 57.46 kB\n| [oss-stable-semver/react-dom/umd/react-dom.profiling.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/umd/react-dom.profiling.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 185.77 kB | 185.39 kB | = | 57.82 kB | 57.44 kB\n| [oss-experimental/react-dom/cjs/react-dom.profiling.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom.profiling.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 187.11 kB | 186.72 kB | = | 57.89 kB | 57.57 kB\n| [oss-stable/react-dom/cjs/react-dom.profiling.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom.profiling.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 186.57 kB | 186.18 kB | = | 57.55 kB | 57.24 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 186.49 kB | 186.11 kB | = | 57.52 kB | 57.21 kB\n| [oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 183.69 kB | 183.30 kB | = | 57.79 kB | 57.52 kB\n| [oss-experimental/react-dom/umd/react-dom.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/umd/react-dom.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 177.37 kB | 176.98 kB | = | 55.77 kB | 55.43 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 177.64 kB | 177.25 kB | = | 55.53 kB | 55.25 kB\n| [oss-stable/react-dom/umd/react-dom.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/umd/react-dom.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 176.82 kB | 176.43 kB | = | 55.47 kB | 55.10 kB\n| [oss-stable-semver/react-dom/umd/react-dom.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/umd/react-dom.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 176.74 kB | 176.36 kB | = | 55.44 kB | 55.07 kB\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 177.10 kB | 176.71 kB | = | 55.20 kB | 54.89 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 177.02 kB | 176.64 kB | = | 55.17 kB | 54.87 kB\n| [oss-experimental/react-dom/cjs/react-dom.profiling.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom.profiling.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 998.98 kB | 996.42 kB | = | 222.71 kB | 221.90 kB\n| [oss-stable/react-dom/cjs/react-dom.profiling.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom.profiling.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 996.42 kB | 993.85 kB | = | 221.61 kB | 220.81 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.profiling.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom.profiling.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 996.39 kB | 993.83 kB | = | 221.59 kB | 220.78 kB\n| [oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 974.97 kB | 972.40 kB | = | 219.60 kB | 218.80 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 957.05 kB | 954.48 kB | = | 215.12 kB | 214.31 kB\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 954.48 kB | 951.91 kB | = | 214.06 kB | 213.25 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom.production.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 954.45 kB | 951.89 kB | = | 214.03 kB | 213.22 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.fb.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactNativeRenderer-profiling.fb.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 401.56 kB | 400.45 kB | = | 70.29 kB | 69.79 kB\n| [react-native/implementations/ReactFabric-profiling.fb.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactFabric-profiling.fb.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 394.08 kB | 392.95 kB | = | 69.01 kB | 68.47 kB\n| [react-native/implementations/ReactNativeRenderer-prod.fb.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactNativeRenderer-prod.fb.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 374.20 kB | 373.09 kB | = | 66.01 kB | 65.46 kB\n| [react-native/implementations/ReactFabric-prod.fb.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactFabric-prod.fb.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 366.79 kB | 365.65 kB | = | 64.73 kB | 64.20 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactNativeRenderer-profiling.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 355.28 kB | 354.17 kB | = | 62.30 kB | 61.77 kB\n| [react-native/implementations/ReactFabric-profiling.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactFabric-profiling.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 345.55 kB | 344.41 kB | = | 60.54 kB | 60.08 kB\n| [react-native/implementations/ReactNativeRenderer-prod.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactNativeRenderer-prod.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 335.88 kB | 334.77 kB | = | 59.08 kB | 58.58 kB\n| [react-native/implementations/ReactFabric-prod.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactFabric-prod.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 326.87 kB | 325.74 kB | = | 57.47 kB | 56.99 kB\n| [facebook-www/ReactTestRenderer-dev.classic.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactTestRenderer-dev.classic.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 945.36 kB | 941.63 kB | = | 188.33 kB | 187.15 kB\n| [facebook-www/ReactTestRenderer-dev.modern.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactTestRenderer-dev.modern.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 945.36 kB | 941.62 kB | = | 188.33 kB | 187.14 kB\n| [facebook-www/ReactDOMTesting-dev.classic.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactDOMTesting-dev.classic.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,691.75 kB | 1,681.72 kB | = | 336.12 kB | 333.43 kB\n| [facebook-www/ReactDOM-dev.classic.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactDOM-dev.classic.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,670.23 kB | 1,660.20 kB | = | 331.57 kB | 328.89 kB\n| [facebook-www/ReactDOMTesting-dev.modern.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactDOMTesting-dev.modern.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,660.67 kB | 1,650.64 kB | = | 330.62 kB | 327.94 kB\n| [facebook-www/ReactDOM-dev.modern.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactDOM-dev.modern.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,639.21 kB | 1,629.17 kB | = | 326.06 kB | 323.41 kB\n| [facebook-www/ReactART-dev.classic.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactART-dev.classic.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,065.88 kB | 1,056.80 kB | = | 209.46 kB | 206.92 kB\n| [facebook-www/ReactART-dev.modern.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactART-dev.modern.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,053.67 kB | 1,044.60 kB | = | 207.04 kB | 204.49 kB\n| [oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,357.96 kB | 1,341.57 kB | = | 300.46 kB | 295.51 kB\n| [oss-experimental/react-dom/umd/react-dom.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/umd/react-dom.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,404.68 kB | 1,387.65 kB | = | 299.19 kB | 294.25 kB\n| [oss-stable/react-dom/umd/react-dom.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/umd/react-dom.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,403.26 kB | 1,386.23 kB | = | 298.75 kB | 293.85 kB\n| [oss-stable-semver/react-dom/umd/react-dom.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/umd/react-dom.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,403.23 kB | 1,386.20 kB | = | 298.73 kB | 293.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,340.17 kB | 1,323.77 kB | = | 296.19 kB | 291.25 kB\n| [oss-stable/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,338.91 kB | 1,322.51 kB | = | 295.78 kB | 290.87 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,338.88 kB | 1,322.49 kB | = | 295.75 kB | 290.83 kB\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 933.09 kB | 920.77 kB | = | 186.44 kB | 182.85 kB\n| [oss-stable/react-test-renderer/umd/react-test-renderer.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-test-renderer/umd/react-test-renderer.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 863.83 kB | 852.29 kB | = | 182.53 kB | 178.93 kB\n| [oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 863.81 kB | 852.27 kB | = | 182.50 kB | 178.90 kB\n| [oss-experimental/react-test-renderer/umd/react-test-renderer.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-test-renderer/umd/react-test-renderer.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 861.98 kB | 850.44 kB | = | 182.03 kB | 178.43 kB\n| [oss-stable/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-test-renderer/cjs/react-test-renderer.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 824.94 kB | 813.81 kB | = | 180.57 kB | 176.99 kB\n| [oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 824.91 kB | 813.79 kB | = | 180.54 kB | 176.96 kB\n| [oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 823.18 kB | 812.05 kB | = | 180.09 kB | 176.50 kB\n| [oss-experimental/react-reconciler/cjs/react-reconciler.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-reconciler/cjs/react-reconciler.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 954.04 kB | 938.61 kB | = | 204.52 kB | 199.78 kB\n| [oss-stable/react-reconciler/cjs/react-reconciler.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-reconciler/cjs/react-reconciler.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 945.22 kB | 929.79 kB | = | 202.91 kB | 198.15 kB\n| [oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 945.19 kB | 929.77 kB | = | 202.88 kB | 198.13 kB\n| [oss-experimental/react-art/umd/react-art.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-art/umd/react-art.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 967.58 kB | 951.42 kB | = | 204.22 kB | 199.50 kB\n| [react-native/implementations/ReactNativeRenderer-dev.fb.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactNativeRenderer-dev.fb.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,104.37 kB | 1,085.89 kB | = | 221.56 kB | 216.60 kB\n| [oss-stable/react-art/umd/react-art.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-art/umd/react-art.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 961.01 kB | 944.84 kB | = | 203.54 kB | 198.83 kB\n| [oss-stable-semver/react-art/umd/react-art.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-art/umd/react-art.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 960.98 kB | 944.81 kB | = | 203.51 kB | 198.81 kB\n| [react-native/implementations/ReactFabric-dev.fb.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactFabric-dev.fb.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,089.80 kB | 1,071.32 kB | = | 217.71 kB | 212.73 kB\n| [react-native/implementations/ReactNativeRenderer-dev.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactNativeRenderer-dev.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,018.40 kB | 999.92 kB | = | 205.14 kB | 200.16 kB\n| [oss-experimental/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-art/cjs/react-art.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 850.71 kB | 835.14 kB | = | 184.96 kB | 180.14 kB\n| [oss-stable/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-art/cjs/react-art.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 844.49 kB | 828.92 kB | = | 184.34 kB | 179.51 kB\n| [oss-stable-semver/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-art/cjs/react-art.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 844.46 kB | 828.90 kB | = | 184.32 kB | 179.48 kB\n| [react-native/implementations/ReactFabric-dev.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/react-native/implementations/ReactFabric-dev.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 1,002.12 kB | 983.64 kB | = | 201.05 kB | 196.06 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.52 kB | 12.03 kB | = | 4.87 kB | 4.70 kB\n| [oss-stable-semver/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/umd/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.52 kB | 12.03 kB | = | 4.87 kB | 4.70 kB\n| [oss-stable/react-dom/umd/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/umd/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.52 kB | 12.03 kB | = | 4.87 kB | 4.70 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.43 kB | 11.94 kB | = | 4.82 kB | 4.66 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.43 kB | 11.94 kB | = | 4.82 kB | 4.66 kB\n| [oss-stable/react-dom/cjs/react-dom-test-utils.production.min.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom-test-utils.production.min.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 12.43 kB | 11.94 kB | = | 4.82 kB | 4.66 kB\n| [facebook-www/ReactTestUtils-dev.classic.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactTestUtils-dev.classic.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 54.14 kB | 51.14 kB | = | 13.80 kB | 13.07 kB\n| [facebook-www/ReactTestUtils-dev.modern.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/facebook-www/ReactTestUtils-dev.modern.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 54.14 kB | 51.14 kB | = | 13.80 kB | 13.07 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom-test-utils.production.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 45.18 kB | 42.64 kB | = | 12.81 kB | 12.11 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 45.18 kB | 42.64 kB | = | 12.81 kB | 12.11 kB\n| [oss-stable/react-dom/cjs/react-dom-test-utils.production.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom-test-utils.production.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 45.18 kB | 42.64 kB | = | 12.81 kB | 12.11 kB\n| [oss-experimental/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/umd/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 58.17 kB | 47.41 kB | = | 16.21 kB | 13.10 kB\n| [oss-stable-semver/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/umd/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 58.17 kB | 47.41 kB | = | 16.21 kB | 13.10 kB\n| [oss-stable/react-dom/umd/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/umd/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 58.17 kB | 47.41 kB | = | 16.21 kB | 13.10 kB\n| [oss-experimental/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-experimental/react-dom/cjs/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 55.01 kB | 44.64 kB | = | 15.92 kB | 12.87 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable-semver/react-dom/cjs/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 55.01 kB | 44.64 kB | = | 15.92 kB | 12.87 kB\n| [oss-stable/react-dom/cjs/react-dom-test-utils.development.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/oss-stable/react-dom/cjs/react-dom-test-utils.development.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **=** | 55.01 kB | 44.64 kB | = | 15.92 kB | 12.87 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/8ed9d7ce7bd4b803f2ec5c44e283120163ee8743/files/__test_utils__/ReactAllWarnings.js?compare=7d6f1e3c13686272c1d76813992d4e782fcb84e6) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8ed9d7ce7bd4b803f2ec5c44e283120163ee8743\n</p>\n",
"It's not quite that easy it turns out. Added a bunch of TODOs.",
"There's no way to silence the logs when an error boundary catches it now but I have a follow up to change a few other things and introduce a possible way to silence it, but it can't be onerror that does it which is a breaking change."
] | 2024-03-07 06:10:25 | 2024-03-12 00:17:08 | 2024-03-12 00:17:08 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28515', 'html_url': 'https://github.com/facebook/react/pull/28515', 'diff_url': 'https://github.com/facebook/react/pull/28515.diff', 'patch_url': 'https://github.com/facebook/react/pull/28515.patch', 'merged_at': datetime.datetime(2024, 3, 12, 0, 17, 8)} | We broke the ability to "break on uncaught exceptions" by adding a try/catch higher up in the scheduling. We're giving up on fixing that so we can remove the replay trick inside an event handler.
The issue with that approach is that we end up double logging a lot of errors in DEV since they get reported to the page.
It's also a lot of complexity around this feature.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28515/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28515/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28514 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28514/labels{/name} | https://api.github.com/repos/facebook/react/issues/28514/comments | https://api.github.com/repos/facebook/react/issues/28514/events | https://github.com/facebook/react/pull/28514 | 2,172,964,380 | PR_kwDOAJy2Ks5o6vXr | 28,514 | Add pending state to useFormState | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlonii/followers', 'following_url': 'https://api.github.com/users/rickhanlonii/following{/other_user}', 'gists_url': 'https://api.github.com/users/rickhanlonii/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rickhanlonii/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rickhanlonii/subscriptions', 'organizations_url': 'https://api.github.com/users/rickhanlonii/orgs', 'repos_url': 'https://api.github.com/users/rickhanlonii/repos', 'events_url': 'https://api.github.com/users/rickhanlonii/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rickhanlonii/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0066e0b68d90cc71a137f26b7c5bf6af73398fc2...97a9ef23149096c7b82a6af7da9ed5e2e4982375\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **+0.05%** | 177.10 kB | 177.19 kB | +0.03% | 55.19 kB | 55.21 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **+0.05%** | 177.64 kB | 177.73 kB | +0.03% | 55.52 kB | 55.54 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/facebook-www/ReactDOM-prod.classic.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **+0.12%** | 594.36 kB | 595.05 kB | +0.09% | 104.96 kB | 105.05 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/facebook-www/ReactDOM-prod.modern.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **+0.12%** | 577.62 kB | 578.31 kB | +0.09% | 102.01 kB | 102.10 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/__test_utils__/ReactAllWarnings.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **+0.27%** | 29.76 kB | 29.84 kB | +0.35% | 7.66 kB | 7.69 kB\n| [oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **+0.27%** | 29.76 kB | 29.84 kB | +0.35% | 7.66 kB | 7.69 kB\n| [oss-stable/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/oss-stable/react-debug-tools/cjs/react-debug-tools.development.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **+0.27%** | 29.76 kB | 29.84 kB | +0.35% | 7.66 kB | 7.69 kB\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **+0.21%** | 315.59 kB | 316.25 kB | +0.18% | 55.92 kB | 56.02 kB\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **+0.20%** | 331.49 kB | 332.15 kB | +0.17% | 58.36 kB | 58.46 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/97a9ef23149096c7b82a6af7da9ed5e2e4982375/files/__test_utils__/ReactAllWarnings.js?compare=0066e0b68d90cc71a137f26b7c5bf6af73398fc2) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 97a9ef23149096c7b82a6af7da9ed5e2e4982375\n</p>\n",
"I refuse to believe I did this correctly, but I'm merging anyway"
] | 2024-03-07 05:11:03 | 2024-03-12 19:50:14 | 2024-03-12 19:50:11 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28514', 'html_url': 'https://github.com/facebook/react/pull/28514', 'diff_url': 'https://github.com/facebook/react/pull/28514.diff', 'patch_url': 'https://github.com/facebook/react/pull/28514.patch', 'merged_at': datetime.datetime(2024, 3, 12, 19, 50, 11)} | ## Overview
Adds a `pending` state to useFormState, which will be replaced by `useActionState` in the next diff. We will keep `useFormState` around for backwards compatibility, but functionally it will work the same as `useActionState`, which has an `isPending` state returned. | {'url': 'https://api.github.com/repos/facebook/react/issues/28514/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28514/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28513 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28513/labels{/name} | https://api.github.com/repos/facebook/react/issues/28513/comments | https://api.github.com/repos/facebook/react/issues/28513/events | https://github.com/facebook/react/pull/28513 | 2,172,880,607 | PR_kwDOAJy2Ks5o6dEZ | 28,513 | Test for suspending with modern strict mode | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlonii/followers', 'following_url': 'https://api.github.com/users/rickhanlonii/following{/other_user}', 'gists_url': 'https://api.github.com/users/rickhanlonii/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rickhanlonii/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rickhanlonii/subscriptions', 'organizations_url': 'https://api.github.com/users/rickhanlonii/orgs', 'repos_url': 'https://api.github.com/users/rickhanlonii/repos', 'events_url': 'https://api.github.com/users/rickhanlonii/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rickhanlonii/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 64f354cf27a17c4e5b0dfcd908e47940cf947771...e8318782b2780086e1f260badd60de4925bf6e10\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/e8318782b2780086e1f260badd60de4925bf6e10/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/e8318782b2780086e1f260badd60de4925bf6e10/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/e8318782b2780086e1f260badd60de4925bf6e10/files/facebook-www/ReactDOM-prod.classic.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/e8318782b2780086e1f260badd60de4925bf6e10/files/facebook-www/ReactDOM-prod.modern.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/e8318782b2780086e1f260badd60de4925bf6e10/files/__test_utils__/ReactAllWarnings.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/e8318782b2780086e1f260badd60de4925bf6e10/files/__test_utils__/ReactAllWarnings.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e8318782b2780086e1f260badd60de4925bf6e10\n</p>\n"
] | 2024-03-07 03:43:19 | 2024-03-26 04:02:16 | 2024-03-26 04:02:16 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28513', 'html_url': 'https://github.com/facebook/react/pull/28513', 'diff_url': 'https://github.com/facebook/react/pull/28513.diff', 'patch_url': 'https://github.com/facebook/react/pull/28513.patch', 'merged_at': datetime.datetime(2024, 3, 26, 4, 2, 16)} | ## Overview
Adds a test to show the cause of an infinite loop in Relay related to [these effects in Relay](https://github.com/facebook/relay/blob/448aa67d2a11e7d45cd7b4492b9f599b498cb39e/packages/react-relay/relay-hooks/useLazyLoadQueryNode.js#L77-L104) and `useModernStrictMode`. The bug is related to effect behavior when committing trees that re-suspend after initial mount.
With `useModernStrictEffect`, when you:
- initial mount
- update
- suspend (to fallbacks)
- resolve
- re-commit
We fire strict effects during the second mount, like it's a new tree. This creates weird cases, where if there was an update while we suspended, we'll first fire only the effects that changed dependencies, and then fire strict effects.
Creating a test to demonstrate the behavior to see if it's a bug. | {'url': 'https://api.github.com/repos/facebook/react/issues/28513/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28513/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28512 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28512/labels{/name} | https://api.github.com/repos/facebook/react/issues/28512/comments | https://api.github.com/repos/facebook/react/issues/28512/events | https://github.com/facebook/react/pull/28512 | 2,172,873,818 | PR_kwDOAJy2Ks5o6brD | 28,512 | Add Diffs to Hydration Warnings | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5...2f2eb4d456fe9a9af01c0295fd5234e2a7217db6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **=** | 175.85 kB | 175.85 kB | = | 54.68 kB | 54.67 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **=** | 172.33 kB | 172.33 kB | = | 53.81 kB | 53.81 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactDOM-prod.classic.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **=** | 589.61 kB | 589.61 kB | = | 103.77 kB | 103.77 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactDOM-prod.modern.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **=** | 573.13 kB | 573.13 kB | = | 100.81 kB | 100.81 kB\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.13%** | 924.30 kB | 944.01 kB | +2.27% | 183.34 kB | 187.50 kB\n| [oss-experimental/react-test-renderer/umd/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-test-renderer/umd/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.09%** | 840.33 kB | 857.93 kB | +2.26% | 176.43 kB | 180.41 kB\n| [oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.09%** | 802.37 kB | 819.11 kB | +2.27% | 174.37 kB | 178.33 kB\n| [facebook-www/ReactTestRenderer-dev.modern.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactTestRenderer-dev.modern.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.09%** | 945.09 kB | 964.80 kB | +2.24% | 187.58 kB | 191.79 kB\n| [facebook-www/ReactTestRenderer-dev.classic.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactTestRenderer-dev.classic.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.09%** | 945.09 kB | 964.80 kB | +2.24% | 187.58 kB | 191.79 kB\n| [react-native/implementations/ReactFabric-dev.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/react-native/implementations/ReactFabric-dev.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.07%** | 950.64 kB | 970.35 kB | +2.15% | 190.57 kB | 194.67 kB\n| [oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.06%** | 855.10 kB | 872.70 kB | +2.19% | 179.37 kB | 183.30 kB\n| [oss-stable/react-test-renderer/umd/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-test-renderer/umd/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.06%** | 855.13 kB | 872.72 kB | +2.19% | 179.40 kB | 183.33 kB\n| [oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.05%** | 816.55 kB | 833.29 kB | +2.22% | 177.38 kB | 181.31 kB\n| [oss-stable/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-test-renderer/cjs/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.05%** | 816.57 kB | 833.32 kB | +2.22% | 177.41 kB | 181.34 kB\n| [react-native/implementations/ReactNativeRenderer-dev.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/react-native/implementations/ReactNativeRenderer-dev.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.04%** | 965.54 kB | 985.25 kB | +2.14% | 194.22 kB | 198.37 kB\n| [oss-experimental/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-art/cjs/react-art.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.03%** | 825.84 kB | 842.59 kB | +2.22% | 178.21 kB | 182.17 kB\n| [oss-stable-semver/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable-semver/react-art/cjs/react-art.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.01%** | 832.22 kB | 848.97 kB | +2.17% | 180.06 kB | 183.96 kB\n| [oss-stable/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-art/cjs/react-art.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.01%** | 832.25 kB | 848.99 kB | +2.17% | 180.08 kB | 183.99 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/__test_utils__/ReactAllWarnings.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **Deleted** | 65.20 kB | 0.00 kB | Deleted | 16.32 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.13%** | 924.30 kB | 944.01 kB | +2.27% | 183.34 kB | 187.50 kB\n| [oss-experimental/react-test-renderer/umd/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-test-renderer/umd/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.09%** | 840.33 kB | 857.93 kB | +2.26% | 176.43 kB | 180.41 kB\n| [oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.09%** | 802.37 kB | 819.11 kB | +2.27% | 174.37 kB | 178.33 kB\n| [facebook-www/ReactTestRenderer-dev.modern.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactTestRenderer-dev.modern.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.09%** | 945.09 kB | 964.80 kB | +2.24% | 187.58 kB | 191.79 kB\n| [facebook-www/ReactTestRenderer-dev.classic.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactTestRenderer-dev.classic.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.09%** | 945.09 kB | 964.80 kB | +2.24% | 187.58 kB | 191.79 kB\n| [react-native/implementations/ReactFabric-dev.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/react-native/implementations/ReactFabric-dev.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.07%** | 950.64 kB | 970.35 kB | +2.15% | 190.57 kB | 194.67 kB\n| [oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.06%** | 855.10 kB | 872.70 kB | +2.19% | 179.37 kB | 183.30 kB\n| [oss-stable/react-test-renderer/umd/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-test-renderer/umd/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.06%** | 855.13 kB | 872.72 kB | +2.19% | 179.40 kB | 183.33 kB\n| [oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.05%** | 816.55 kB | 833.29 kB | +2.22% | 177.38 kB | 181.31 kB\n| [oss-stable/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-test-renderer/cjs/react-test-renderer.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.05%** | 816.57 kB | 833.32 kB | +2.22% | 177.41 kB | 181.34 kB\n| [react-native/implementations/ReactNativeRenderer-dev.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/react-native/implementations/ReactNativeRenderer-dev.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.04%** | 965.54 kB | 985.25 kB | +2.14% | 194.22 kB | 198.37 kB\n| [oss-experimental/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-art/cjs/react-art.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.03%** | 825.84 kB | 842.59 kB | +2.22% | 178.21 kB | 182.17 kB\n| [oss-stable-semver/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable-semver/react-art/cjs/react-art.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.01%** | 832.22 kB | 848.97 kB | +2.17% | 180.06 kB | 183.96 kB\n| [oss-stable/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-art/cjs/react-art.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+2.01%** | 832.25 kB | 848.99 kB | +2.17% | 180.08 kB | 183.99 kB\n| [oss-experimental/react-reconciler/cjs/react-reconciler.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-reconciler/cjs/react-reconciler.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.95%** | 919.97 kB | 937.91 kB | +2.03% | 197.18 kB | 201.18 kB\n| [oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.94%** | 923.76 kB | 941.69 kB | +2.01% | 197.99 kB | 201.97 kB\n| [oss-stable/react-reconciler/cjs/react-reconciler.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-reconciler/cjs/react-reconciler.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.94%** | 923.78 kB | 941.72 kB | +2.01% | 198.02 kB | 202.00 kB\n| [facebook-www/ReactART-dev.modern.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactART-dev.modern.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.88%** | 1,048.22 kB | 1,067.93 kB | +2.02% | 204.93 kB | 209.07 kB\n| [oss-experimental/react-art/umd/react-art.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-art/umd/react-art.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.87%** | 941.71 kB | 959.30 kB | +1.97% | 197.53 kB | 201.43 kB\n| [facebook-www/ReactART-dev.classic.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactART-dev.classic.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.86%** | 1,060.42 kB | 1,080.13 kB | +2.00% | 207.37 kB | 211.50 kB\n| [oss-stable-semver/react-art/umd/react-art.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable-semver/react-art/umd/react-art.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.86%** | 948.24 kB | 965.83 kB | +1.92% | 199.39 kB | 203.22 kB\n| [oss-stable/react-art/umd/react-art.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-art/umd/react-art.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.86%** | 948.26 kB | 965.86 kB | +1.92% | 199.41 kB | 203.24 kB\n| [react-native/implementations/ReactFabric-dev.fb.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/react-native/implementations/ReactFabric-dev.fb.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.83%** | 1,074.98 kB | 1,094.69 kB | +1.94% | 213.22 kB | 217.36 kB\n| [react-native/implementations/ReactNativeRenderer-dev.fb.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/react-native/implementations/ReactNativeRenderer-dev.fb.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.81%** | 1,089.60 kB | 1,109.31 kB | +1.91% | 217.07 kB | 221.23 kB\n| [oss-experimental/react-dom/umd/react-dom.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-dom/umd/react-dom.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.40%** | 1,369.98 kB | 1,389.14 kB | +1.40% | 291.82 kB | 295.90 kB\n| [oss-experimental/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-dom/cjs/react-dom.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.40%** | 1,306.91 kB | 1,325.14 kB | +1.40% | 288.87 kB | 292.91 kB\n| [oss-stable-semver/react-dom/umd/react-dom.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable-semver/react-dom/umd/react-dom.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.39%** | 1,379.08 kB | 1,398.24 kB | +1.41% | 293.35 kB | 297.48 kB\n| [oss-stable/react-dom/umd/react-dom.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-dom/umd/react-dom.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.39%** | 1,379.10 kB | 1,398.26 kB | +1.41% | 293.38 kB | 297.50 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable-semver/react-dom/cjs/react-dom.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.39%** | 1,315.75 kB | 1,333.99 kB | +1.40% | 290.39 kB | 294.46 kB\n| [oss-stable/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-stable/react-dom/cjs/react-dom.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.39%** | 1,315.78 kB | 1,334.01 kB | +1.40% | 290.43 kB | 294.49 kB\n| [oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.38%** | 1,324.70 kB | 1,342.94 kB | +1.39% | 293.09 kB | 297.17 kB\n| [facebook-www/ReactDOM-dev.modern.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactDOM-dev.modern.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.32%** | 1,625.69 kB | 1,647.19 kB | +1.35% | 323.57 kB | 327.92 kB\n| [facebook-www/ReactDOMTesting-dev.modern.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactDOMTesting-dev.modern.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.31%** | 1,647.16 kB | 1,668.65 kB | +1.34% | 328.10 kB | 332.50 kB\n| [facebook-www/ReactDOM-dev.classic.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactDOM-dev.classic.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.30%** | 1,655.54 kB | 1,677.04 kB | +1.31% | 328.96 kB | 333.27 kB\n| [facebook-www/ReactDOMTesting-dev.classic.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/facebook-www/ReactDOMTesting-dev.classic.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **+1.28%** | 1,677.06 kB | 1,698.56 kB | +1.29% | 333.51 kB | 337.81 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2f2eb4d456fe9a9af01c0295fd5234e2a7217db6/files/__test_utils__/ReactAllWarnings.js?compare=f7aa5e0aa3e2aa51279af4b6cb5413912cacd7f5) | **Deleted** | 65.20 kB | 0.00 kB | Deleted | 16.32 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2f2eb4d456fe9a9af01c0295fd5234e2a7217db6\n</p>\n",
"I'm sure I could just read the tests but — what's the PROD situation? Do you get a diff in PROD or is it less detailed?",
"You get nothing in prod. Just minimized error with the error code linking to a page with this message but no context.\r\n\r\nHowever, if you're logging it yourself you do have access to component stacks in onRecoverableError but it's up to a production logging tool to format that and it won't have access to props etc."
] | 2024-03-07 03:35:06 | 2024-03-27 00:06:56 | 2024-03-27 00:02:19 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28512', 'html_url': 'https://github.com/facebook/react/pull/28512', 'diff_url': 'https://github.com/facebook/react/pull/28512.diff', 'patch_url': 'https://github.com/facebook/react/pull/28512.patch', 'merged_at': datetime.datetime(2024, 3, 27, 0, 2, 19)} | Stacked on #28502.
This builds on the mechanism in #28502 by adding a diff of everything we've collected so far to the thrown error or logged error.
This isn't actually a longest common subsequence diff. This means that there are certain cases that can appear confusing such as a node being added/removed when it really would've appeared later in the list. In fact once a node mismatches, we abort rendering so we don't have the context of what would've been rendered. It's not quite right to use the result of the recovery render because it can use client-only code paths using useSyncExternalStore which would yield false differences. That's why diffing the HTML isn't quite right.
I also present abstract components in the stack, these are presented with the client props and no diff since we don't have the props that were on the server. The lack of difference might be confusing but it's useful for context.
The main thing that's data new here is that we're adding some siblings and props for context.
Examples in the [snapshot commit](https://github.com/facebook/react/pull/28512/commits/e14532fd8df858a319d3eca687d83227209a498c). | {'url': 'https://api.github.com/repos/facebook/react/issues/28512/reactions', 'total_count': 40, '+1': 15, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 16, 'rocket': 9, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28512/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28511 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28511/labels{/name} | https://api.github.com/repos/facebook/react/issues/28511/comments | https://api.github.com/repos/facebook/react/issues/28511/events | https://github.com/facebook/react/issues/28511 | 2,172,754,084 | I_kwDOAJy2Ks6BgZik | 28,511 | Bug: server actions cannot be cancelled or given abort signals | {'login': 'AaronFriel', 'id': 788800, 'node_id': 'MDQ6VXNlcjc4ODgwMA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/788800?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AaronFriel', 'html_url': 'https://github.com/AaronFriel', 'followers_url': 'https://api.github.com/users/AaronFriel/followers', 'following_url': 'https://api.github.com/users/AaronFriel/following{/other_user}', 'gists_url': 'https://api.github.com/users/AaronFriel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/AaronFriel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/AaronFriel/subscriptions', 'organizations_url': 'https://api.github.com/users/AaronFriel/orgs', 'repos_url': 'https://api.github.com/users/AaronFriel/repos', 'events_url': 'https://api.github.com/users/AaronFriel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/AaronFriel/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"hey,\r\nTo achieve the expected behavior, you would need to implement a mechanism on the server-side to handle this. One common approach is to use a unique token for each request. The client sends this token with each request, and if the client disconnects, it sends a cancellation request with the same token. The server then checks for cancellation requests with the same token before and during the processing of the request.\r\n\r\n\r\n\r\n\r\n",
"I don't think that seems like a reasonable solution, as it relies upon:\r\n* Follow-up requests being routed to the same server as the original request\r\n* Infrastructure to store and poll/react to cancellation tokens globally, i.e.: redis.\r\n\r\nBoth of those seem pretty absurd, given that fetches can be aborted, the client can hang up the request. It should be possible to react to that."
] | 2024-03-07 01:18:26 | 2024-03-11 20:52:48 | null | NONE | null | null | null | React version: 18.2.0
## Steps To Reproduce
1. As in #28510, create a server action that has some long-running delay, e.g.: to simulate a large language model call.
2. There is no API on the client or server to trigger cancellation, or to detect or handle the client navigating away from the page.
Link to code example: https://codesandbox.io/p/devbox/next-14-0-3-forked-7q86s7?file=%2Fapp%2Factions.ts%3A4%2C18&workspaceId=958ee911-ec8f-4ca3-9ce1-668005ecaeb8
## The current behavior
When a long-running request is fired, the server will complete it regardless of client behavior, e.g.: client hangup.
## The expected behavior
An API for server actions to obtain a reference to an AbortController (or similar API) for the request, perhaps via async local context.
An API for clients to signal cancellation of a server action, perhaps via an additional return value on `startTransition`, perhaps as part of the transition APIs. If a transition is explicitly created, there should be a mechanism to cancel it. | {'url': 'https://api.github.com/repos/facebook/react/issues/28511/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28511/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28510 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28510/labels{/name} | https://api.github.com/repos/facebook/react/issues/28510/comments | https://api.github.com/repos/facebook/react/issues/28510/events | https://github.com/facebook/react/issues/28510 | 2,172,743,978 | I_kwDOAJy2Ks6BgXEq | 28,510 | Bug: promises passed to server actions block on promise parameters | {'login': 'AaronFriel', 'id': 788800, 'node_id': 'MDQ6VXNlcjc4ODgwMA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/788800?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AaronFriel', 'html_url': 'https://github.com/AaronFriel', 'followers_url': 'https://api.github.com/users/AaronFriel/followers', 'following_url': 'https://api.github.com/users/AaronFriel/following{/other_user}', 'gists_url': 'https://api.github.com/users/AaronFriel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/AaronFriel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/AaronFriel/subscriptions', 'organizations_url': 'https://api.github.com/users/AaronFriel/orgs', 'repos_url': 'https://api.github.com/users/AaronFriel/repos', 'events_url': 'https://api.github.com/users/AaronFriel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/AaronFriel/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [] | 2024-03-07 01:11:29 | 2024-03-07 01:11:29 | null | NONE | null | null | null | React version: 18.2.0
## Steps To Reproduce
1. Create a server action that takes a promise parameter `p`:
```js
"use server";
export async function serverAction(p: Promise<void>) {
console.log(p);
const t1 = new Date();
await p;
const t2 = new Date();
console.log("elapsed", t2.valueOf() - t1.valueOf());
return {
t1,
t2,
};
}
```
2. Pass `new Promise((r) => setTimeout(r, 10_000))` to that server action.
3. Expect that the action begins running immediately, then blocks on the promise, and reports an elapsed time of approximately 10 seconds.
Link to code example:
https://codesandbox.io/p/devbox/next-14-0-3-forked-7q86s7?file=%2Fapp%2Factions.ts%3A4%2C18&workspaceId=958ee911-ec8f-4ca3-9ce1-668005ecaeb8
## The current behavior
Serialization of promises is synchronous and blocking.
## The expected behavior
That a promise could be passed to a server action and resolved asynchronously, e.g., as a cancellation token. | {'url': 'https://api.github.com/repos/facebook/react/issues/28510/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28510/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28509 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28509/labels{/name} | https://api.github.com/repos/facebook/react/issues/28509/comments | https://api.github.com/repos/facebook/react/issues/28509/events | https://github.com/facebook/react/pull/28509 | 2,172,375,366 | PR_kwDOAJy2Ks5o4u6V | 28,509 | cleanup enableProfilerNestedUpdateScheduledHook feature flag | {'login': 'noahlemen', 'id': 5393571, 'node_id': 'MDQ6VXNlcjUzOTM1NzE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5393571?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/noahlemen', 'html_url': 'https://github.com/noahlemen', 'followers_url': 'https://api.github.com/users/noahlemen/followers', 'following_url': 'https://api.github.com/users/noahlemen/following{/other_user}', 'gists_url': 'https://api.github.com/users/noahlemen/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/noahlemen/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/noahlemen/subscriptions', 'organizations_url': 'https://api.github.com/users/noahlemen/orgs', 'repos_url': 'https://api.github.com/users/noahlemen/repos', 'events_url': 'https://api.github.com/users/noahlemen/events{/privacy}', 'received_events_url': 'https://api.github.com/users/noahlemen/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 64f354cf27a17c4e5b0dfcd908e47940cf947771...6f0dc94df99a4ec0f703b304765e4aab684bb640\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/6f0dc94df99a4ec0f703b304765e4aab684bb640/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 177.10 kB | 177.10 kB | = | 55.20 kB | 55.20 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/6f0dc94df99a4ec0f703b304765e4aab684bb640/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 177.64 kB | 177.64 kB | = | 55.53 kB | 55.53 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/6f0dc94df99a4ec0f703b304765e4aab684bb640/files/facebook-www/ReactDOM-prod.classic.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 594.34 kB | 594.34 kB | = | 104.96 kB | 104.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/6f0dc94df99a4ec0f703b304765e4aab684bb640/files/facebook-www/ReactDOM-prod.modern.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **=** | 577.60 kB | 577.60 kB | = | 102.02 kB | 102.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/6f0dc94df99a4ec0f703b304765e4aab684bb640/files/__test_utils__/ReactAllWarnings.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/6f0dc94df99a4ec0f703b304765e4aab684bb640/files/__test_utils__/ReactAllWarnings.js?compare=64f354cf27a17c4e5b0dfcd908e47940cf947771) | **Deleted** | 66.60 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 6f0dc94df99a4ec0f703b304765e4aab684bb640\n</p>\n"
] | 2024-03-06 20:31:23 | 2024-03-11 15:37:21 | 2024-03-11 15:37:17 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28509', 'html_url': 'https://github.com/facebook/react/pull/28509', 'diff_url': 'https://github.com/facebook/react/pull/28509.diff', 'patch_url': 'https://github.com/facebook/react/pull/28509.patch', 'merged_at': datetime.datetime(2024, 3, 11, 15, 37, 17)} | ## Summary
Looks like this was added years ago for instrumentation at meta that never ended up rolling out. Should be safe to clean up.
## How did you test this change?
`yarn test` | {'url': 'https://api.github.com/repos/facebook/react/issues/28509/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28509/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28508 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28508/labels{/name} | https://api.github.com/repos/facebook/react/issues/28508/comments | https://api.github.com/repos/facebook/react/issues/28508/events | https://github.com/facebook/react/pull/28508 | 2,172,329,556 | PR_kwDOAJy2Ks5o4kn7 | 28,508 | Devtools: Ensure component control flow is consistent with commit when using `useDeferredValue | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9ffe9102ffd08ca7a56c60aa6952208890d213ce...f94d6f746c5b62554fcf8bd5c679a85de8ee5128\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/f94d6f746c5b62554fcf8bd5c679a85de8ee5128/files/oss-stable/react-dom/cjs/react-dom.production.min.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 176.83 kB | 176.83 kB | = | 54.91 kB | 54.91 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.min.js](https://react-builds.vercel.app/commits/f94d6f746c5b62554fcf8bd5c679a85de8ee5128/files/oss-experimental/react-dom/cjs/react-dom.production.min.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/f94d6f746c5b62554fcf8bd5c679a85de8ee5128/files/facebook-www/ReactDOM-prod.classic.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 594.04 kB | 594.04 kB | = | 104.37 kB | 104.37 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/f94d6f746c5b62554fcf8bd5c679a85de8ee5128/files/facebook-www/ReactDOM-prod.modern.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **=** | 577.30 kB | 577.30 kB | = | 101.42 kB | 101.42 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f94d6f746c5b62554fcf8bd5c679a85de8ee5128/files/__test_utils__/ReactAllWarnings.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f94d6f746c5b62554fcf8bd5c679a85de8ee5128/files/__test_utils__/ReactAllWarnings.js?compare=9ffe9102ffd08ca7a56c60aa6952208890d213ce) | **Deleted** | 66.87 kB | 0.00 kB | Deleted | 16.36 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against f94d6f746c5b62554fcf8bd5c679a85de8ee5128\n</p>\n"
] | 2024-03-06 20:06:47 | 2024-03-14 14:41:52 | 2024-03-14 14:41:50 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28508', 'html_url': 'https://github.com/facebook/react/pull/28508', 'diff_url': 'https://github.com/facebook/react/pull/28508.diff', 'patch_url': 'https://github.com/facebook/react/pull/28508.patch', 'merged_at': datetime.datetime(2024, 3, 14, 14, 41, 50)} |
## Summary
We used to always return the value that was passed into `useDeferredValue` in `react-debug-tools`. This could cause your component to behave differently when it was inspected in Devtools. This is less of an issue when hooks cannot be called conditionally but `use` can.
If you stack this PR on https://github.com/facebook/react/pull/28467, you can also observe the "Context reads do not line up" crash when you instead write
```diff
-const contextDisplay = isPending ? React.use(Context) : '<none>';
+const contextDisplay = isPending ? '<none>' : React.use(Context);
```
## Test plan
- Adedd test to `packages/react-debug-tools/src/__tests__/ReactHooksInspectionIntegration-test.js` (review by commit to see change of behavior) | {'url': 'https://api.github.com/repos/facebook/react/issues/28508/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28508/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28507 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28507/labels{/name} | https://api.github.com/repos/facebook/react/issues/28507/comments | https://api.github.com/repos/facebook/react/issues/28507/events | https://github.com/facebook/react/pull/28507 | 2,172,236,674 | PR_kwDOAJy2Ks5o4P5- | 28,507 | react-server-dom-vite (implementation 2) | {'login': 'nksaraf', 'id': 11255148, 'node_id': 'MDQ6VXNlcjExMjU1MTQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/11255148?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nksaraf', 'html_url': 'https://github.com/nksaraf', 'followers_url': 'https://api.github.com/users/nksaraf/followers', 'following_url': 'https://api.github.com/users/nksaraf/following{/other_user}', 'gists_url': 'https://api.github.com/users/nksaraf/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/nksaraf/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/nksaraf/subscriptions', 'organizations_url': 'https://api.github.com/users/nksaraf/orgs', 'repos_url': 'https://api.github.com/users/nksaraf/repos', 'events_url': 'https://api.github.com/users/nksaraf/events{/privacy}', 'received_events_url': 'https://api.github.com/users/nksaraf/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [] | 2024-03-06 19:16:00 | 2024-03-29 16:46:33 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28507', 'html_url': 'https://github.com/facebook/react/pull/28507', 'diff_url': 'https://github.com/facebook/react/pull/28507.diff', 'patch_url': 'https://github.com/facebook/react/pull/28507.patch', 'merged_at': None} | - feat: react-server-dom-vite impl v2
- fix: hack in region.js
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28507/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28507/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28506 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28506/labels{/name} | https://api.github.com/repos/facebook/react/issues/28506/comments | https://api.github.com/repos/facebook/react/issues/28506/events | https://github.com/facebook/react/issues/28506 | 2,171,558,460 | I_kwDOAJy2Ks6Bb1o8 | 28,506 | Bug: React-ts can't support sass, which makes people suffer from obsessive-compulsive disorder! | {'login': 'The-wind-blows', 'id': 51013946, 'node_id': 'MDQ6VXNlcjUxMDEzOTQ2', 'avatar_url': 'https://avatars.githubusercontent.com/u/51013946?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/The-wind-blows', 'html_url': 'https://github.com/The-wind-blows', 'followers_url': 'https://api.github.com/users/The-wind-blows/followers', 'following_url': 'https://api.github.com/users/The-wind-blows/following{/other_user}', 'gists_url': 'https://api.github.com/users/The-wind-blows/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/The-wind-blows/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/The-wind-blows/subscriptions', 'organizations_url': 'https://api.github.com/users/The-wind-blows/orgs', 'repos_url': 'https://api.github.com/users/The-wind-blows/repos', 'events_url': 'https://api.github.com/users/The-wind-blows/events{/privacy}', 'received_events_url': 'https://api.github.com/users/The-wind-blows/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\nCoding Questions\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to browse through frequent questions about using React, as well as ask for help with specific questions.\r\n\r\nhttps://stackoverflow.com/questions/tagged/react\r\n\r\nTalk to other React developers\r\nThere are many online forums which are a great place for discussion about best practices and application architecture as well as the future of React.\r\n\r\nhttps://react.dev/community"
] | 2024-03-06 13:47:41 | 2024-03-06 14:36:33 | 2024-03-06 14:36:32 | NONE | null | null | null | npx create-react-app react-ts --template typescript
React version: 18.2.0
## Steps To Reproduce
1. npx create-react-app react-ts --template typescript
2. When you create the simplest component using Sass, you find that it doesn't work properly! This is just a small problem, but it's pretty maddening! ! ! Or you can just remove the default support for sass! ! !
error:
Cannot find module './index.scss' or its corresponding type declarations.
1 | import React, { useEffect } from 'react';
> 2 | import styles from './index.scss';
Shanghai China
| {'url': 'https://api.github.com/repos/facebook/react/issues/28506/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28506/timeline | null | not_planned | false |